25901 2009-05-20 17:03:40 -0700 [Gtk] Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag 2009-10-18 09:23:27 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 25531 0 jdiggs webkit-unassigned apinheiro commit-queue walker.willie xan.lopez zecke oldest_to_newest 122226 0 jdiggs 2009-05-20 17:03:40 -0700 Steps to reproduce: 1. Open the (to be) attached test case. 2. Use Accerciser to explore the accessible hierarchy Expected results: The text enclosed in <div></div> would be contained in an accessible object of ROLE_SECTION. Actual results: The text enclosed in <div></div> is contained in an accessible object of ROLE_PANEL. As for paragraphs contained in <div></div>, the expected hierarchy would include both roles, thus: - ROLE_SECTION - ROLE_PARAGRAPH - ROLE_TEXT 122227 1 30516 jdiggs 2009-05-20 17:04:46 -0700 Created attachment 30516 aforementioned test case 155441 2 jdiggs 2009-10-17 21:20:21 -0700 Now that I'm actually looking at these things from the other side.... :-) Bug 25530 is really two different bugs (and possibly three): 1. The accessible role being used with labels is wrong 2. The LABEL_FOR/LABELLED_BY relationship pair is missing (because, among other things, it seems accessible relationships haven't been implemented yet) 3. The accessible name of the AtkObject which is LABELLED_BY the label should be taken from the name of the label. And I'm starting to suspect that ain't going to happen magically on its own. So.... I've re-purposed this bug to deal with issue 1 (roles). 25530 can deal with the other two issues. Also, regarding this bit: > As for paragraphs contained in <div></div>, the expected hierarchy would > include both roles, thus: > > - ROLE_SECTION > - ROLE_PARAGRAPH > - ROLE_TEXT I suggested it because that's what Gecko does. I'm now starting to think doing that might be rather pointless, not to mention introduce a bunch of unneeded additional accessibles into the mix which might negatively impact performance. Therefore, I'm withdrawing this part for now. If, upon further consideration, I want it after all, I'll file a new bug for it. 155444 3 41370 jdiggs 2009-10-17 21:42:56 -0700 Created attachment 41370 proposed patch - take 1 Tested with both the test case for this bug and for the test case for bug 25530. 155478 4 zecke 2009-10-18 08:46:16 -0700 Seems fine but I'm waiting for Xan to comment. 155487 5 41370 xan.lopez 2009-10-18 08:57:34 -0700 Comment on attachment 41370 proposed patch - take 1 Yep, looks good! 155494 6 41370 commit-queue 2009-10-18 09:23:23 -0700 Comment on attachment 41370 proposed patch - take 1 Clearing flags on attachment: 41370 Committed r49751: <http://trac.webkit.org/changeset/49751> 155495 7 commit-queue 2009-10-18 09:23:27 -0700 All reviewed patches have been landed. Closing bug. 30516 2009-05-20 17:04:46 -0700 2009-05-20 17:04:46 -0700 aforementioned test case sections.html text/html 179 jdiggs PGh0bWw+CjxoZWFkPgo8dGl0bGU+U2ltcGxlIFRlc3Q8L3RpdGxlPgo8L2hlYWQ+Cjxib2R5Pgo8 ZGl2PkhlbGxvIHdvcmxkLjwvZGl2Pgo8ZGl2PkFub3RoZXIgZGl2PC9kaXY+CjxwPlBhcmFncmFw aCAxPC9wPgo8ZGl2Pgo8cD5BIHBhcmFncmFwaCBpbiBhIGRpdjwvcD4KPC9kaXY+CjwvYm9keT4K PC9odG1sPgo= 41370 2009-10-17 21:42:56 -0700 2009-10-18 09:23:23 -0700 proposed patch - take 1 25901-1.patch text/plain 2884 jdiggs RnJvbSA2MThkMzMxZTU1OTc3ZGIwZmE3MTMxYjNmMzdmMDI0NDM5Njc5NWMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2FubWFyaWUgRGlnZ3MgPGpvYW5tYXJpZS5kaWdnc0BnbWFp bC5jb20+CkRhdGU6IFN1biwgMTggT2N0IDIwMDkgMDA6Mzg6NTggLTA0MDAKU3ViamVjdDogW1BB VENIXSBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKQoKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI1OTAxClVzZSBBVEtfUk9MRV9TRUNUSU9OIGZvciBkaXZUYWcgYW5k IEFUS19ST0xFX0xBQkVMIGZvciBsYWJlbFRhZwoKUmVwbGFjZXMgdGhlIHVzZSBvZiBBVEtfUk9M RV9QQU5FTCB3aXRoIHRoZSBleHBlY3RlZCBhY2Nlc3NpYmxlIHJvbGVzLgoKKiBhY2Nlc3NpYmls aXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHA6Cih3ZWJraXRfYWNjZXNz aWJsZV9nZXRfcm9sZSk6Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2d0ay9BY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlckF0ay5jcHAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKy0tLS0tCiAyIGZp bGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1ODkwNzAxLi44 OGJiZDY0IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTEwLTE4ICBKb2FubWFyaWUgRGlnZ3MgIDxqb2Fu bWFyaWUuZGlnZ3NAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1 OTAxCisgICAgICAgIFVzZSBBVEtfUk9MRV9TRUNUSU9OIGZvciBkaXZUYWcgYW5kIEFUS19ST0xF X0xBQkVMIGZvciBsYWJlbFRhZworCisgICAgICAgIFJlcGxhY2VzIHRoZSB1c2Ugb2YgQVRLX1JP TEVfUEFORUwgd2l0aCB0aGUgZXhwZWN0ZWQgYWNjZXNzaWJsZSByb2xlcy4KKworICAgICAgICAq IGFjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcDoKKyAg ICAgICAgKHdlYmtpdF9hY2Nlc3NpYmxlX2dldF9yb2xlKToKKwogMjAwOS0xMC0xNyAgTmlrb2xh cyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBHZW9yZ2UgU3RhaWtvcy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsv QWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwIGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKaW5kZXggMGVjMDczYi4uY2U5 ZDU2NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlckF0ay5jcHAKKysrIGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nl c3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKQEAgLTI1Niw4ICsyNTYsNiBAQCBzdGF0aWMg QXRrUm9sZSBhdGtSb2xlKEFjY2Vzc2liaWxpdHlSb2xlIHJvbGUpCiAgICAgICAgIHJldHVybiBB VEtfUk9MRV9UQUJMRTsKICAgICBjYXNlIEFwcGxpY2F0aW9uUm9sZToKICAgICAgICAgcmV0dXJu IEFUS19ST0xFX0FQUExJQ0FUSU9OOwotICAgIC8vY2FzZSBMYWJlbFJvbGU6IC8vIFRPRE86IHNo b3VsZCB0aGlzIGJlIGNvdmVyZWQgaW4gdGhlIHN3aXRjaD8KLSAgICAvLyAgICByZXR1cm4gQVRL X1JPTEVfTEFCRUw7CiAgICAgY2FzZSBHcm91cFJvbGU6CiAgICAgY2FzZSBSYWRpb0dyb3VwUm9s ZToKICAgICAgICAgcmV0dXJuIEFUS19ST0xFX1BBTkVMOwpAQCAtMzAwLDExICsyOTgsMTcgQEAg c3RhdGljIEF0a1JvbGUgd2Via2l0X2FjY2Vzc2libGVfZ2V0X3JvbGUoQXRrT2JqZWN0KiBvYmpl Y3QpCiAgICAgICAgICAgICByZXR1cm4gQVRLX1JPTEVfTElTVF9JVEVNOwogICAgIH0KIAotICAg IC8vIFdlYkNvcmUgZG9lcyBub3Qga25vdyBhYm91dCBwYXJhZ3JhcGggcm9sZQorICAgIC8vIFdl YkNvcmUgZG9lcyBub3Qga25vdyBhYm91dCBwYXJhZ3JhcGggcm9sZSwgbGFiZWwgcm9sZSwgb3Ig c2VjdGlvbiByb2xlCiAgICAgaWYgKEFYT2JqZWN0LT5pc0FjY2Vzc2liaWxpdHlSZW5kZXJPYmpl Y3QoKSkgewogICAgICAgICBOb2RlKiBub2RlID0gc3RhdGljX2Nhc3Q8QWNjZXNzaWJpbGl0eVJl bmRlck9iamVjdCo+KEFYT2JqZWN0KS0+cmVuZGVyZXIoKS0+bm9kZSgpOwotICAgICAgICBpZiAo bm9kZSAmJiBub2RlLT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6cFRhZykpCi0gICAgICAgICAgICBy ZXR1cm4gQVRLX1JPTEVfUEFSQUdSQVBIOworICAgICAgICBpZiAobm9kZSkgeworICAgICAgICAg ICAgaWYgKG5vZGUtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpwVGFnKSkKKyAgICAgICAgICAgICAg ICByZXR1cm4gQVRLX1JPTEVfUEFSQUdSQVBIOworICAgICAgICAgICAgaWYgKG5vZGUtPmhhc1Rh Z05hbWUoSFRNTE5hbWVzOjpsYWJlbFRhZykpCisgICAgICAgICAgICAgICAgcmV0dXJuIEFUS19S T0xFX0xBQkVMOworICAgICAgICAgICAgaWYgKG5vZGUtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpk aXZUYWcpKQorICAgICAgICAgICAgICAgIHJldHVybiBBVEtfUk9MRV9TRUNUSU9OOworICAgICAg ICB9CiAgICAgfQogCiAgICAgLy8gTm90ZTogV2h5IGRvZXNuJ3QgV2ViQ29yZSBoYXZlIGEgcGFz c3dvcmQgZmllbGQgZm9yIHRoaXMKLS0gCjEuNi4zLjMKCg==