25891 2009-05-20 09:08:14 -0700 _NPN_HasMethod is too liberal in declaring methods 2009-07-16 22:18:30 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC OS X 10.5 RESOLVED LATER P2 Normal --- 1 zecke zecke oldest_to_newest 122176 0 zecke 2009-05-20 09:08:14 -0700 The current implementation is declaring every property that is !== undefined as a method. This should be changed. 122923 1 30626 zecke 2009-05-24 01:24:33 -0700 Created attachment 30626 LayoutTest to illustrate the current behavior With this layout test a null property and a string property will be declared as method by the _NPN_HasMethod function. 122934 2 30626 mjs 2009-05-24 03:45:59 -0700 Comment on attachment 30626 LayoutTest to illustrate the current behavior It's fine to land this test, but maybe note that the current behavior is buggy and will be fixed soon, with reference to this bug. 123022 3 30646 zecke 2009-05-25 00:49:42 -0700 Created attachment 30646 Test Case + SourceCode change + hopefully better ChangeLog entry This time also with changing the implementation of the method. I assume anders will provide comments and I should try to run the test within firefox to verify that behavior. 123023 4 30646 mjs 2009-05-25 01:20:06 -0700 Comment on attachment 30646 Test Case + SourceCode change + hopefully better ChangeLog entry r=me if this matches Firefox behavior (please test). 123574 5 levin 2009-05-29 11:32:52 -0700 Assign to zecke for landing to make it more clear in the commit queue (and there is something to verify before landing as well). 123669 6 zecke 2009-05-29 19:40:01 -0700 I had some difficulties in getting our example plugin loaded in ff. I will try it this weekend. 127728 7 30646 eric 2009-06-23 16:12:49 -0700 Comment on attachment 30646 Test Case + SourceCode change + hopefully better ChangeLog entry Fails to build: Ld /Users/eseidel/Projects/build/Debug/WebCore.framework/Versions/A/WebCore normal i386 cd /Users/eseidel/Projects/WebKit/WebCore setenv MACOSX_DEPLOYMENT_TARGET 10.5 /Developer/usr/bin/g++-4.2 -arch i386 -dynamiclib -L/Users/eseidel/Projects/build/Debug -F/Users/eseidel/Projects/build/Debug -F/System/Library/Frameworks/Carbon.framework/Frameworks -F/System/Library/Frameworks/ApplicationServices.framework/Frameworks -filelist /Users/eseidel/Projects/build/WebCore.build/Debug/WebCore.build/Objects-normal/i386/WebCore.LinkFileList -Wl,--no-demangle -exported_symbols_list /Users/eseidel/Projects/build/Debug/DerivedSources/WebCore/WebCore.exp -install_name /Users/eseidel/Projects/build/Debug/WebCore.framework/Versions/A/WebCore -mmacosx-version-min=10.5 -lWebCoreSQLite3 -lobjc -sub_library libobjc -umbrella WebKit -framework ApplicationServices -framework Carbon -framework Cocoa -framework JavaScriptCore -framework QuartzCore -framework SystemConfiguration -licucore -lobjc -lxml2 -Wl,-single_module -compatibility_version 1 -current_version 531.0 -o /Users/eseidel/Projects/build/Debug/WebCore.framework/Versions/A/WebCore Undefined symbols: "__ZN3JSC16jsIsFunctionTypeENS_7JSValueE", referenced from: __NPN_HasMethod in NP_jsobject.o ld: symbol(s) not found 127733 8 zecke 2009-06-23 16:21:04 -0700 Thanks for giving it a try. The build issue can be easily fixed (even after landing) the more serious problem is that first attempt to try the plugin + testcase in firefox failed... maybe you want to give it a try? 127863 9 30626 eric 2009-06-24 01:08:11 -0700 Comment on attachment 30626 LayoutTest to illustrate the current behavior Clearing r+ on this obsolete patch. 128112 10 zecke 2009-06-25 00:24:57 -0700 I managed to get the plugin built and tested on firefox... And we are not too liberal... in contrast we are not liberal enough. In WebKit hasmethod on a property with undefined value returns false but in firefox it returns true... should we bother? should we close this bug as invalid? 132464 11 zecke 2009-07-16 22:18:30 -0700 We are not aware of any issues this minor incompability is causing, so close the bug as LATER/WORKSFORSOME. 30626 2009-05-24 01:24:33 -0700 2009-06-24 01:08:11 -0700 LayoutTest to illustrate the current behavior 0001-2009-05-23-Holger-Hans-Peter-Freyther-zecke-selfi.patch text/plain 2925 zecke RnJvbSA5YjgxOGRiMDUzNGQ1MWIzZjVjZTdhYmRiODM4ZjdkNGI5YjJmNTNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IFN1biwgMjQgTWF5IDIwMDkgMDc6MDQ6NDggKzAyMDAKU3ViamVjdDog W1BBVENIXSAyMDA5LTA1LTIzICBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciAgPHplY2tlQHNl bGZpc2gub3JnPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1ODkxCgogICAgICAgIGJy b3dzZXJmdW5jcy0+aGFzbWV0aG9kIGlzIGRlY2xhcmluZyBhbnkgIT09IHVuZGVmaW5lZAogICAg ICAgIHByb3BlcnR5IGFzIGEgZnVuY3Rpb24gZXZlbiBpZiBpdCBpcyBub3QgY2FsbGFibGUuIEFk ZAogICAgICAgIG1vcmUgdGVzdCBjYXNlcyBmb3IgdGhhdC4KCiAgICAgICAgKiBwbHVnaW5zL25l dHNjYXBlLWludm9rZS1icm93c2VyZnVuY3MtZXhwZWN0ZWQudHh0OgogICAgICAgICogcGx1Z2lu cy9uZXRzY2FwZS1pbnZva2UtYnJvd3NlcmZ1bmNzLmh0bWw6Ci0tLQogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysK IC4uLi9uZXRzY2FwZS1pbnZva2UtYnJvd3NlcmZ1bmNzLWV4cGVjdGVkLnR4dCAgICAgIHwgICAg MyArKysKIC4uLi9wbHVnaW5zL25ldHNjYXBlLWludm9rZS1icm93c2VyZnVuY3MuaHRtbCAgICAg IHwgICAgMyArKysKIDMgZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggYTU3NDM1Mi4uYmE2N2E1NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisy MDA5LTA1LTIzICBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciAgPHplY2tlQHNlbGZpc2gub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTg5MQorCisgICAgICAgIGJyb3dz ZXJmdW5jcy0+aGFzbWV0aG9kIGlzIGRlY2xhcmluZyBhbnkgIT09IHVuZGVmaW5lZAorICAgICAg ICBwcm9wZXJ0eSBhcyBhIGZ1bmN0aW9uIGV2ZW4gaWYgaXQgaXMgbm90IGNhbGxhYmxlLiBBZGQK KyAgICAgICAgbW9yZSB0ZXN0IGNhc2VzIGZvciB0aGF0LgorCisgICAgICAgICogcGx1Z2lucy9u ZXRzY2FwZS1pbnZva2UtYnJvd3NlcmZ1bmNzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBwbHVn aW5zL25ldHNjYXBlLWludm9rZS1icm93c2VyZnVuY3MuaHRtbDoKKwogMjAwOS0wNS0yMyAgSmFu IE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBHdXN0YXZvIE5vcm9uaGEgYW5kIFhhbiBMb3Blei4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsdWdpbnMvbmV0c2NhcGUtaW52b2tlLWJyb3dzZXJmdW5jcy1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9wbHVnaW5zL25ldHNjYXBlLWludm9rZS1icm93c2VyZnVuY3MtZXhwZWN0ZWQu dHh0CmluZGV4IDhjNGUyOTIuLmUxYzk5ZmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsdWdp bnMvbmV0c2NhcGUtaW52b2tlLWJyb3dzZXJmdW5jcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0 VGVzdHMvcGx1Z2lucy9uZXRzY2FwZS1pbnZva2UtYnJvd3NlcmZ1bmNzLWV4cGVjdGVkLnR4dApA QCAtNCw3ICs0LDEwIEBAIFRlc3QgaWYgdGhlIHBsdWdpbiBjYW4gcHJvcGVybHkgaW52b2tlIHRo ZSBicm93c2VyZnVuY3MKIFRlc3RpbmcgaGFzbWV0aG9kCiBTVUNDRVNTOiBpbnRlcm5hbEZ1bmN0 aW9uCiBTVUNDRVNTOiBkb1N0dWZmCitTVUNDRVNTOiBzdHJpbmdQcm9wZXJ0eQorU1VDQ0VTUzog bnVsbFByb3BlcnR5CiBTVUNDRVNTOiB1bmRlZmluZWRQcm9wZXJ0eQorU1VDQ0VTUzogbm90RGVm aW5lZFByb3BlcnR5CiAKIFRlc3RpbmcgaGFzcHJvcGVydHkKIFNVQ0NFU1M6IGludGVybmFsRnVu Y3Rpb24KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsdWdpbnMvbmV0c2NhcGUtaW52b2tlLWJy b3dzZXJmdW5jcy5odG1sIGIvTGF5b3V0VGVzdHMvcGx1Z2lucy9uZXRzY2FwZS1pbnZva2UtYnJv d3NlcmZ1bmNzLmh0bWwKaW5kZXggMDRiMGZmYy4uM2I2ZTUyYiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGx1Z2lucy9uZXRzY2FwZS1pbnZva2UtYnJvd3NlcmZ1bmNzLmh0bWwKKysrIGIvTGF5 b3V0VGVzdHMvcGx1Z2lucy9uZXRzY2FwZS1pbnZva2UtYnJvd3NlcmZ1bmNzLmh0bWwKQEAgLTMx LDcgKzMxLDEwIEBAIGZ1bmN0aW9uIGRvVGVzdCgpCiAgICAgY29uc29sZS5pbm5lckhUTUwgKz0g IlRlc3RpbmcgaGFzbWV0aG9kPGJyIC8+IjsKICAgICBzaG91bGRCZUZ1bmN0aW9uKCJpbnRlcm5h bEZ1bmN0aW9uIiwgdHJ1ZSk7CiAgICAgc2hvdWxkQmVGdW5jdGlvbigiZG9TdHVmZiIsIHRydWUp OworICAgIHNob3VsZEJlRnVuY3Rpb24oInN0cmluZ1Byb3BlcnR5IiwgZmFsc2UpOworICAgIHNo b3VsZEJlRnVuY3Rpb24oIm51bGxQcm9wZXJ0eSIsIGZhbHNlKTsKICAgICBzaG91bGRCZUZ1bmN0 aW9uKCJ1bmRlZmluZWRQcm9wZXJ0eSIsIGZhbHNlKTsKKyAgICBzaG91bGRCZVByb3BlcnR5KCJu b3REZWZpbmVkUHJvcGVydHkiLCBmYWxzZSk7CiAKICAgICAvKiB0ZXN0IGhhc3Byb3BlcnR5ICov CiAgICAgY29uc29sZS5pbm5lckhUTUwgKz0gIjxiciAvPlRlc3RpbmcgaGFzcHJvcGVydHk8YnIg Lz4iOwotLSAKMS42LjAuNAoK 30646 2009-05-25 00:49:42 -0700 2009-06-23 16:12:49 -0700 Test Case + SourceCode change + hopefully better ChangeLog entry 0001-Change-_NPN_HasMethod-to-use-isJsFunction.patch text/plain 4492 zecke RnJvbSBjNTc2NTIxYzliNjQ1YjJkOTBjMjQ0M2Y0ZTlmZTZhNDBkMjFmODU5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IFN1biwgMjQgTWF5IDIwMDkgMDc6MDQ6NDggKzAyMDAKU3ViamVjdDog W1BBVENIXSBDaGFuZ2UgX05QTl9IYXNNZXRob2QgdG8gdXNlIGlzSnNGdW5jdGlvbgoKaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1ODkxCgpDdXJyZW50bHkgX05QTl9I YXNNZXRob2QgaXMgZGVjbGFyaW5nIGV2ZXJ5IEpTVmFsdWUgdGhhdAppcyBub3QgdW5kZWZpbmVk IGFzIGEgbWV0aG9kLiBUaGlzIG1pZ2h0IGJlIHRvIGxpYmVyYWwuIENoYW5nZQp0aGUgaW1wbGVt ZW50YXRpb24gdG8gdXNlIGlzSnNGdW5jdGlvbiBhbmQgYWRkIGEgdGVzdCBjYXNlCnRoYXQgU3Ry aW5nIGFuZCBOdWxsIGFyZSBub3QgdHJlYXRlZCBhcyBmdW5jdGlvbnMuIFRoZSBleGlzdGluZwp0 ZXN0IGlzIGFscmVhZHkgY2hlY2tpbmcgZm9yIG5hdGl2ZSBhbmQganMgZnVuY3Rpb25zIHRvIGJl CnRyZWF0ZWQgYXMgZnVuY3Rpb25zLgotLS0KIExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAuLi4vbmV0c2NhcGUt aW52b2tlLWJyb3dzZXJmdW5jcy1leHBlY3RlZC50eHQgICAgICB8ICAgIDMgKysrCiAuLi4vcGx1 Z2lucy9uZXRzY2FwZS1pbnZva2UtYnJvd3NlcmZ1bmNzLmh0bWwgICAgICB8ICAgIDMgKysrCiBX ZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTMg KysrKysrKysrKysrKwogV2ViQ29yZS9icmlkZ2UvTlBfanNvYmplY3QuY3BwICAgICAgICAgICAg ICAgICAgICAgfCAgICA0ICsrLS0KIDUgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTU3NDM1Mi4uMDU0MzcwMiAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDA5LTA1LTIzICBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciAgPHplY2tlQHNl bGZpc2gub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTg5MQorCisgICAg ICAgIGJyb3dzZXJmdW5jcy0+aGFzbWV0aG9kIHdhcyBkZWNsYXJpbmcgYW55ICE9PSB1bmRlZmlu ZWQKKyAgICAgICAgcHJvcGVydHkgYXMgYSBmdW5jdGlvbiBldmVuIGlmIGl0IGlzIG5vdCBjYWxs YWJsZS4gQWRkCisgICAgICAgIGEgdGVzdCBjYXNlIHRvIHZlcmlmeSB0aGF0IHRoaXMgYmVoYXZp b3IgaXMgY2hhbmdlZC4KKworICAgICAgICAqIHBsdWdpbnMvbmV0c2NhcGUtaW52b2tlLWJyb3dz ZXJmdW5jcy1leHBlY3RlZC50eHQ6CisgICAgICAgICogcGx1Z2lucy9uZXRzY2FwZS1pbnZva2Ut YnJvd3NlcmZ1bmNzLmh0bWw6CisKIDIwMDktMDUtMjMgIEphbiBNaWNoYWVsIEFsb256byAgPGpt YWxvbnpvQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3Jvbmhh IGFuZCBYYW4gTG9wZXouCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbHVnaW5zL25ldHNjYXBl LWludm9rZS1icm93c2VyZnVuY3MtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGx1Z2lucy9u ZXRzY2FwZS1pbnZva2UtYnJvd3NlcmZ1bmNzLWV4cGVjdGVkLnR4dAppbmRleCA4YzRlMjkyLi5l MWM5OWZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbHVnaW5zL25ldHNjYXBlLWludm9rZS1i cm93c2VyZnVuY3MtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3BsdWdpbnMvbmV0c2Nh cGUtaW52b2tlLWJyb3dzZXJmdW5jcy1leHBlY3RlZC50eHQKQEAgLTQsNyArNCwxMCBAQCBUZXN0 IGlmIHRoZSBwbHVnaW4gY2FuIHByb3Blcmx5IGludm9rZSB0aGUgYnJvd3NlcmZ1bmNzCiBUZXN0 aW5nIGhhc21ldGhvZAogU1VDQ0VTUzogaW50ZXJuYWxGdW5jdGlvbgogU1VDQ0VTUzogZG9TdHVm ZgorU1VDQ0VTUzogc3RyaW5nUHJvcGVydHkKK1NVQ0NFU1M6IG51bGxQcm9wZXJ0eQogU1VDQ0VT UzogdW5kZWZpbmVkUHJvcGVydHkKK1NVQ0NFU1M6IG5vdERlZmluZWRQcm9wZXJ0eQogCiBUZXN0 aW5nIGhhc3Byb3BlcnR5CiBTVUNDRVNTOiBpbnRlcm5hbEZ1bmN0aW9uCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbHVnaW5zL25ldHNjYXBlLWludm9rZS1icm93c2VyZnVuY3MuaHRtbCBiL0xh eW91dFRlc3RzL3BsdWdpbnMvbmV0c2NhcGUtaW52b2tlLWJyb3dzZXJmdW5jcy5odG1sCmluZGV4 IDA0YjBmZmMuLjdjY2ZmODEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsdWdpbnMvbmV0c2Nh cGUtaW52b2tlLWJyb3dzZXJmdW5jcy5odG1sCisrKyBiL0xheW91dFRlc3RzL3BsdWdpbnMvbmV0 c2NhcGUtaW52b2tlLWJyb3dzZXJmdW5jcy5odG1sCkBAIC0zMSw3ICszMSwxMCBAQCBmdW5jdGlv biBkb1Rlc3QoKQogICAgIGNvbnNvbGUuaW5uZXJIVE1MICs9ICJUZXN0aW5nIGhhc21ldGhvZDxi ciAvPiI7CiAgICAgc2hvdWxkQmVGdW5jdGlvbigiaW50ZXJuYWxGdW5jdGlvbiIsIHRydWUpOwog ICAgIHNob3VsZEJlRnVuY3Rpb24oImRvU3R1ZmYiLCB0cnVlKTsKKyAgICBzaG91bGRCZUZ1bmN0 aW9uKCJzdHJpbmdQcm9wZXJ0eSIsIGZhbHNlKTsKKyAgICBzaG91bGRCZUZ1bmN0aW9uKCJudWxs UHJvcGVydHkiLCBmYWxzZSk7CiAgICAgc2hvdWxkQmVGdW5jdGlvbigidW5kZWZpbmVkUHJvcGVy dHkiLCBmYWxzZSk7CisgICAgc2hvdWxkQmVGdW5jdGlvbigibm90RGVmaW5lZFByb3BlcnR5Iiwg ZmFsc2UpOwogCiAgICAgLyogdGVzdCBoYXNwcm9wZXJ0eSAqLwogICAgIGNvbnNvbGUuaW5uZXJI VE1MICs9ICI8YnIgLz5UZXN0aW5nIGhhc3Byb3BlcnR5PGJyIC8+IjsKZGlmZiAtLWdpdCBhL1dl YkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Q1YzQ0OC4uYzJmMWYw ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNiBAQAorMjAwOS0wNS0yNSAgSG9sZ2VyIEhhbnMgUGV0ZXIgRnJleXRoZXIg IDx6ZWNrZUBzZWxmaXNoLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU4 OTEKKworICAgICAgICBDaGFuZ2UgX05QTl9IYXNNZXRob2QgdG8gbm90IGRlY2xhcmUgTnVsbCBh bmQgU3RyaW5nCisgICAgICAgIGFzIGEgbWV0aG9kLiBDaGFuZ2UgX05QTl9IYXNNZXRob2QgdG8g dXNlIHRoZSBpc0pzRnVuY3Rpb24KKyAgICAgICAgb2YgcnVudGltZS9PcGVyYXRpb25zLmguCisK KyAgICAgICAgKiBicmlkZ2UvTlBfanNvYmplY3QuY3BwOgorICAgICAgICAoX05QTl9IYXNNZXRo b2QpOgorCiAyMDA5LTA1LTI0ICBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciAgPHplY2tlQHNl bGZpc2gub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9icmlkZ2UvTlBfanNvYmplY3QuY3BwIGIvV2ViQ29yZS9icmlkZ2Uv TlBfanNvYmplY3QuY3BwCmluZGV4IDMyNThjNTQuLjNmY2UxMzAgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvYnJpZGdlL05QX2pzb2JqZWN0LmNwcAorKysgYi9XZWJDb3JlL2JyaWRnZS9OUF9qc29iamVj dC5jcHAKQEAgLTQzLDcgKzQzLDcgQEAKICNpbmNsdWRlIDxydW50aW1lL1Byb3BlcnR5TmFtZUFy cmF5Lmg+CiAjaW5jbHVkZSA8cGFyc2VyL1NvdXJjZUNvZGUuaD4KICNpbmNsdWRlIDxydW50aW1l L0NvbXBsZXRpb24uaD4KLSNpbmNsdWRlIDxydW50aW1lL0NvbXBsZXRpb24uaD4KKyNpbmNsdWRl IDxydW50aW1lL09wZXJhdGlvbnMuaD4KIAogdXNpbmcgbmFtZXNwYWNlIEpTQzsKIHVzaW5nIG5h bWVzcGFjZSBKU0M6OkJpbmRpbmdzOwpAQCAtMzY3LDcgKzM2Nyw3IEBAIGJvb2wgX05QTl9IYXNN ZXRob2QoTlBQLCBOUE9iamVjdCogbywgTlBJZGVudGlmaWVyIG1ldGhvZE5hbWUpCiAgICAgICAg IEpTTG9jayBsb2NrKGZhbHNlKTsKICAgICAgICAgSlNWYWx1ZSBmdW5jID0gb2JqLT5pbXAtPmdl dChleGVjLCBpZGVudGlmaWVyRnJvbU5QSWRlbnRpZmllcihpLT5zdHJpbmcoKSkpOwogICAgICAg ICBleGVjLT5jbGVhckV4Y2VwdGlvbigpOwotICAgICAgICByZXR1cm4gIWZ1bmMuaXNVbmRlZmlu ZWQoKTsKKyAgICAgICAgcmV0dXJuIGpzSXNGdW5jdGlvblR5cGUoZnVuYyk7CiAgICAgfQogICAg IAogICAgIGlmIChvLT5fY2xhc3MtPmhhc01ldGhvZCkKLS0gCjEuNi4wLjQKCg==