258870 2023-07-05 01:42:35 -0700 ElementInternals.setFormValue(<nullish value>) doesn't clear submission value 2023-07-18 07:31:23 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build All All RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/41090 InRadar P2 Normal --- 154907 1 fayti1703 ashvayka akeerthi ashvayka rniwa webkit-bug-importer oldest_to_newest 1965075 0 466930 fayti1703 2023-07-05 01:42:35 -0700 Created attachment 466930 Testcase Trying to remove a form-associated custom element's value via `.internals.setFormValue(null)` fails silently -- the old value appears during form submission and `FormData` construction on the parent form. I've attached a test-case to demonstrate the issue. (Firefox 114 and Chrome 114 pass) 1965177 1 ashvayka 2023-07-05 12:05:53 -0700 (In reply to fayti1703 from comment #0) > Created attachment 466930 [details] > Testcase > > Trying to remove a form-associated custom element's value via > `.internals.setFormValue(null)` fails silently -- the old value appears > during form submission and `FormData` construction on the parent form. > > I've attached a test-case to demonstrate the issue. (Firefox 114 and Chrome > 114 pass) Thank you for the test case, I will take a look today. 1965180 2 webkit-bug-importer 2023-07-05 12:18:34 -0700 <rdar://problem/111802198> 1965182 3 ashvayka 2023-07-05 12:43:40 -0700 Oh it seems with current bindings generator implementation, for `optional FormValue? state`, we can't differentiate between explicit `null` / `undefined` and a missing argument. I am aware the bug is about first parameter, `value`, yet this fact ^^ affects the approach on how to fix it. 1966190 4 ashvayka 2023-07-11 07:38:56 -0700 Pull request: https://github.com/WebKit/WebKit/pull/15741 1967172 5 ews-feeder 2023-07-18 07:31:21 -0700 Committed 266126@main (b691e0b9a450): <https://commits.webkit.org/266126@main> Reviewed commits have been landed. Closing PR #15741 and removing active labels. 466930 2023-07-05 01:42:35 -0700 2023-07-05 01:51:50 -0700 Testcase file_258870.txt text/html 785 fayti1703 PCFET0NUWVBFIGh0bWw+DQo8aHRtbD48aGVhZD4NCgk8c2NyaXB0Pg0KCQljdXN0b21FbGVtZW50 cy5kZWZpbmUoInRlc3QtZm9ybS1lbGVtZW50IiwgY2xhc3MgZXh0ZW5kcyBIVE1MRWxlbWVudCB7 DQoJCQlzdGF0aWMgZm9ybUFzc29jaWF0ZWQgPSB0cnVlOw0KCQkJY29uc3RydWN0b3IoKSB7DQoJ CQkJc3VwZXIoKTsNCgkJCQl0aGlzLmludGVybmFscyA9IHRoaXMuYXR0YWNoSW50ZXJuYWxzKCk7 DQoJCQl9DQoJCX0pOw0KCTwvc2NyaXB0Pg0KPC9oZWFkPjxib2R5Pg0KCTxmb3JtIGlkPSJmb3Jt Ij4NCgkJPHRlc3QtZm9ybS1lbGVtZW50IGlkPSJpbnB1dCIgbmFtZT0iaW5wdXQiPjwvdGVzdC1m b3JtLWVsZW1lbnQ+DQoJPC9mb3JtPg0KCTxzY3JpcHQ+DQoJICAoKCkgPT4gew0KCSAgICBjb25z dCBpbnB1dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJpbnB1dCIpOw0KCSAgICBpZighKCJz ZXRGb3JtVmFsdWUiIGluIGlucHV0LmludGVybmFscykpIHsNCgkJICAgIGFsZXJ0KCIhUFJFIik7 DQoJICAgICAgcmV0dXJuOw0KICAgICAgfQ0KCSAgICBpbnB1dC5pbnRlcm5hbHMuc2V0Rm9ybVZh bHVlKCJmYWlsIik7DQoJICAgIGlucHV0LmludGVybmFscy5zZXRGb3JtVmFsdWUobnVsbCk7DQoJ ICAgIGNvbnN0IGZvcm1EYXRhID0gbmV3IEZvcm1EYXRhKGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJmb3JtIikpOw0KCSAgICBhbGVydChmb3JtRGF0YS5oYXMoImlucHV0IikgPyAiRkFJTCIgOiAi UEFTUyIpDQoJICB9KSgpOw0KCTwvc2NyaXB0Pg0KPC9ib2R5PjwvaHRtbD4=