258865 2023-07-04 21:07:45 -0700 Attachment ref-tests should wait for the icon to be present 2023-07-18 15:53:02 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 g_squelart g_squelart rackler ryanhaddad webkit-bug-importer wenson_hsieh oldest_to_newest 1965050 0 g_squelart 2023-07-04 21:07:45 -0700 Attachment ref-tests don't add any delay before a snapshot is taken. However, attachments request their icon asynchronously during their first paint, meaning that if the snapshot is taken after this first paint it will probably not have the icon! So I'm suspecting that ref-tests don't actually compare icons, and that intermittent failures could be due to the odd case when the icon is available unexpectedly fast. To fix this, tests should delay the snapshot until all attachments have received their icon. 1965051 1 webkit-bug-importer 2023-07-04 21:07:57 -0700 <rdar://problem/111764330> 1965052 2 g_squelart 2023-07-04 21:14:04 -0700 Pull request: https://github.com/WebKit/WebKit/pull/15554 1966297 3 ryanhaddad 2023-07-11 16:17:28 -0700 *** Bug 259127 has been marked as a duplicate of this bug. *** 1966413 4 rackler 2023-07-12 10:47:08 -0700 REGRESSION (265615@main): [ iOS macOS wk2 ] Four fast/attachment/cocoa/wide-attachment tests are flaky image failures After landing 265615@main, some wide-attachment-* tests became flaky because of the way the icon is asynchronously fetched and then loaded into an img. Description: fast/attachment/cocoa/wide-attachment-folder-icon.html fast/attachment/cocoa/wide-attachment-icon-from-file-extension.html fast/attachment/mac/wide-attachment-title-with-rtl.html fast/attachment/mac/wide-attachment-type-attribute.html History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fattachment%2Fcocoa%2Fwide-attachment-folder-icon.html&test=fast%2Fattachment%2Fcocoa%2Fwide-attachment-icon-from-file-extension.html&test=fast%2Fattachment%2Fmac%2Fwide-attachment-title-with-rtl.html&test=fast%2Fattachment%2Fmac%2Fwide-attachment-type-attribute.html&platform=mac Since the resolution is being worked on in this bug, I have marked these tests as flaky image failures here while this issue is investigated. 1966415 5 ews-feeder 2023-07-12 10:52:27 -0700 Test gardening commit 265994@main (b8b69392a0cc): <https://commits.webkit.org/265994@main> Reviewed commits have been landed. Closing PR #15786 and removing active labels. 1966428 6 ews-feeder 2023-07-12 12:14:24 -0700 Test gardening commit 265870.40@safari-7616-branch (a5090f836a89): <https://commits.webkit.org/265870.40@safari-7616-branch> Reviewed commits have been landed. Closing PR #692 and removing active labels. 1967262 7 ews-feeder 2023-07-18 15:53:01 -0700 Committed 266144@main (6e502e9d0156): <https://commits.webkit.org/266144@main> Reviewed commits have been landed. Closing PR #15554 and removing active labels.