258827 2023-07-03 14:55:31 -0700 Bug 258793 follow-up: Add test to exercise the null-decoder-with-NoError path in Connection::sendSyncMessage and StreamClientConnection::trySendSyncStream 2023-07-10 14:56:41 -0700 1 1 1 Unclassified WebKit WebKit Process Model WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 258793 258861 1 g_squelart kkinnunen webkit-bug-importer oldest_to_newest 1964878 0 g_squelart 2023-07-03 14:55:31 -0700 Bug 258793 modified `Connection::sendSyncMessage` to handle a code path that could potential return a null `Decoder` pointer along with an `Error::NoError`, which could eventually lead callers (e.g.: `WebPaymentCoordinator::canMakePayments`) to attempt to read the value of an empty `std::optional`. Unless the real root cause is found that would remove this code path entirely, it would be good to add a proper test that exercises it. 1965090 1 g_squelart 2023-07-05 02:44:24 -0700 Bug 258861 added a couple of other similar fixes in StreamClientConnection::trySendSyncStream. 1966048 2 webkit-bug-importer 2023-07-10 14:56:41 -0700 <rdar://problem/112040784>