<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>258767</bug_id>
          
          <creation_ts>2023-07-01 06:52:54 -0700</creation_ts>
          <short_desc>[WPE] run-minibrowser: unit test test_browser_name_default_with_cog_built is failing</short_desc>
          <delta_ts>2023-07-02 18:16:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Diego Pino">dpino</reporter>
          <assigned_to name="Diego Pino">dpino</assigned_to>
          <cc>clopez</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1964625</commentid>
    <comment_count>0</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2023-07-01 06:52:54 -0700</bug_when>
    <thetext>Unit test test_browser_name_default_with_cog_built is producing the following error in the WPE-Release-Test bot:

```
[1057/2215] webkitpy.port.wpe_unittest.WPEPortTest.test_browser_name_default_with_cog_built failed:
  Traceback (most recent call last):
    File &quot;/app/webkit/Tools/Scripts/webkitpy/port/wpe_unittest.py&quot;, line 94, in test_browser_name_default_with_cog_built
      self.assertEqual(port.browser_name(), &quot;cog&quot;)
  AssertionError: &apos;minibrowser&apos; != &apos;cog&apos;
  - minibrowser
  + cog
```

The reason is that environment variable WPE_BROWSER is set to &apos;minibrowser&apos; in that host. The test should evaluate `port.browser_name()` on an empty environment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1964626</commentid>
    <comment_count>1</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2023-07-01 06:58:22 -0700</bug_when>
    <thetext>Pull request: https://github.com/webkit/webkit/pull/15478</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1964724</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-07-02 18:15:54 -0700</bug_when>
    <thetext>Committed 265700@main (de456d04c100): &lt;https://commits.webkit.org/265700@main&gt;

Reviewed commits have been landed. Closing PR #15478 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1964725</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-07-02 18:16:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/111660311&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>