258740 2023-06-30 10:19:37 -0700 Fix shadow invalidation rect issue in vertical-rl mode 2023-12-01 17:54:56 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=264625 InRadar P2 Normal --- 1 ahmad.saleem792 webkit-unassigned bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1964516 0 ahmad.saleem792 2023-06-30 10:19:37 -0700 Hi Team, While going through Blink's commit, I came across another clean-up to fix shadow invalidation rects issue and don't seems to have any failing test case (in /fast/ directory). Blink Commit: https://src.chromium.org/viewvc/blink?revision=177246&view=revision Just wanted to raise, so I can get input, whether it is good to merge or not. Thanks! 1964517 1 ahmad.saleem792 2023-06-30 10:22:19 -0700 WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBox.cpp#5074 1964779 2 zalan 2023-07-03 06:24:39 -0700 I'd look at the history of those flipped lines to see why we originally thought they needed flipping. Blink's commit message does not explain that (it just says it's erroneous) 1964782 3 ahmad.saleem792 2023-07-03 06:32:26 -0700 (In reply to zalan from comment #2) > I'd look at the history of those flipped lines to see why we originally > thought they needed flipping. Blink's commit message does not explain that > (it just says it's erroneous) Original bugs refer this: Shadows and border images should be unrelated to writing-mode. Should not flip the edges when invalidating them despite writing-mode. and in spec: https://drafts.csswg.org/css-writing-modes-3/#physical-only "The following values are purely physical in their definitions and do not respond to changes in writing mode:" -> the offsets of the box-shadow and text-shadow properties 1965615 4 webkit-bug-importer 2023-07-07 10:20:17 -0700 <rdar://problem/111915460> 1996104 5 ahmad.saleem792 2023-11-30 18:37:05 -0800 I tried to look back into this and this patch added the comment: https://bugs.webkit.org/attachment.cgi?id=106906&action=diff Although it is not super clear to myself. Since Simon is working on 'overflow' and 'repaint rects' clean-up, I think he might have more insight. @Simon - any insight? 1996105 6 ahmad.saleem792 2023-11-30 18:37:09 -0800 I tried to look back into this and this patch added the comment: https://bugs.webkit.org/attachment.cgi?id=106906&action=diff Although it is not super clear to myself. Since Simon is working on 'overflow' and 'repaint rects' clean-up, I think he might have more insight. @Simon - any insight? 1996269 7 simon.fraser 2023-12-01 10:29:45 -0800 I think we do want to take this change. 1996399 8 ews-feeder 2023-12-01 17:54:54 -0800 Committed 271416@main (b738ab355f6e): <https://commits.webkit.org/271416@main> Reviewed commits have been landed. Closing PR #21174 and removing active labels.