258725 2023-06-30 06:31:12 -0700 Stop resolving border's current color to some hardcoded value 2024-09-18 22:40:28 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=261847 InRadar P2 Normal --- 261847 1 vitaly webkit-unassigned ahmad.saleem792 dholbert simon.fraser webkit-bug-importer oldest_to_newest 1964465 0 vitaly 2023-06-30 06:31:12 -0700 In `Color RenderStyle::colorResolvingCurrentColor(CSSPropertyID colorProperty, bool visitedLink) const` we currently return some hardcoded value for border colors: ``` auto result = unresolvedColorForProperty(colorProperty, visitedLink); if (result.isCurrentColor()) { auto borderStyle = [&] { switch (colorProperty) { case CSSPropertyBorderLeftColor: return borderLeftStyle(); case CSSPropertyBorderRightColor: return borderRightStyle(); case CSSPropertyBorderTopColor: return borderTopStyle(); case CSSPropertyBorderBottomColor: return borderBottomStyle(); default: return BorderStyle::None; } }(); if (!visitedLink && (borderStyle == BorderStyle::Inset || borderStyle == BorderStyle::Outset || borderStyle == BorderStyle::Ridge || borderStyle == BorderStyle::Groove)) return { SRGBA<uint8_t> { 238, 238, 238 } }; return visitedLink ? visitedLinkColor() : color(); } ``` I can't think of any good reason for doing this. The result can be unexpected for web developers. 1964467 1 vitaly 2023-06-30 06:35:45 -0700 Pull request: https://github.com/WebKit/WebKit/pull/15447 1965543 2 webkit-bug-importer 2023-07-07 06:32:16 -0700 <rdar://problem/111905474> 1966788 3 ahmad.saleem792 2023-07-14 12:06:07 -0700 *** Bug 256528 has been marked as a duplicate of this bug. *** 1967212 4 ews-feeder 2023-07-18 11:12:53 -0700 Committed 266134@main (0aa032e26bbd): <https://commits.webkit.org/266134@main> Reviewed commits have been landed. Closing PR #15447 and removing active labels. 1967226 5 simon.fraser 2023-07-18 13:26:32 -0700 Do we understand why this code was added in the first place? 1978871 6 simon.fraser 2023-09-20 19:48:23 -0700 This caused https://bugs.webkit.org/show_bug.cgi?id=261847 2061351 7 ntim 2024-09-18 22:40:28 -0700 *** Bug 195015 has been marked as a duplicate of this bug. ***