258669 2023-06-29 05:05:11 -0700 VideoEncoder does not call output callback on FullHD configuration 2023-07-06 00:05:05 -0700 1 1 1 Unclassified WebKit Media Safari 16 Mac (Apple Silicon) macOS 13 RESOLVED FIXED InRadar P2 Normal --- 1 jozefchutka youennf eric.carlson jer.noble webkit-bug-importer youennf oldest_to_newest 1964230 0 466864 jozefchutka 2023-06-29 05:05:11 -0700 Created attachment 466864 bug demonstration When encoding FullHD VideoFrame-s with avc1 VideoEncoder, the output callback is never executed even after encoder.flush() call. - This problem only exists on frames larger than ~912000 pixels (912x1000 or more, i.e. 1920x1080). - There is no error thrown during the code execution. - VideoEncoder.isConfigSupported reports that the config is supported. - Same config works on Chrome and produces encoded data. - However, the output callback is fired as expected on videos with lower resolution i.e. 1280x720. - Changing codec to vp8 or vp09.00.10.08 with FullHD res also works and produces encoded data. I tried to change various properties for `VideoEncoder.configure(...)` as well as `new VideoFrame(...)` but no luck. See attached safari-bug.html for demonstration. 1964234 1 jozefchutka 2023-06-29 05:40:59 -0700 actually the max working width/height is a tricky one to resolve: - 1280x720 works ok (921600 pixels) - 916x1000 does not work (916000 pixels) 1964798 2 webkit-bug-importer 2023-07-03 07:26:46 -0700 <rdar://problem/111685821> 1965105 3 youennf 2023-07-05 06:10:01 -0700 Pull request: https://github.com/WebKit/WebKit/pull/15562 1965261 4 ews-feeder 2023-07-06 00:05:03 -0700 Committed 265792@main (9879838d0315): <https://commits.webkit.org/265792@main> Reviewed commits have been landed. Closing PR #15562 and removing active labels. 466864 2023-06-29 05:05:11 -0700 2023-06-29 05:05:11 -0700 bug demonstration safari-bug.html text/html 1431 jozefchutka PGJvZHk+CjxzY3JpcHQ+Cihhc3luYyAoKSA9PiB7CmNvbnN0IGNvZGVjID0gImF2YzEuNjQwMDM0 IjsKY29uc3Qgd2lkdGggPSAxOTIwOyAvLyA5MTIgeCAxMDAwCmNvbnN0IGhlaWdodCA9IDEwODA7 CmNvbnN0IGZyYW1lcmF0ZSA9IDMwOwpjb25zdCBjb25maWcgPSB7Y29kZWMsIHdpZHRoLCBoZWln aHQsIGZyYW1lcmF0ZSwKCWF2Yzp7Zm9ybWF0OiJhbm5leGIifSwgaGFyZHdhcmVBY2NlbGVyYXRp b246InByZWZlci1zb2Z0d2FyZSJ9OwoJCmNvbnN0IGNvbmZpZ1ZhbGlkYXRpb24gPSBhd2FpdCBW aWRlb0VuY29kZXIuaXNDb25maWdTdXBwb3J0ZWQoY29uZmlnKTsKZG9jdW1lbnQuYm9keS5hcHBl bmQoSlNPTi5zdHJpbmdpZnkoY29uZmlnVmFsaWRhdGlvbikpOwoKY29uc3QgY2h1bmtzID0gW107 CmNvbnN0IGVuY29kZXIgPSBuZXcgVmlkZW9FbmNvZGVyKHsKCW91dHB1dDpjaHVuayA9PiB7CgkJ Y29uc3QgYnVmZmVyID0gbmV3IEFycmF5QnVmZmVyKGNodW5rLmJ5dGVMZW5ndGgpOwoJCWNodW5r LmNvcHlUbyhidWZmZXIpOwoJCWNodW5rcy5wdXNoKGJ1ZmZlcik7Cgl9LAoJZXJyb3I6ZXJyb3Ig PT4gY29uc29sZS5sb2coZXJyb3IpCn0pOwplbmNvZGVyLmNvbmZpZ3VyZShjb25maWdWYWxpZGF0 aW9uLmNvbmZpZyk7Cgpjb25zdCBjYW52YXMgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJjYW52 YXMiKTsKY2FudmFzLndpZHRoID0gd2lkdGg7CmNhbnZhcy5oZWlnaHQgPSBoZWlnaHQ7Cgpjb25z dCBmcmFtZXMgPSBmcmFtZXJhdGUgKiA1Owpjb25zdCBjdHggPSBjYW52YXMuZ2V0Q29udGV4dCgi MmQiKTsKZm9yKGxldCBpID0gMDsgaSA8IGZyYW1lczsgaSsrKSB7CgljdHguY2xlYXJSZWN0KDAs IDAsIHdpZHRoLCBoZWlnaHQpOwoJY3R4LmJlZ2luUGF0aCgpOwoJY3R4LnJlY3QoaSAvIGZyYW1l cyAqICh3aWR0aCAqIC44KSwgaGVpZ2h0IC8gMi41LCB3aWR0aCAvIDUsIGhlaWdodCAvIDUpOwoJ Y3R4LmZpbGxTdHlsZSA9ICJyZWQiOwoJY3R4LmZpbGwoKTsKCQoJY29uc3QgZnJhbWUgPSBuZXcg VmlkZW9GcmFtZShjYW52YXMsIHsKCQl0aW1lc3RhbXA6TWF0aC5yb3VuZChpIC8gZnJhbWVyYXRl ICogMTAwMDAwMCksCgkJZHVyYXRpb246TWF0aC5yb3VuZCgxIC8gZnJhbWVyYXRlICogMTAwMDAw MCl9KTsKCQoJY29uc3Qga2V5RnJhbWUgPSAhKGkgJSBmcmFtZXJhdGUpOwoJZW5jb2Rlci5lbmNv ZGUoZnJhbWUsIHtrZXlGcmFtZX0pOwoJZnJhbWUuY2xvc2UoKTsKfQoKYXdhaXQgZW5jb2Rlci5m bHVzaCgpOwplbmNvZGVyLmNsb3NlKCk7Cgpjb25zdCBibG9iID0gbmV3IEJsb2IoY2h1bmtzKTsK ZG9jdW1lbnQuYm9keS5hcHBlbmQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYnIiKSk7CmRvY3Vt ZW50LmJvZHkuYXBwZW5kKGBlbmNvZGVkOiAke2Jsb2Iuc2l6ZX0gYnl0ZXNgKTsKCn0pKCkKPC9z Y3JpcHQ+