<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>25861</bug_id>
          
          <creation_ts>2009-05-18 22:13:55 -0700</creation_ts>
          <short_desc>Remove http/tests/cookies/simple-cookies-expired.html from skip list after CFNetwork issue is resolved</short_desc>
          <delta_ts>2011-12-02 14:05:06 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, LayoutTestFailure</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Kilzer (:ddkilzer)">ddkilzer</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aroben</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>jchaffraix</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>121857</commentid>
    <comment_count>0</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-05-18 22:13:55 -0700</bug_when>
    <thetext>* SUMMARY
One of the tests added for Bug 24569 fails inexplicably on Windows:

LayoutTests/http/tests/cookies/simple-cookies-expired.html

It was added to the Skipped list to keep the buildbot green.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>121878</commentid>
    <comment_count>1</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2009-05-19 00:46:45 -0700</bug_when>
    <thetext>&lt;rdar://problem/6901322&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>121939</commentid>
    <comment_count>2</comment_count>
    <who name="Alice Liu">alice.barraclough</who>
    <bug_when>2009-05-19 11:04:14 -0700</bug_when>
    <thetext>Has this test ever worked on windows?  wasn&apos;t it just added yesterday? </thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>121953</commentid>
    <comment_count>3</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-05-19 12:46:03 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Has this test ever worked on windows?  wasn&apos;t it just added yesterday? 

Not sure if it ever worked on Windows at some point...only tested via the buildbot.

The test was added only yesterday, but passes on Tiger and Leopard which indicates a bug in CFNetwork for Windows.

http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/cookies/simple-cookies-expired.html
http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/cookies/resources/simple-cookies-expired.js

I suppose the cookie might not be set if the total time to set the date and load the XMLHTTPRequest were more than 1 minute, but that seems unlikely (especially on Release builds).

http://build.webkit.org/results/Windows%20Release%20(Tests)/r43852%20(1012)/results.html
http://build.webkit.org/results/Windows%20Debug%20(Tests)/r43852%20(1128)/results.html
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>171857</commentid>
    <comment_count>4</comment_count>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2009-12-15 07:53:50 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #2)
&gt; &gt; Has this test ever worked on windows?  wasn&apos;t it just added yesterday? 
&gt; 
&gt; Not sure if it ever worked on Windows at some point...only tested via the
&gt; buildbot.

My apologies, I completely forgot to reply to this bug. I haven&apos;t set up a Windows machine so the patch was not tested on Windows: it was only tested on Mac Leopard and Linux Qt (maybe also Gtk but I am not sure).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>202666</commentid>
    <comment_count>5</comment_count>
      <attachid>51325</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2010-03-22 12:03:57 -0700</bug_when>
    <thetext>Created attachment 51325
Patch v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>202796</commentid>
    <comment_count>6</comment_count>
      <attachid>51325</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2010-03-22 15:31:42 -0700</bug_when>
    <thetext>Comment on attachment 51325
Patch v1

Letting the commit queue land this; it should fail if the test fails.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>202927</commentid>
    <comment_count>7</comment_count>
      <attachid>51325</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-03-22 22:51:23 -0700</bug_when>
    <thetext>Comment on attachment 51325
Patch v1

Clearing flags on attachment: 51325

Committed r56379: &lt;http://trac.webkit.org/changeset/56379&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>202928</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-03-22 22:51:28 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>202952</commentid>
    <comment_count>9</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2010-03-23 00:34:47 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; All reviewed patches have been landed.  Closing bug.

This test hasn&apos;t shown up as failing on build.webkit.org either.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>514118</commentid>
    <comment_count>10</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-12-02 14:05:06 -0800</bug_when>
    <thetext>http/tests/cookies/simple-cookies-expired.html is flaky.  Filing bug now.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>51325</attachid>
            <date>2010-03-22 12:03:57 -0700</date>
            <delta_ts>2010-03-22 22:51:23 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-25861-20100322120356.patch</filename>
            <type>text/plain</type>
            <size>1452</size>
            <attacher name="David Kilzer (:ddkilzer)">ddkilzer</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCAxYTUwMGRjLi4wNjVmMTdmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMt
MjIgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUg
aHR0cC90ZXN0cy9jb29raWVzL3NpbXBsZS1jb29raWVzLWV4cGlyZWQuaHRtbCBmcm9tIHNraXAg
bGlzdCBhZnRlciBDRk5ldHdvcmsgaXNzdWUgaXMgcmVzb2x2ZWQKKyAgICAgICAgPGh0dHA6Ly93
ZWJraXQub3JnL2IvMjU4NjE+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82OTAxMzIyPgorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v
d2luL1NraXBwZWQ6IFJlbW92ZWQ6CisgICAgICAgIC0gaHR0cC90ZXN0cy9jb29raWVzL3NpbXBs
ZS1jb29raWVzLWV4cGlyZWQuaHRtbAorCiAyMDEwLTAzLTIyICBOYXRlIENoYXBpbiAgPGphcGhl
dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgQ2hyb21pdW0gZXhwZWN0YXRp
b25zIHR3ZWFrLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQg
Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBlZAppbmRleCA0NjdlNGRkLi42NjY4ZTc4
IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBlZAorKysgYi9MYXlv
dXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBlZApAQCAtNjA0LDkgKzYwNCw2IEBAIGZhc3QvZW5j
b2RpbmcvcGVyY2VudC1lc2NhcGluZy5odG1sCiAjIEJ1ZyAyNTc5NDogZmFzdC9yZXBsYWNlZC90
YWJsZS1wZXJjZW50LWhlaWdodC10ZXh0LWNvbnRyb2xzIGZhaWxzIG9uIFdpbmRvd3MgPGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTc5ND4KIGZhc3QvcmVwbGFjZWQv
dGFibGUtcGVyY2VudC1oZWlnaHQtdGV4dC1jb250cm9scy5odG1sCiAKLSMgQnVnIDI1ODYxOiBM
YXlvdXRUZXN0cy9odHRwL3Rlc3RzL2Nvb2tpZXMvc2ltcGxlLWNvb2tpZXMtZXhwaXJlZC5odG1s
IGZhaWxzIG9uIFdpbmRvd3MgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yNTg2MT4KLWh0dHAvdGVzdHMvY29va2llcy9zaW1wbGUtY29va2llcy1leHBpcmVkLmh0bWwK
LQogIyBCdWcgMjY0ODE6IEltcGxlbWVudCBsYXlvdXRUZXN0Q29udHJvbGxlci5kaXNwYXRjaFBl
bmRpbmdMb2FkUmVxdWVzdHMgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yNjQ4MT4KIGh0dHAvdGVzdHMvbG9hZGluZy9kZWxldGVkLWhvc3QtaW4tcmVzb3VyY2UtbG9h
ZC1kZWxlZ2F0ZS1jYWxsYmFjay5odG1sCiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>