258603 2023-06-27 22:40:19 -0700 Harmonize the hosts/domain name testing in Quirks 2024-01-16 23:53:52 -0800 1 1 1 Unclassified WebKit New Bugs Safari 17 Unspecified Unspecified NEW InRadar P2 Normal --- 267623 260938 1 karlcow webkit-unassigned webkit-bug-importer oldest_to_newest 1963945 0 karlcow 2023-06-27 22:40:19 -0700 Currently the Quirks.cpp file has a couple of different ways of testing for the domain name of a site where the Quirk should apply. https://github.com/WebKit/WebKit/blame/main/Source/WebCore/page/Quirks.cpp This is probably due to layer of history. It would probably be better to choose a "better"/more recent way of doing things. top domain equality equalLettersIgnoringASCIICase(host, domain) host == domain partial_domain end host.endsWithIgnoringASCIICase(partial_domain) host.endsWith(partial_domain) partial_domain start startsWithLettersIgnoringASCIICase(host, domain) host.toString()).startsWith(partial_domain) There is also topPrivatelyControlledDomain(host.toString()).startsWith("expedia."_s)) The recommended way is probably to use class WebCore::RegistrableDomain and its methods see https://github.com/WebKit/WebKit/blob/main/Source/WebCore/platform/RegistrableDomain.h https://github.com/WebKit/WebKit/blob/main/Tools/TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp 1963946 1 webkit-bug-importer 2023-06-27 22:40:31 -0700 <rdar://problem/111433802> 1990441 2 karlcow 2023-11-06 21:41:41 -0800 How do we improve this a bit more. In Bug 260938 isDomain() was created but probably, there is a need for more generic functions.