25860 2009-05-18 18:41:11 -0700 Chromium Linux font fallback should try more fonts 2009-05-21 17:17:02 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 evan webkit-unassigned agl eric hyatt oldest_to_newest 121845 0 evan 2009-05-18 18:41:11 -0700 Our getLastResortFallbackFont is a stub. We should fall back on the generic names "Sans", "Serif", etc. if our other fallbacks have failed. (Note that we intentionally *don't* map CSS names like "sans-serif" via the settings because we want those to remain Arial for compatibility.) See also http://code.google.com/p/chromium/issues/detail?id=10665 121846 1 30456 evan 2009-05-18 18:47:45 -0700 Created attachment 30456 fix WebCore/ChangeLog | 11 +++++++++ .../platform/graphics/chromium/FontCacheLinux.cpp | 24 ++++++++++++++++++- 2 files changed, 33 insertions(+), 2 deletions(-) 121847 2 evan 2009-05-18 18:48:29 -0700 Adding some reviewers for comments. 121848 3 eric 2009-05-18 19:07:30 -0700 I have no way of knowing if this font fallback behavior is "correct" or not. Hyatt might know. This looks different from the Mac code, but maybe is correct for Chromium? Seems a little silly to fallback to Sans twice. 121849 4 evan 2009-05-18 19:11:48 -0700 Yes, in the Mac code it uses this strictly for last resort fallback. However this behavior more closely matches FontCacheChromiumWin. I also don't know which is more correct. Note that I *believe* that keeping "sans-serif" in CSS matching "Arial" in font lookup is desirable. 121850 5 evan 2009-05-18 19:13:17 -0700 Oh, and the double-fallback is a bit silly, but the alternatives are all more code. And a system that doesn't have "Serif" or "Monospace" set up is pretty seriously broken. One idea is just to remove that last try, because if you don't have those fonts you're unlikely to have Sans anyway. I'd still want to add a "default:" on the switch then. 122458 6 30456 eric 2009-05-21 16:49:56 -0700 Comment on attachment 30456 fix Hyatt's AWOL, or at least not answering mail. This ain't gonna hurt anything and seems sane enough for Linux. 122459 7 30565 evan 2009-05-21 16:54:30 -0700 Created attachment 30565 fix WebCore/ChangeLog | 11 ++++++++++ .../platform/graphics/chromium/FontCacheLinux.cpp | 21 ++++++++++++++++++- 2 files changed, 30 insertions(+), 2 deletions(-) 122461 8 30566 evan 2009-05-21 16:59:08 -0700 Created attachment 30566 align with switch WebCore/ChangeLog | 11 ++++++++++ .../platform/graphics/chromium/FontCacheLinux.cpp | 21 ++++++++++++++++++- 2 files changed, 30 insertions(+), 2 deletions(-) 122471 9 30566 eric 2009-05-21 17:03:18 -0700 Comment on attachment 30566 align with switch Looks great. Dave could add an ASSERT(fontPlatformData); right before the return. In that case, where a user's system is totally hosed, we might as well crash early instead of late. 122475 10 levin 2009-05-21 17:17:02 -0700 http://trac.webkit.org/changeset/44015 30456 2009-05-18 18:47:45 -0700 2009-05-21 16:54:58 -0700 fix fix.patch text/plain 2231 evan MThmNDlhN2ZiNWRhMmM0YjVlOTg4MzZmZGZlMzg4Mzk2YzdkN2M4ZApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0ZmYxMGVjLi41ZjAwMmEw IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDA5LTA1LTE4ICBFdmFuIE1hcnRpbiAgPGV2YW5AY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZs ZXNoIG91dCBmb250IGZhbGxiYWNrIGZvciBDaHJvbWl1bSdzIFNraWEgcG9ydC4KKyAgICAgICAg Z2V0TGFzdFJlc29ydEZhbGxiYWNrRm9udCBzaG91bGQgZmFsbCBiYWNrIG9uIHdlbGwta25vd24g Zm9udHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y NTg2MAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlTGlu dXguY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpnZXRMYXN0UmVzb3J0RmFsbGJh Y2tGb250KTogdHJ5IGtub3duIGZvbnQgbmFtZXMuCisKIDIwMDktMDUtMTggIERhdmlkIExldmlu ICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hl ci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENh Y2hlTGludXguY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2Fj aGVMaW51eC5jcHAKaW5kZXggYzRlYjk0Ny4uMGVmNTczYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2FjaGVMaW51eC5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2FjaGVMaW51eC5jcHAKQEAgLTk3LDgg Kzk3LDI4IEBAIEZvbnRQbGF0Zm9ybURhdGEqIEZvbnRDYWNoZTo6Z2V0U2ltaWxhckZvbnRQbGF0 Zm9ybURhdGEoY29uc3QgRm9udCYgZm9udCkKIAogRm9udFBsYXRmb3JtRGF0YSogRm9udENhY2hl OjpnZXRMYXN0UmVzb3J0RmFsbGJhY2tGb250KGNvbnN0IEZvbnREZXNjcmlwdGlvbiYgZGVzY3Jp cHRpb24pCiB7Ci0gICAgc3RhdGljIEF0b21pY1N0cmluZyBhcmlhbFN0cigiQXJpYWwiKTsKLSAg ICByZXR1cm4gZ2V0Q2FjaGVkRm9udFBsYXRmb3JtRGF0YShkZXNjcmlwdGlvbiwgYXJpYWxTdHIp OworICAgIHN0YXRpYyBjb25zdCBBdG9taWNTdHJpbmcgc2Fuc1N0cigiU2FucyIpOworICAgIHN0 YXRpYyBjb25zdCBBdG9taWNTdHJpbmcgc2VyaWZTdHIoIlNlcmlmIik7CisgICAgc3RhdGljIGNv bnN0IEF0b21pY1N0cmluZyBtb25vc3BhY2VTdHIoIk1vbm9zcGFjZSIpOworCisgICAgRm9udFBs YXRmb3JtRGF0YSogZm9udFBsYXRmb3JtRGF0YSA9IE5VTEw7CisgICAgc3dpdGNoIChkZXNjcmlw dGlvbi5nZW5lcmljRmFtaWx5KCkpIHsKKyAgICAgICAgY2FzZSBGb250RGVzY3JpcHRpb246OlNl cmlmRmFtaWx5OgorICAgICAgICAgICAgZm9udFBsYXRmb3JtRGF0YSA9IGdldENhY2hlZEZvbnRQ bGF0Zm9ybURhdGEoZGVzY3JpcHRpb24sIHNlcmlmU3RyKTsKKyAgICAgICAgICAgIGJyZWFrOwor ICAgICAgICBjYXNlIEZvbnREZXNjcmlwdGlvbjo6TW9ub3NwYWNlRmFtaWx5OgorICAgICAgICAg ICAgZm9udFBsYXRmb3JtRGF0YSA9IGdldENhY2hlZEZvbnRQbGF0Zm9ybURhdGEoZGVzY3JpcHRp b24sIG1vbm9zcGFjZVN0cik7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBGb250 RGVzY3JpcHRpb246OlNhbnNTZXJpZkZhbWlseToKKyAgICAgICAgICAgIGZvbnRQbGF0Zm9ybURh dGEgPSBnZXRDYWNoZWRGb250UGxhdGZvcm1EYXRhKGRlc2NyaXB0aW9uLCBzYW5zU3RyKTsKKyAg ICAgICAgICAgIGJyZWFrOworICAgIH0KKworICAgIC8vIEZpbmFsbHkgZmFsbCBiYWNrIG9uIFNh bnMgaWYgbm90aGluZyBlbHNlIHdvcmtlZC4KKyAgICBpZiAoIWZvbnRQbGF0Zm9ybURhdGEpCisg ICAgICAgIGZvbnRQbGF0Zm9ybURhdGEgPSBnZXRDYWNoZWRGb250UGxhdGZvcm1EYXRhKGRlc2Ny aXB0aW9uLCBzYW5zU3RyKTsKKworICAgIHJldHVybiBmb250UGxhdGZvcm1EYXRhOwogfQogCiB2 b2lkIEZvbnRDYWNoZTo6Z2V0VHJhaXRzSW5GYW1pbHkoY29uc3QgQXRvbWljU3RyaW5nJiBmYW1p bHlOYW1lLAo= 30565 2009-05-21 16:54:30 -0700 2009-05-21 16:59:28 -0700 fix fix.patch text/plain 2083 evan MTc3NjJlNmY3NGY0YWZmOGRhYjYzOTk2M2VlNjU2Mzg1NjgyNDJmYQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjOWMwZWRkLi42NzI4NmFm IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDA5LTA1LTE4ICBFdmFuIE1hcnRpbiAgPGV2YW5AY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZs ZXNoIG91dCBmb250IGZhbGxiYWNrIGZvciBDaHJvbWl1bSdzIFNraWEgcG9ydC4KKyAgICAgICAg Z2V0TGFzdFJlc29ydEZhbGxiYWNrRm9udCBzaG91bGQgZmFsbCBiYWNrIG9uIHdlbGwta25vd24g Zm9udHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y NTg2MAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlTGlu dXguY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpnZXRMYXN0UmVzb3J0RmFsbGJh Y2tGb250KTogdHJ5IGtub3duIGZvbnQgbmFtZXMuCisKIDIwMDktMDUtMjEgIERhbiBCZXJuc3Rl aW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKb2huIFN1bGxpdmFu LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2Fj aGVMaW51eC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNo ZUxpbnV4LmNwcAppbmRleCBjNGViOTQ3Li5iNTdkZWI0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNwcAorKysgYi9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNwcApAQCAtOTcsOCAr OTcsMjUgQEAgRm9udFBsYXRmb3JtRGF0YSogRm9udENhY2hlOjpnZXRTaW1pbGFyRm9udFBsYXRm b3JtRGF0YShjb25zdCBGb250JiBmb250KQogCiBGb250UGxhdGZvcm1EYXRhKiBGb250Q2FjaGU6 OmdldExhc3RSZXNvcnRGYWxsYmFja0ZvbnQoY29uc3QgRm9udERlc2NyaXB0aW9uJiBkZXNjcmlw dGlvbikKIHsKLSAgICBzdGF0aWMgQXRvbWljU3RyaW5nIGFyaWFsU3RyKCJBcmlhbCIpOwotICAg IHJldHVybiBnZXRDYWNoZWRGb250UGxhdGZvcm1EYXRhKGRlc2NyaXB0aW9uLCBhcmlhbFN0cik7 CisgICAgc3RhdGljIGNvbnN0IEF0b21pY1N0cmluZyBzYW5zU3RyKCJTYW5zIik7CisgICAgc3Rh dGljIGNvbnN0IEF0b21pY1N0cmluZyBzZXJpZlN0cigiU2VyaWYiKTsKKyAgICBzdGF0aWMgY29u c3QgQXRvbWljU3RyaW5nIG1vbm9zcGFjZVN0cigiTW9ub3NwYWNlIik7CisKKyAgICBGb250UGxh dGZvcm1EYXRhKiBmb250UGxhdGZvcm1EYXRhID0gTlVMTDsKKyAgICBzd2l0Y2ggKGRlc2NyaXB0 aW9uLmdlbmVyaWNGYW1pbHkoKSkgeworICAgICAgICBjYXNlIEZvbnREZXNjcmlwdGlvbjo6U2Vy aWZGYW1pbHk6CisgICAgICAgICAgICBmb250UGxhdGZvcm1EYXRhID0gZ2V0Q2FjaGVkRm9udFBs YXRmb3JtRGF0YShkZXNjcmlwdGlvbiwgc2VyaWZTdHIpOworICAgICAgICAgICAgYnJlYWs7Cisg ICAgICAgIGNhc2UgRm9udERlc2NyaXB0aW9uOjpNb25vc3BhY2VGYW1pbHk6CisgICAgICAgICAg ICBmb250UGxhdGZvcm1EYXRhID0gZ2V0Q2FjaGVkRm9udFBsYXRmb3JtRGF0YShkZXNjcmlwdGlv biwgbW9ub3NwYWNlU3RyKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIEZvbnRE ZXNjcmlwdGlvbjo6U2Fuc1NlcmlmRmFtaWx5OgorICAgICAgICBkZWZhdWx0OgorICAgICAgICAg ICAgZm9udFBsYXRmb3JtRGF0YSA9IGdldENhY2hlZEZvbnRQbGF0Zm9ybURhdGEoZGVzY3JpcHRp b24sIHNhbnNTdHIpOworICAgICAgICAgICAgYnJlYWs7CisgICAgfQorCisgICAgcmV0dXJuIGZv bnRQbGF0Zm9ybURhdGE7CiB9CiAKIHZvaWQgRm9udENhY2hlOjpnZXRUcmFpdHNJbkZhbWlseShj b25zdCBBdG9taWNTdHJpbmcmIGZhbWlseU5hbWUsCg== 30566 2009-05-21 16:59:08 -0700 2009-05-21 17:03:18 -0700 align with switch align-with-switch.patch text/plain 2043 evan MzA5M2E0NjkzYjI5NDliZjUyMzAwODc3Y2M1YmRlYzgxMGE3MWJhYgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjOWMwZWRkLi42NzI4NmFm IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDA5LTA1LTE4ICBFdmFuIE1hcnRpbiAgPGV2YW5AY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZs ZXNoIG91dCBmb250IGZhbGxiYWNrIGZvciBDaHJvbWl1bSdzIFNraWEgcG9ydC4KKyAgICAgICAg Z2V0TGFzdFJlc29ydEZhbGxiYWNrRm9udCBzaG91bGQgZmFsbCBiYWNrIG9uIHdlbGwta25vd24g Zm9udHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y NTg2MAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlTGlu dXguY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpnZXRMYXN0UmVzb3J0RmFsbGJh Y2tGb250KTogdHJ5IGtub3duIGZvbnQgbmFtZXMuCisKIDIwMDktMDUtMjEgIERhbiBCZXJuc3Rl aW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKb2huIFN1bGxpdmFu LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2Fj aGVMaW51eC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNo ZUxpbnV4LmNwcAppbmRleCBjNGViOTQ3Li5mM2Q3YjhhIDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNwcAorKysgYi9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNwcApAQCAtOTcsOCAr OTcsMjUgQEAgRm9udFBsYXRmb3JtRGF0YSogRm9udENhY2hlOjpnZXRTaW1pbGFyRm9udFBsYXRm b3JtRGF0YShjb25zdCBGb250JiBmb250KQogCiBGb250UGxhdGZvcm1EYXRhKiBGb250Q2FjaGU6 OmdldExhc3RSZXNvcnRGYWxsYmFja0ZvbnQoY29uc3QgRm9udERlc2NyaXB0aW9uJiBkZXNjcmlw dGlvbikKIHsKLSAgICBzdGF0aWMgQXRvbWljU3RyaW5nIGFyaWFsU3RyKCJBcmlhbCIpOwotICAg IHJldHVybiBnZXRDYWNoZWRGb250UGxhdGZvcm1EYXRhKGRlc2NyaXB0aW9uLCBhcmlhbFN0cik7 CisgICAgc3RhdGljIGNvbnN0IEF0b21pY1N0cmluZyBzYW5zU3RyKCJTYW5zIik7CisgICAgc3Rh dGljIGNvbnN0IEF0b21pY1N0cmluZyBzZXJpZlN0cigiU2VyaWYiKTsKKyAgICBzdGF0aWMgY29u c3QgQXRvbWljU3RyaW5nIG1vbm9zcGFjZVN0cigiTW9ub3NwYWNlIik7CisKKyAgICBGb250UGxh dGZvcm1EYXRhKiBmb250UGxhdGZvcm1EYXRhID0gTlVMTDsKKyAgICBzd2l0Y2ggKGRlc2NyaXB0 aW9uLmdlbmVyaWNGYW1pbHkoKSkgeworICAgIGNhc2UgRm9udERlc2NyaXB0aW9uOjpTZXJpZkZh bWlseToKKyAgICAgICAgZm9udFBsYXRmb3JtRGF0YSA9IGdldENhY2hlZEZvbnRQbGF0Zm9ybURh dGEoZGVzY3JpcHRpb24sIHNlcmlmU3RyKTsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBGb250 RGVzY3JpcHRpb246Ok1vbm9zcGFjZUZhbWlseToKKyAgICAgICAgZm9udFBsYXRmb3JtRGF0YSA9 IGdldENhY2hlZEZvbnRQbGF0Zm9ybURhdGEoZGVzY3JpcHRpb24sIG1vbm9zcGFjZVN0cik7Cisg ICAgICAgIGJyZWFrOworICAgIGNhc2UgRm9udERlc2NyaXB0aW9uOjpTYW5zU2VyaWZGYW1pbHk6 CisgICAgZGVmYXVsdDoKKyAgICAgICAgZm9udFBsYXRmb3JtRGF0YSA9IGdldENhY2hlZEZvbnRQ bGF0Zm9ybURhdGEoZGVzY3JpcHRpb24sIHNhbnNTdHIpOworICAgICAgICBicmVhazsKKyAgICB9 CisKKyAgICByZXR1cm4gZm9udFBsYXRmb3JtRGF0YTsKIH0KIAogdm9pZCBGb250Q2FjaGU6Omdl dFRyYWl0c0luRmFtaWx5KGNvbnN0IEF0b21pY1N0cmluZyYgZmFtaWx5TmFtZSwK