25855 2009-05-18 06:28:06 -0700 [GTK] Should support proper Content Encoding 2010-05-04 16:39:49 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk, Soup P2 Normal --- 1 gustavo webkit-unassigned baptiste.millemathias christian commit-queue danw eric225125 martin.sourada sa slomo tevaum uzytkownik2 webkit.review.bot zan oldest_to_newest 121790 0 gustavo 2009-05-18 06:28:06 -0700 Currently WebKitGTK+ is limited to using identity as content encoding. We are unable to take advantage of compression, for faster transfer rates, for instance. See https://bugs.webkit.org/show_bug.cgi?id=25854 and http://bugzilla.gnome.org/show_bug.cgi?id=522772 for more information. 124636 1 xan.lopez 2009-06-06 02:17:47 -0700 *** Bug 26233 has been marked as a duplicate of this bug. *** 130180 2 jmalonzo 2009-07-07 04:04:37 -0700 *** Bug 25481 has been marked as a duplicate of this bug. *** 146997 3 xan.lopez 2009-09-13 14:39:43 -0700 *** Bug 29221 has been marked as a duplicate of this bug. *** 152695 4 xan.lopez 2009-10-06 06:07:55 -0700 *** Bug 30066 has been marked as a duplicate of this bug. *** 154327 5 danw 2009-10-13 07:16:08 -0700 OK, since real Content-Encoding support is probably not coming until GNOME 2.30, and we're continuing to trip over sites that use "Content-Encoding: gzip" even though we send "Accept-Encoding: identity" (notably archive.org), maybe a gross hack is in order... what we'd do is, check from gotHeadersCallback if the response includes "Content-Encoding: gzip"; if so, disconnect from content-sniffed and got-chunk and connect to got-body. Wait until the got-body handler is called, unzip the body data all at once, call soup_content_sniffer_sniff() if necessary, and then belatedly emit all the webkit "signals". This would break incremental rendering of the data, but it would only be getting used on broken sites anyway. 156526 6 gustavo 2009-10-21 10:33:49 -0700 (In reply to comment #5) > OK, since real Content-Encoding support is probably not coming until GNOME > 2.30, and we're continuing to trip over sites that use "Content-Encoding: gzip" > even though we send "Accept-Encoding: identity" (notably archive.org), maybe a > gross hack is in order... what we'd do is, check from gotHeadersCallback if the > response includes "Content-Encoding: gzip"; if so, disconnect from > content-sniffed and got-chunk and connect to got-body. Wait until the got-body > handler is called, unzip the body data all at once, call > soup_content_sniffer_sniff() if necessary, and then belatedly emit all the > webkit "signals". This would break incremental rendering of the data, but it > would only be getting used on broken sites anyway. I have been thinking the same. Are you planning to write such a patch, or should I try to secure some time to get it done? 156547 7 danw 2009-10-21 11:04:57 -0700 i was not planning to write it myself 157147 8 danw 2009-10-23 05:17:54 -0700 ok, i'm working on avb's update of my original patches. see the linked b.g.o bug 161344 9 sa 2009-11-07 05:42:10 -0800 *** Bug 30934 has been marked as a duplicate of this bug. *** 162405 10 eric225125 2009-11-11 01:54:02 -0800 I just wanted to let you know in case you didn't see it in the gnome bug posted in the first message that support for proper content encoding should be released soon with libsoup-2.28.2. There is also a patch there that supposedly enables these features for webkit. 167222 11 gustavo 2009-11-30 06:20:46 -0800 *** Bug 31982 has been marked as a duplicate of this bug. *** 172272 12 44968 danw 2009-12-16 05:59:12 -0800 Created attachment 44968 patch to use SoupContentDecoder (note that while this claims to require libsoup >= 2.28.2, i haven't actually updated the gnome-2-28 branch yet, so you'll want to test against master. that will be fixed before this gets committed of course.) 172273 13 webkit.review.bot 2009-12-16 06:01:35 -0800 style-queue ran check-webkit-style on attachment 44968 without any errors. 172381 14 christian 2009-12-16 10:29:23 -0800 (In reply to comment #12) > Created an attachment (id=44968) [details] > patch to use SoupContentDecoder > > (note that while this claims to require libsoup >= 2.28.2, i haven't actually > updated the gnome-2-28 branch yet, so you'll want to test against master. that > will be fixed before this gets committed of course.) The patch needs an #ifdef SOUP_TYPE_CONTENT_DECODER because otherwise it fails with current releases. 172403 15 44968 gustavo 2009-12-16 10:52:54 -0800 Comment on attachment 44968 patch to use SoupContentDecoder Thanks! 172405 16 gustavo 2009-12-16 10:53:55 -0800 (In reply to comment #14) > The patch needs an #ifdef SOUP_TYPE_CONTENT_DECODER because otherwise it fails > with current releases. We decided to not handle this, and assume people mostly know what they're doing when using development releases. 2.29.4 will have it. 172421 17 44968 commit-queue 2009-12-16 11:14:44 -0800 Comment on attachment 44968 patch to use SoupContentDecoder Clearing flags on attachment: 44968 Committed r52208: <http://trac.webkit.org/changeset/52208> 172422 18 commit-queue 2009-12-16 11:14:51 -0800 All reviewed patches have been landed. Closing bug. 220869 19 mrobinson 2010-05-04 16:39:49 -0700 *** Bug 29768 has been marked as a duplicate of this bug. *** 44968 2009-12-16 05:59:12 -0800 2009-12-16 11:14:44 -0800 patch to use SoupContentDecoder content-decoder.diff text/plain 3541 danw ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5OGQ1ZGU0Li4zZjgzOWEz IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMDktMTItMTYgIERhbiBXaW5zaGlwICA8ZGFud0Bnbm9tZS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0d0a10gQ29udGVudC1FbmNvZGlu ZyBzdXBwb3J0CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUyMjc3MgorCisgICAgICAgICogY29uZmlndXJlLmFjOiByZXF1aXJlIGxpYnNvdXAgMi4y OC4yIGZvciBTb3VwQ29udGVudERlY29kZXIKKwogMjAwOS0xMi0xMyAgRXJpYyBTZWlkZWwgIDxl cmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2gu CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IDNiMzZjMTEuLjYyYjNhMzQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTItMTYgIERhbiBXaW5zaGlw ICA8ZGFud0Bnbm9tZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0d0a10gQ29udGVudC1FbmNvZGluZyBzdXBwb3J0CisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyMjc3MgorCisgICAgICAgICog cGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpzdGFydEh0dHApOiBEb24ndCBmb3JjZSAiQWNjZXB0LUVuY29kaW5nOiBpZGVudGl0 eSIgYW55CisgICAgICAgIG1vcmUKKwogMjAwOS0xMi0xNSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRs ZVNvdXAuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVT b3VwLmNwcAppbmRleCA2MzY3YTNlLi41YTIyOWI4IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKQEAgLTU0OCwxMiArNTQ4 LDYgQEAgc3RhdGljIGJvb2wgc3RhcnRIdHRwKFJlc291cmNlSGFuZGxlKiBoYW5kbGUpCiAgICAg Ly8gYmFsYW5jZWQgYnkgYSBkZXJlZigpIGluIGZpbmlzaGVkQ2FsbGJhY2ssIHdoaWNoIHNob3Vs ZCBhbHdheXMgcnVuCiAgICAgaGFuZGxlLT5yZWYoKTsKIAotICAgIC8vIEZJWE1FOiBGb3Igbm93 LCB3ZSBjYW5ub3QgYWNjZXB0IGNvbnRlbnQgZW5jb2RlZCBpbiBhbnl0aGluZwotICAgIC8vIG90 aGVyIHRoYW4gaWRlbnRpdHksIHNvIGZvcmNlIHNlcnZlcnMgdG8gZG8gaXQgb3VyIHdheS4gV2hl bgotICAgIC8vIGxpYnNvdXAgZ2V0cyBwcm9wZXIgQ29udGVudC1FbmNvZGluZyBzdXBwb3J0IHdl IHdpbGwgd2FudCB0bwotICAgIC8vIHVzZSBpdCBoZXJlIGluc3RlYWQuCi0gICAgc291cF9tZXNz YWdlX2hlYWRlcnNfcmVwbGFjZShkLT5tX21zZy0+cmVxdWVzdF9oZWFkZXJzLCAiQWNjZXB0LUVu Y29kaW5nIiwgImlkZW50aXR5Iik7Ci0KICAgICAvLyBCYWxhbmNlZCBpbiBSZXNvdXJjZUhhbmRs ZUludGVybmFsJ3MgZGVzdHJ1Y3Rvcjsgd2UgbmVlZCB0bwogICAgIC8vIGtlZXAgb3VyIG93biBy ZWYsIGJlY2F1c2UgYWZ0ZXIgcXVldWVpbmcgdGhlIG1lc3NhZ2UsIHRoZQogICAgIC8vIHNlc3Np b24gb3ducyB0aGUgaW5pdGlhbCByZWZlcmVuY2UuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0No YW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDBhMjY2NWMuLmYwOWY4MGMgMTAw NjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTItMTYgIERhbiBXaW5zaGlwICA8ZGFud0Bnbm9tZS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29u dGVudC1FbmNvZGluZyBzdXBwb3J0CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTUyMjc3MgorCisgICAgICAgICogd2Via2l0L3dlYmtpdHByaXZhdGUu Y3BwOgorICAgICAgICAod2Via2l0X2luaXQpOiBhZGQgYSBTb3VwQ29udGVudERlY29kZXIgZmVh dHVyZSB0byB0aGUgc2Vzc2lvbgorCiAyMDA5LTEyLTEzICBTYW0gV2VpbmlnICA8c2FtQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBh L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHByaXZhdGUuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0cHJpdmF0ZS5jcHAKaW5kZXggYzgwMTYwYy4uOTVhNTcxNyAxMDA2NDQKLS0tIGEvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0cHJpdmF0ZS5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0cHJpdmF0ZS5jcHAKQEAgLTI4MCw2ICsyODAsOCBAQCB2b2lkIHdlYmtpdF9pbml0KCkK ICAgICBTb3VwU2Vzc2lvbkZlYXR1cmUqIHNuaWZmZXIgPSBzdGF0aWNfY2FzdDxTb3VwU2Vzc2lv bkZlYXR1cmUqPihnX29iamVjdF9uZXcoU09VUF9UWVBFX0NPTlRFTlRfU05JRkZFUiwgTlVMTCkp OwogICAgIHNvdXBfc2Vzc2lvbl9hZGRfZmVhdHVyZShzZXNzaW9uLCBzbmlmZmVyKTsKICAgICBn X29iamVjdF91bnJlZihzbmlmZmVyKTsKKworICAgIHNvdXBfc2Vzc2lvbl9hZGRfZmVhdHVyZV9i eV90eXBlKHNlc3Npb24sIFNPVVBfVFlQRV9DT05URU5UX0RFQ09ERVIpOwogfQogCiB2b2lkIHdl YmtpdF93aGl0ZV9saXN0X2FjY2Vzc19mcm9tX29yaWdpbihjb25zdCBnY2hhciogc291cmNlT3Jp Z2luLCBjb25zdCBnY2hhciogZGVzdGluYXRpb25Qcm90b2NvbCwgY29uc3QgZ2NoYXIqIGRlc3Rp bmF0aW9uSG9zdCwgYm9vbCBhbGxvd0Rlc3RpbmF0aW9uU3ViZG9tYWlucykKZGlmZiAtLWdpdCBh L2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCBkMjg3N2MwLi43Mzk5Y2U2IDEwMDY0 NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC0xOTAsNyArMTkwLDcg QEAgaWYgdGVzdCAiJHdpdGhfaGlsZG9uIiA9ICJ5ZXMiOyB0aGVuCiBmaQogCiAjIG1pbmltdW0g YmFzZSBkZXBlbmRlbmNpZXMKLUxJQlNPVVBfUkVRVUlSRURfVkVSU0lPTj0yLjI3LjkxCitMSUJT T1VQX1JFUVVJUkVEX1ZFUlNJT049Mi4yOC4yCiBDQUlST19SRVFVSVJFRF9WRVJTSU9OPTEuNgog Rk9OVENPTkZJR19SRVFVSVJFRF9WRVJTSU9OPTIuNAogRlJFRVRZUEUyX1JFUVVJUkVEX1ZFUlNJ T049OS4wCg==