258509 2023-06-26 00:20:37 -0700 [Curl] Coding style issue in ResourceResponse.h 2023-06-26 20:41:35 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kenji.shukuwa webkit-unassigned fujii webkit-bug-importer oldest_to_newest 1963570 0 kenji.shukuwa 2023-06-26 00:20:37 -0700 ERROR: Source/WebCore/platform/network/curl/ResourceResponse.h:63: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] 1963571 1 kenji.shukuwa 2023-06-26 00:34:45 -0700 Removing WEBCORE_EXPORT from a class means adding WEBCORE_EXPORT to many functions. However, if you remove the functions that hide status code checks such as isMovedPermanently and write the status code directly in the code like other ports, they will be unnecessary. I would like to refer to the SOUP port and modify the code. 1963572 2 kenji.shukuwa 2023-06-26 00:37:29 -0700 Pull request: https://github.com/WebKit/WebKit/pull/15287 1963722 3 ews-feeder 2023-06-26 20:40:57 -0700 Committed 265537@main (593b1ac94072): <https://commits.webkit.org/265537@main> Reviewed commits have been landed. Closing PR #15287 and removing active labels. 1963724 4 webkit-bug-importer 2023-06-26 20:41:35 -0700 <rdar://problem/111368722>