258437 2023-06-22 22:28:55 -0700 Attachment: Move image display from legacy to modern implementation 2024-01-21 12:25:07 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 251830 258844 267838 1 g_squelart g_squelart jbedard webkit-bug-importer wenson_hsieh oldest_to_newest 1963225 0 g_squelart 2023-06-22 22:28:55 -0700 Replace the inner legacy attachment with a standard `<img>` element. <rdar://105252742> 1963226 1 g_squelart 2023-06-22 22:46:31 -0700 Pull request: https://github.com/WebKit/WebKit/pull/15228 1964221 2 ews-feeder 2023-06-29 04:05:23 -0700 Committed 265615@main (b0e7ef7b0420): <https://commits.webkit.org/265615@main> Reviewed commits have been landed. Closing PR #15228 and removing active labels. 1964311 3 g_squelart 2023-06-29 13:42:19 -0700 Re-opening for pull request https://github.com/WebKit/WebKit/pull/15421 1964319 4 ews-feeder 2023-06-29 13:51:10 -0700 Committed 265629@main (61d2643b6fe6): <https://commits.webkit.org/265629@main> Reviewed commits have been landed. Closing PR #15421 and removing active labels. 1966289 5 jbedard 2023-07-11 15:53:50 -0700 Looks like this flakily regressed fast/attachment/cocoa/wide-attachment-folder-icon.html 1966290 6 jbedard 2023-07-11 15:54:01 -0700 https://results.webkit.org/?suite=layout-tests&test=fast%2Fattachment%2Fcocoa%2Fwide-attachment-folder-icon.html 1966295 7 g_squelart 2023-07-11 16:16:12 -0700 Thank you Jonathan. I believe it may have made a few wide-attachment-* tests flaky, because of the way the icon is asynchronously fetched and then loaded into an img. I'm working on bug 258865, which should solve this.