25840 2009-05-17 09:55:09 -0700 fix some warnings seen on the GTK bot 2009-05-17 10:47:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 darin darin oldest_to_newest 121689 0 darin 2009-05-17 09:55:09 -0700 I see some warnings for things that ought to be fixed. 121690 1 30422 darin 2009-05-17 09:59:09 -0700 Created attachment 30422 patch 121693 2 darin 2009-05-17 10:47:53 -0700 http://trac.webkit.org/changeset/43811 30422 2009-05-17 09:59:09 -0700 2009-05-17 10:43:21 -0700 patch WarningsPatch.txt text/plain 3662 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzgxMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMDktMDUtMTcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAy NTg0MDogZml4IHNvbWUgd2FybmluZ3Mgc2VlbiBvbiB0aGUgR1RLIGJvdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU4NDAKKworICAgICAgICAqIHBs YXRmb3JtL1Njcm9sbFZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6cGxh dGZvcm1TY3JvbGxiYXJNb2Rlcyk6IEluaXRpYWxpemUgcmVzdWx0cyBoZXJlLgorICAgICAgICBU aGlzIGlzIHJlYWxseSBqdXN0IHRvIHF1aWV0IHdhcm5pbmdzLiBJIHRoaW5rIHRoaXMgY29kZSBp cyB1bnJlYWNoYWJsZS4KKyAgICAgICAgU29tZW9uZSBjb3VsZCBwdXQgQVNTRVJUX05PVF9SRUFD SEVEKCkgaW4gaGVyZSB0b28gYXQgc29tZSBwb2ludC4KKworICAgICAgICAqIHBsdWdpbnMvUGx1 Z2luU3RyZWFtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblN0cmVhbTo6c3RhcnRTdHJl YW0pOiBVc2UgcHJvcGVyIHByaW50ZiBmb3JtYXQgZm9yIGludAorICAgICAgICBoZXJlLCAlZCwg bm90ICVsdS4gVGhpcyBjb3VsZCBjYXVzZSBhIHJlYWwgcHJvYmxlbSB3aGVuIGNvbXBpbGVkIDY0 LWJpdCwKKyAgICAgICAgc28gaXQncyBnb29kIHRvIGZpeC4KKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJUZXh0Q29udHJvbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpnZXROZXh0U29mdEJy ZWFrKTogSW5pdGlhbGl6ZSBicmVha09mZnNldCB0byAwIGhlcmUuIFRoaXMgaXMKKyAgICAgICAg cmVhbGx5IGp1c3QgdG8gcXVpZXQgdGhlIHdhcm5pbmcsIGJ1dCBzdGlsbCBzZWVtcyBsaWtlIGEg Z29vZCBpZGVhLgorCiAyMDA5LTA1LTE3ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3Jl L3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0v U2Nyb2xsVmlldy5jcHAJKHJldmlzaW9uIDQzODA4KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9TY3Jv bGxWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODQ4LDYgKzg0OCw3IEBAIHZvaWQgU2Nyb2xs Vmlldzo6cmVtb3ZlUGFuU2Nyb2xsSWNvbigpCiB9CiAKICNpZiAhUExBVEZPUk0oV1gpICYmICFQ TEFURk9STShHVEspICYmICFQTEFURk9STShRVCkKKwogdm9pZCBTY3JvbGxWaWV3OjpwbGF0Zm9y bUluaXQoKQogewogfQpAQCAtODU1LDkgKzg1NiwxMSBAQCB2b2lkIFNjcm9sbFZpZXc6OnBsYXRm b3JtSW5pdCgpCiB2b2lkIFNjcm9sbFZpZXc6OnBsYXRmb3JtRGVzdHJveSgpCiB7CiB9CisKICNl bmRpZgogCiAjaWYgIVBMQVRGT1JNKFdYKSAmJiAhUExBVEZPUk0oR1RLKSAmJiAhUExBVEZPUk0o UVQpICYmICFQTEFURk9STShNQUMpCisKIHZvaWQgU2Nyb2xsVmlldzo6cGxhdGZvcm1BZGRDaGls ZChXaWRnZXQqKQogewogfQpAQCAtODY1LDIxICs4NjgsMjcgQEAgdm9pZCBTY3JvbGxWaWV3Ojpw bGF0Zm9ybUFkZENoaWxkKFdpZGdldAogdm9pZCBTY3JvbGxWaWV3OjpwbGF0Zm9ybVJlbW92ZUNo aWxkKFdpZGdldCopCiB7CiB9CisKICNlbmRpZgogCiAjaWYgIVBMQVRGT1JNKE1BQykKKwogdm9p ZCBTY3JvbGxWaWV3OjpwbGF0Zm9ybVNldFNjcm9sbGJhcnNTdXBwcmVzc2VkKGJvb2wgcmVwYWlu dE9uVW5zdXBwcmVzcykKIHsKIH0KKwogI2VuZGlmCiAKICNpZiAhUExBVEZPUk0oTUFDKSAmJiAh UExBVEZPUk0oV1gpCisKIHZvaWQgU2Nyb2xsVmlldzo6cGxhdGZvcm1TZXRTY3JvbGxiYXJNb2Rl cygpCiB7CiB9CiAKIHZvaWQgU2Nyb2xsVmlldzo6cGxhdGZvcm1TY3JvbGxiYXJNb2RlcyhTY3Jv bGxiYXJNb2RlJiBob3Jpem9udGFsLCBTY3JvbGxiYXJNb2RlJiB2ZXJ0aWNhbCkgY29uc3QKIHsK KyAgICBob3Jpem9udGFsID0gU2Nyb2xsYmFyQXV0bzsKKyAgICB2ZXJ0aWNhbCA9IFNjcm9sbGJh ckF1dG87CiB9CiAKIHZvaWQgU2Nyb2xsVmlldzo6cGxhdGZvcm1TZXRDYW5CbGl0T25TY3JvbGwo Ym9vbCkKQEAgLTkzMiw5ICs5NDEsMTEgQEAgYm9vbCBTY3JvbGxWaWV3OjpwbGF0Zm9ybUlzT2Zm c2NyZWVuKCkgYwogewogICAgIHJldHVybiBmYWxzZTsKIH0KKwogI2VuZGlmCiAKICNpZiAhUExB VEZPUk0oR1RLKQorCiBib29sIFNjcm9sbFZpZXc6OnBsYXRmb3JtSGFuZGxlSG9yaXpvbnRhbEFk anVzdG1lbnQoY29uc3QgSW50U2l6ZSYpCiB7CiAgICAgcmV0dXJuIGZhbHNlOwpAQCAtOTU4LDQg Kzk2OSwzIEBAIGJvb2wgU2Nyb2xsVmlldzo6cGxhdGZvcm1IYXNWZXJ0aWNhbEFkanUKICNlbmRp ZgogCiB9Ci0KSW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5TdHJlYW0uY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5TdHJlYW0uY3BwCShyZXZpc2lvbiA0MzgwOCkK KysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5TdHJlYW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NDMsNyArMTQzLDcgQEAgdm9pZCBQbHVnaW5TdHJlYW06OnN0YXJ0U3RyZWFtKCkKICAgICAgICAg VmVjdG9yPFVDaGFyPiBzdHJpbmdCdWlsZGVyOwogICAgICAgICBTdHJpbmcgc2VwYXJhdG9yKCI6 ICIpOwogCi0gICAgICAgIFN0cmluZyBzdGF0dXNMaW5lID0gU3RyaW5nOjpmb3JtYXQoIkhUVFAg JWx1IE9LXG4iLCBtX3Jlc291cmNlUmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKSk7CisgICAgICAg IFN0cmluZyBzdGF0dXNMaW5lID0gU3RyaW5nOjpmb3JtYXQoIkhUVFAgJWQgT0tcbiIsIG1fcmVz b3VyY2VSZXNwb25zZS5odHRwU3RhdHVzQ29kZSgpKTsKIAogICAgICAgICBzdHJpbmdCdWlsZGVy LmFwcGVuZChzdGF0dXNMaW5lLmNoYXJhY3RlcnMoKSwgc3RhdHVzTGluZS5sZW5ndGgoKSk7CiAK SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5jcHAJKHJldmlzaW9uIDQz ODA4KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0zNjMsNiArMzYzLDcgQEAgc3RhdGljIHZvaWQgZ2V0TmV4dFNvZnRCcmVhayhS b290SW5saW5lQgogICAgICAgICB9CiAgICAgfQogICAgIGJyZWFrTm9kZSA9IDA7CisgICAgYnJl YWtPZmZzZXQgPSAwOwogfQogCiBTdHJpbmcgUmVuZGVyVGV4dENvbnRyb2w6OnRleHRXaXRoSGFy ZExpbmVCcmVha3MoKQo=