258389 2023-06-21 22:27:47 -0700 [Curl] Replace handling of reason-phrase in ResourceResponseCurl 2023-06-23 01:28:37 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kenji.shukuwa webkit-unassigned fujii webkit-bug-importer oldest_to_newest 1962978 0 kenji.shukuwa 2023-06-21 22:27:47 -0700 In ResourceResponseCurl, the reason-phrase of the HTTP status line is obtained in the ResourceResponse::setStatusLine function, but in order to reduce the code to be maintained, replace it with extractReasonPhraseFromHTTPStatusLine of HTTPParsers. Additionally, the reason-phrase can contain ":". Therefore, there is a possibility that the reason-phrase cannot be obtained with the current processing. (for example: HTTP/1.1 999 ABC:DEF) https://github.com/WebKit/WebKit/blob/e45a46fae1a59709b4d5dd5c043352129364d150/Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp#L117-L129 --- auto splitPosition = header.find(':'); if (splitPosition != notFound) { ... } else if (startsWithLettersIgnoringASCIICase(header, "http"_s)) { // This is the first line of the response. setStatusLine(header); } --- 1962980 1 kenji.shukuwa 2023-06-21 22:34:53 -0700 Pull request: https://github.com/WebKit/WebKit/pull/15180 1962981 2 ews-feeder 2023-06-21 22:51:02 -0700 Committed 265395@main (007a3ea80d5c): <https://commits.webkit.org/265395@main> Reviewed commits have been landed. Closing PR #15180 and removing active labels. 1962982 3 webkit-bug-importer 2023-06-21 22:52:16 -0700 <rdar://problem/111142631> 1963121 4 fujii 2023-06-22 13:04:56 -0700 Some tests regresses. Could you take a look? Buildbot: builder WinCairo-64-bit-Release-Tests build 1327 (265396@main) https://build.webkit.org/#/builders/728/builds/1327 Regressions: Unexpected text-only failures (9) http/tests/inspector/network/resource-redirect-request-headers.html [ Failure ] http/tests/xmlhttprequest/extra-parameters.html [ Failure ] http/tests/xmlhttprequest/response-special-characters.html [ Failure ] http/tests/xmlhttprequest/status-after-abort.html [ Failure ] http/tests/xmlhttprequest/web-apps/012.html [ Failure ] http/tests/xmlhttprequest/web-apps/013.html [ Failure ] http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html [ Failure ] http/tests/xmlhttprequest/zero-length-response-sync.html [ Failure ] http/tests/xmlhttprequest/zero-length-response.html [ Failure ] 1963191 5 kenji.shukuwa 2023-06-22 18:58:39 -0700 (In reply to Fujii Hironori from comment #4) > Some tests regresses. Could you take a look? > Sure. 1963249 6 kenji.shukuwa 2023-06-23 01:28:37 -0700 https://bugs.webkit.org/show_bug.cgi?id=258442