25826 2009-05-15 12:40:17 -0700 REGRESSION: In Gmail's Edit Link dialog, I can't type in the Link To: field (due to <input type=url> support) 2022-08-12 10:53:53 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar, Regression P2 Normal --- 1 sam webkit-unassigned ahmad.saleem792 ap arv bfulgham ddkilzer dglazkov hppyromz jparent mal mrowe rniwa oldest_to_newest 121554 0 sam 2009-05-15 12:40:17 -0700 * SUMMARY In Gmail's Edit Link dialog, I can't type in the Link To: field to create a link in message. * STEPS TO REPRODUCE 1. Launch TOT and login into your gmail account 2. Click Compose Mail 3. In the message body, type hello and select this word 4. Click on Link icon. In the Gmail's Edit Link dialog that appears, the Link To : field has a focus ring but I can't type in it. This regressed due to http://trac.webkit.org/changeset/43267. 121555 1 sam 2009-05-15 12:40:28 -0700 <rdar://problem/6884742> 121557 2 30396 sam 2009-05-15 12:43:38 -0700 Created attachment 30396 patch 121559 3 ap 2009-05-15 12:57:50 -0700 What is special about <input type=url> at gmail that prevents typing? Will the problem occur on other sites using this input type? 121560 4 30396 bdakin 2009-05-15 13:02:09 -0700 Comment on attachment 30396 patch r=me 121564 5 sam 2009-05-15 13:07:24 -0700 (In reply to comment #3) > What is special about <input type=url> at gmail that prevents typing? Will the > problem occur on other sites using this input type? > They are expecting input.type for <input type=url> to return the string "text". It will only break other sites if they are expecting that as well, but there is no evidence of this. 121566 6 sam 2009-05-15 13:09:51 -0700 Fixed in r43779. 121580 7 ddkilzer 2009-05-15 14:19:35 -0700 Do international Google Mail sites use different domain names? 121581 8 ddkilzer 2009-05-15 14:19:47 -0700 <rdar://problem/6884742> 121586 9 arv 2009-05-15 14:57:27 -0700 This is really ugly work around and it will not work very well. Tons of other domains uses the same code. Gmail in UK and Germany uses another domain. Google Docs also uses this code and I believe Blogger and other high traffic sites as well. I'll try to get this fixed ASAP on our side. It makes no sense to have this work around in WebKit and it will cause more obscure bugs when Gmail wants input.type to return 'url' in the future. 121590 10 dglazkov 2009-05-15 15:05:52 -0700 Chromium build fix landed as http://trac.webkit.org/changeset/43784. 121601 11 arv 2009-05-15 16:51:31 -0700 We have now fixed the code in Gmail. It will take some time for this to go live since it isn't really a high priority bug on our side since the bug only affects beta versions of Chrome and Safari. Can you please roll back this hack now? 121602 12 eric 2009-05-15 17:15:02 -0700 I would agree that this patch won't fix Gmail very well. There are lots of domains which use this code, googlemail.com being the most obvious one (and as Arv mentions, other products too). I would recommend rolling this out before shipping Safari 4 or Chrome 2. Google should be responsible for fixing this from their side IMO. I'm going to re-open the bug, but feel free to close again, and I'm happy to file a separate bug about rollout. 121608 13 mrowe 2009-05-15 17:26:36 -0700 If we need to make the workaround more robust, we should do that. I don’t see how we can revert the workaround until Gmail is fixed. If Google folks are unhappy about the presence of the workaround then they should focus on getting the Gmail fix deployed. 121672 14 sam 2009-05-16 21:20:35 -0700 I would rather not roll out the fix entirely until the fix is deployed on googles end. We can however make it more robust, perhaps returning "text' for <input type="url"> regardless of origin in the js bindings (I don't want to infect ObjC binding with this quirk). If you are you able to provide a timeline for when the fix will be out it would be helpful, but I understand if this is not possible. For what it is worth, googlemail.com seems to re-direct to mail.google.com for me and I can not reproduce this bug on docs.google.com. 121674 15 eric 2009-05-16 22:36:46 -0700 I got more information from Julie Parent. I have "seen the light" and agree that a temporary workaround like this is a good thing. 1. The bug has existed in the shared JavaScript rich-text editing library Google uses (TrogEdit) since 2006. (Ironically WebKit hackers Ojan & Julie are primarily responsible for this library.) 2. Trivia: the faulty code was originally added for Opera, which was the only one which supported type="url" at that time. 3. Not all products use TrogEdit's link-insertion dialog. The Word processor @ docs.google.com is one example of an application with a custom link-insert dialog (hence why Sam couldn't repro there). 4. Julie wouldn't be able to list all the domains which use TrogEdit. I'm not sure anyone could easily. It's used by *lots* of apps @ google. Gmail is the highest-profile I know of. 5. The fix has been checked into TrogEdit. Some apps may have already released the fix. Some end-of-life apps will probably never do so (like pages.google.com). I don't have a timeline for Gmail, but Arv (Erik Arvidsson) might. I guess my personal opinion would be we should leave this on trunk until Safari 4 and Chrome 2 go out the door, and then roll it out again. The check could be expanded to ".google.com" but even that might not be complete. Making this quirk universal might be the best option. Julie might be able to give some advice here (by thinking of any other high-profile google domains using TrogEdit). 121682 16 eric 2009-05-17 05:43:01 -0700 Oh yeah. I believe anyone using Google Apps for your domain can run the app under any domain they want. So anyone who is using Gmail for your domain will be broken too. I don't know much about Google Apps for your domain usage, but I wouldn't be surprised if some rather large schools are using it. Someone who knows more about Google Apps for your domain should confirm this suspicion! (Really credit is due to Mike Lambert for bringing this up.) Result: we would need to enable this fix for all domains to fix Google Apps for Your Domain usage of Gmail (and possibly other Apps which depend on TrogEdit's insert link dialog). 121692 17 mrowe 2009-05-17 10:40:01 -0700 (In reply to comment #16) > Oh yeah. I believe anyone using Google Apps for your domain can run the app > under any domain they want. So anyone who is using Gmail for your domain will > be broken too. I don't know much about Google Apps for your domain usage, but > I wouldn't be surprised if some rather large schools are using it. > > Someone who knows more about Google Apps for your domain should confirm this > suspicion! (Really credit is due to Mike Lambert for bringing this up.) > > Result: we would need to enable this fix for all domains to fix Google Apps for > Your Domain usage of Gmail (and possibly other Apps which depend on TrogEdit's > insert link dialog). I use Google Apps for my domain and it too redirects to mail.google.com for Mail. Is there any real evidence that this affects anything but mail.google.com? So far there's been an awful lot of speculation and little evidence to demonstrate that the workaround is insufficient. 121719 18 eric 2009-05-17 17:12:57 -0700 I'm done speculating. Do what you want. I failed to reproduce this bug on docs.google.com (all 3 products), pages.google.com, and sites.google.com. 121721 19 sam 2009-05-17 18:00:14 -0700 :( Well, the best solution is (I think at least) to get the fix out the door ASAP on the Google side. For the time being, I am going to leave the fix in as it is (behind the site specific quirk flag so that Google engineers can turn it off via the Develop menu) and remove it as soon as the fix is released. Please re-open if you have a better solution that can address more people, more effectively. 121725 20 jparent 2009-05-17 19:23:45 -0700 Other external consumer products this bug is visible in: * Google Notebook (notebook.google.com) * Google Groups (groups.google.com, Pages feature) * Blogger (draft.blogger.com only) These should have it, but I haven't verified since I don't speak these languages and have no idea how to get to the link dialog ... * http://wenda.tianya.cn/wenda/ * http://otvety.google.ru/otvety/ There are likely a few other smaller products and Google internal products that will have this bug too. The fix on the Google side was to the base library and so it will get into these products when they do their next releases, but Google Notebook is a cancelled product and is unlikely to do another push to fix this bug. 121726 21 sam 2009-05-17 19:34:22 -0700 (In reply to comment #20) > Other external consumer products this bug is visible in: > * Google Notebook (notebook.google.com) > * Google Groups (groups.google.com, Pages feature) > * Blogger (draft.blogger.com only) > > These should have it, but I haven't verified since I don't speak these > languages and have no idea how to get to the link dialog ... > * http://wenda.tianya.cn/wenda/ > * http://otvety.google.ru/otvety/ > > There are likely a few other smaller products and Google internal products that > will have this bug too. > > The fix on the Google side was to the base library and so it will get into > these products when they do their next releases, but Google Notebook is a > cancelled product and is unlikely to do another push to fix this bug. Ok, cool. With this information, I think we should extend the quirk to all urls until the fix is rolled out. I will handle that. 121730 22 jparent 2009-05-17 19:57:58 -0700 I've contacted all of the teams using this link dialog and informed them of the situation. I'll update this bug once I have confirmed from them when they'll be rolling out fixes. 121744 23 eric 2009-05-17 23:24:49 -0700 More data in case it's useful: Me: "Are [Google Apps for Your Domain] Apps (like gmail) ever run under domains other than Google.com?" Derek [Tech Lead for GA4YD]: "Yes, they are. Some of our ISP partners for instance have urls like mail.isp.com, calendar.isp.com" I don't know what those ISP partners are, or how large they are. I can ask Derek for that information if needed. 121843 24 jparent 2009-05-18 18:07:36 -0700 Google Groups should have a fix live on June 3. Blogger should have a fix live on May 27. Gmail should have a fix live next week. 121904 25 jparent 2009-05-19 07:24:40 -0700 And Notebook will have the fix live by the end of this week. So, all Google properties that are known to have this bug will have fixes pushed by June 3 at the latest. 122124 26 30396 eric 2009-05-20 04:40:59 -0700 Comment on attachment 30396 patch clearing flag to remove from commit queue. 1890937 28 ahmad.saleem792 2022-08-12 10:53:46 -0700 I see these two patches landing: https://github.com/WebKit/WebKit/commit/1c64d7c219ada2d4f77c5504c24f6e9e6b6631d4 https://github.com/WebKit/WebKit/commit/114cfe9768dc31ab0a4b26c245dd5e9db5ccbefb But not backing out. Consider this bug as fixed at the time. I am going to mark this as "RESOLVED FIXED" and I am sure the code has since evolved a lot to modify the same code block several times and even fixing the issue at root level. Please reopen, if you believe there is more to do here. Thanks! 30396 2009-05-15 12:43:38 -0700 2010-06-10 17:14:56 -0700 patch patch.diff text/plain 3276 sam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQzNzc3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDUt MTUgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNTgyNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjg4NDc0Mj4g CisgICAgICAgIFJFR1JFU1NJT046IEluIEdtYWlsJ3MgRWRpdCBMaW5rIGRpYWxvZywgSSBjYW4n dCB0eXBlIGluIHRoZSBMaW5rIFRvOiBmaWVsZCAoZHVlIHRvIDxpbnB1dCB0eXBlPXVybD4gc3Vw cG9ydCkKKworICAgICAgICBBZGRlZCBhIHNpdGUgc3BlY2lmaWMgcXVpcmsgZm9yIG1haWwuZ29v Z2xlLmNvbSB3aGljaCByZXR1cm5zICJ0ZXh0IiB3aGVuIGdldHRpbmcgdGhlIHR5cGUgb2YgYW4g PGlucHV0IHR5cGU9dXJsPgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNIVE1MSW5wdXRFbGVt ZW50Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om5lZWRzR21haWxRdWlyayk6CisgICAg ICAgIChXZWJDb3JlOjpKU0hUTUxJbnB1dEVsZW1lbnQ6OnR5cGUpOgorICAgICAgICAqIGh0bWwv SFRNTElucHV0RWxlbWVudC5pZGw6CisKIDIwMDktMDUtMTUgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dApJbmRl eDogYmluZGluZ3MvanMvSlNIVE1MSW5wdXRFbGVtZW50Q3VzdG9tLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBiaW5kaW5ncy9qcy9KU0hUTUxJbnB1dEVsZW1lbnRDdXN0b20uY3BwCShyZXZpc2lvbiA0Mzc3 MykKKysrIGJpbmRpbmdzL2pzL0pTSFRNTElucHV0RWxlbWVudEN1c3RvbS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTI2LDEyICsyNiw0NiBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUg IkpTSFRNTElucHV0RWxlbWVudC5oIgogCisjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNsdWRl ICJIVE1MSW5wdXRFbGVtZW50LmgiCisjaW5jbHVkZSAiU2V0dGluZ3MuaCIKIAogdXNpbmcgbmFt ZXNwYWNlIEpTQzsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitzdGF0aWMgYm9vbCBuZWVkc0dt YWlsUXVpcmsoSFRNTElucHV0RWxlbWVudCogaW5wdXQpCit7CisgICAgRG9jdW1lbnQqIGRvY3Vt ZW50ID0gaW5wdXQtPmRvY3VtZW50KCk7CisKKyAgICBjb25zdCBLVVJMJiB1cmwgPSBkb2N1bWVu dC0+dXJsKCk7CisgICAgaWYgKHVybC5ob3N0KCkgIT0gIm1haWwuZ29vZ2xlLmNvbSIpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKworICAgIC8vIEFzIHdpdGggb3RoZXIgc2l0ZS1zcGVjaWZpYyBx dWlya3MsIGFsbG93IHdlYnNpdGUgZGV2ZWxvcGVycyB0byB0dXJuIHRoaXMgb2ZmLgorICAgIC8v IEluIHRoZW9yeSwgdGhpcyBhbGxvd3Mgd2Vic2l0ZSBkZXZlbG9wZXJzIHRvIGNoZWNrIGlmIHRo ZWlyIGZpeGVzIGFyZSBlZmZlY3RpdmUuCisgICAgU2V0dGluZ3MqIHNldHRpbmdzID0gZG9jdW1l bnQtPnNldHRpbmdzKCk7CisgICAgaWYgKCFzZXR0aW5ncykKKyAgICAgICAgcmV0dXJuIGZhbHNl OworICAgIGlmICghc2V0dGluZ3MtPm5lZWRzU2l0ZVNwZWNpZmljUXVpcmtzKCkpCisgICAgICAg IHJldHVybiBmYWxzZTsKKworICAgIHJldHVybiB0cnVlOworfQorCitKU1ZhbHVlIEpTSFRNTElu cHV0RWxlbWVudDo6dHlwZShFeGVjU3RhdGUqIGV4ZWMpIGNvbnN0Cit7CisgICAgSFRNTElucHV0 RWxlbWVudCogaW5wdXQgPSBzdGF0aWNfY2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4oaW1wbCgpKTsK KyAgICBjb25zdCBBdG9taWNTdHJpbmcmIHR5cGUgPSBpbnB1dC0+dHlwZSgpOworCisgICAgREVG SU5FX1NUQVRJQ19MT0NBTChjb25zdCBBdG9taWNTdHJpbmcsIHVybCwgKCJ1cmwiKSk7CisgICAg REVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBBdG9taWNTdHJpbmcsIHRleHQsICgidGV4dCIpKTsK KworICAgIGlmICh0eXBlID09IHVybCAmJiBuZWVkc0dtYWlsUXVpcmsoaW5wdXQpKQorICAgICAg ICByZXR1cm4ganNTdHJpbmcoZXhlYywgdGV4dCk7CisgICAgcmV0dXJuIGpzU3RyaW5nKGV4ZWMs IHR5cGUpOworfQorCiBKU1ZhbHVlIEpTSFRNTElucHV0RWxlbWVudDo6c2VsZWN0aW9uU3RhcnQo RXhlY1N0YXRlKiBleGVjKSBjb25zdAogewogICAgIEhUTUxJbnB1dEVsZW1lbnQqIGlucHV0ID0g c3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVudCo+KGltcGwoKSk7CkluZGV4OiBodG1sL0hUTUxJ bnB1dEVsZW1lbnQuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGh0bWwvSFRNTElucHV0RWxlbWVudC5pZGwJ KHJldmlzaW9uIDQzNzczKQorKysgaHRtbC9IVE1MSW5wdXRFbGVtZW50LmlkbAkod29ya2luZyBj b3B5KQpAQCAtNDcsNyArNDcsNyBAQCBtb2R1bGUgaHRtbCB7CiAgICAgICAgICAgICAgICAgIGF0 dHJpYnV0ZSB1bnNpZ25lZCBsb25nICAgc2l6ZTsgLy8gQ2hhbmdlZCBzdHJpbmcgLT4gbG9uZyBh cyBwYXJ0IG9mIERPTSBsZXZlbCAyCiAjZW5kaWYKICAgICAgICAgICAgICAgICAgYXR0cmlidXRl IFtDb252ZXJ0TnVsbFRvTnVsbFN0cmluZ10gRE9NU3RyaW5nIHNyYzsKLSAgICAgICAgICAgICAg ICAgYXR0cmlidXRlIFtDb252ZXJ0TnVsbFRvTnVsbFN0cmluZ10gRE9NU3RyaW5nIHR5cGU7IC8v IHJlYWRvbmx5IGRyb3BwZWQgYXMgcGFydCBvZiBET00gbGV2ZWwgMgorICAgICAgICAgICAgICAg ICBhdHRyaWJ1dGUgW0NvbnZlcnROdWxsVG9OdWxsU3RyaW5nLCBDdXN0b21HZXR0ZXJdIERPTVN0 cmluZyB0eXBlOyAvLyByZWFkb25seSBkcm9wcGVkIGFzIHBhcnQgb2YgRE9NIGxldmVsIDIKICAg ICAgICAgICAgICAgICAgYXR0cmlidXRlIFtDb252ZXJ0TnVsbFRvTnVsbFN0cmluZ10gRE9NU3Ry aW5nIHVzZU1hcDsKICAgICAgICAgICAgICAgICAgYXR0cmlidXRlIFtDb252ZXJ0TnVsbFRvTnVs bFN0cmluZ10gRE9NU3RyaW5nIHZhbHVlOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgYm9v bGVhbiAgICAgICAgIHdpbGxWYWxpZGF0ZTsK