25817 2009-05-15 01:39:21 -0700 svg/dom/SVGScriptElement/script-load-and-error-events.svg is flakey 2013-09-13 16:55:29 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned ap aroben jamesr zimmermann oldest_to_newest 121473 0 eric 2009-05-15 01:39:21 -0700 svg/dom/SVGScriptElement/script-load-and-error-events.svg is flakey We need to fix the test so it stops sometimes failing on the bots. We can also skip it if necessary. Example failure: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r43761%20(1061)/results.html 149611 1 eric 2009-09-23 18:19:06 -0700 *** Bug 29700 has been marked as a duplicate of this bug. *** 551925 2 zimmermann 2012-02-08 02:22:56 -0800 *** Bug 46998 has been marked as a duplicate of this bug. *** 551927 3 zimmermann 2012-02-08 02:23:34 -0800 *** Bug 76558 has been marked as a duplicate of this bug. *** 929035 4 211597 ap 2013-09-13 15:18:13 -0700 Created attachment 211597 improve failure output This test fails very often. I cannot reproduce locally, and cannot find anything wrong through code inspection. Let's see if this additional information helps. 929036 5 211597 thorton 2013-09-13 15:20:13 -0700 Comment on attachment 211597 improve failure output View in context: https://bugs.webkit.org/attachment.cgi?id=211597&action=review > LayoutTests/svg/dom/SVGScriptElement/script-load-and-error-events.svg:-112 > - scriptElement.href.baseVal = "resources/not-existant.js"; Are you going to move this file, too? 929038 6 211597 ap 2013-09-13 15:27:05 -0700 Comment on attachment 211597 improve failure output Committed <http://trac.webkit.org/r155727>, clearing review flag. 929058 7 ap 2013-09-13 16:41:01 -0700 OK, so it says "FAIL: The following tests failed: 6 (actual result: )". This means that we are not done running tests 1-5 when we start test 6. One of those gets into errorEventHandler, and since lastTest variable is set, we get into endTest(). 929060 8 ap 2013-09-13 16:43:31 -0700 Oh, but of course. Test 5 is expected to generate a load event first, and then an error event. We start test 6 as soon as we get the load event from test 5. 929063 9 211603 ap 2013-09-13 16:50:59 -0700 Created attachment 211603 proposed fix 929065 10 ap 2013-09-13 16:55:29 -0700 Committed <http://trac.webkit.org/r155733>. 211597 2013-09-13 15:18:13 -0700 2013-09-13 15:27:05 -0700 improve failure output SVGTestOutput.txt text/plain 4157 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1NTcyNikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA5LTEzICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEZsYWt5IFRlc3Q6IHN2Zy9kb20vU1ZHU2Ny aXB0RWxlbWVudC9zY3JpcHQtbG9hZC1hbmQtZXJyb3ItZXZlbnRzLnN2ZworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU4MTcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN2Zy9kb20vU1ZHU2NyaXB0RWxl bWVudC9zY3JpcHQtbG9hZC1hbmQtZXJyb3ItZXZlbnRzLnN2ZzogTWFkZSB0ZXN0IG91dHB1dAor ICAgICAgICBhIGJpdCBtb3JlIHZlcmJvc2UgdG8gc2VlIHdoYXQncyBoYXBwZW5pbmcgb24gYm90 cy4KKwogMjAxMy0wOS0xMyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAog ICAgICAgICBMYXlvdXQgVGVzdCBmYXN0L2RvbS9XaW5kb3cvd2luZG93LXBvc3RtZXNzYWdlLWNs b25lLmh0bWwgaXMgZmxha3kKSW5kZXg6IExheW91dFRlc3RzL3N2Zy9kb20vU1ZHU2NyaXB0RWxl bWVudC9zY3JpcHQtbG9hZC1hbmQtZXJyb3ItZXZlbnRzLnN2Zwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9zdmcvZG9tL1NWR1NjcmlwdEVsZW1lbnQvc2NyaXB0LWxvYWQtYW5kLWVycm9yLWV2 ZW50cy5zdmcJKHJldmlzaW9uIDE1NTYyMCkKKysrIExheW91dFRlc3RzL3N2Zy9kb20vU1ZHU2Ny aXB0RWxlbWVudC9zY3JpcHQtbG9hZC1hbmQtZXJyb3ItZXZlbnRzLnN2Zwkod29ya2luZyBjb3B5 KQpAQCAtMywxMSArMywxMiBAQAogPGRlZnM+CiA8dGl0bGU+Jmx0O1NDUklQVCZndDsgbG9hZCBh bmQgZXJyb3IgZXZlbnRzPC90aXRsZT4KIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4K Ky8vPCFbQ0RBVEFbCiB2YXIgc3RhdHVzXyA9IG5ldyBBcnJheSgpOwogdmFyIHNob3VsZENvbnRp bnVlID0gMTsKIHZhciBsYXN0VGVzdCA9IDA7CiAKLWZvciAoaSA9IDA7IGkgJmx0OyA3OyArK2kp Citmb3IgKGkgPSAwOyBpIDwgNzsgKytpKQogICAgIHN0YXR1c19baV0gPSAiIjsKIAogaWYgKHdp bmRvdy50ZXN0UnVubmVyKSB7CkBAIC0zOCwxOSArMzksMTkgQEAgZnVuY3Rpb24gZW5kVGVzdCgp IHsKICAgICB2YXIgZmFpbHVyZXMgPSAiIjsKIAogICAgIGlmIChzdGF0dXNfWzBdICE9ICJMRSIp Ci0gICAgICAgIGZhaWx1cmVzICs9ICIwICI7CisgICAgICAgIGZhaWx1cmVzICs9ICIwIChhY3R1 YWwgcmVzdWx0OiAiICsgc3RhdHVzX1swXSArICIpICI7CiAgICAgaWYgKHN0YXR1c19bMV0gIT0g IkUiKQotICAgICAgICBmYWlsdXJlcyArPSAiMSAiOworICAgICAgICBmYWlsdXJlcyArPSAiMSAo YWN0dWFsIHJlc3VsdDogIiArIHN0YXR1c19bMV0gKyAiKSAiOwogICAgIGlmIChzdGF0dXNfWzJd ICE9ICJMIikKLSAgICAgICAgZmFpbHVyZXMgKz0gIjIgIjsKKyAgICAgICAgZmFpbHVyZXMgKz0g IjIgKGFjdHVhbCByZXN1bHQ6ICIgKyBzdGF0dXNfWzJdICsgIikgIjsKICAgICBpZiAoc3RhdHVz X1szXSAhPSAiTCIpCi0gICAgICAgIGZhaWx1cmVzICs9ICIzICI7CisgICAgICAgIGZhaWx1cmVz ICs9ICIzIChhY3R1YWwgcmVzdWx0OiAiICsgc3RhdHVzX1szXSArICIpICI7CiAgICAgaWYgKHN0 YXR1c19bNF0gIT0gIkwiKQotICAgICAgICBmYWlsdXJlcyArPSAiNCAiOworICAgICAgICBmYWls dXJlcyArPSAiNCAoYWN0dWFsIHJlc3VsdDogIiArIHN0YXR1c19bNF0gKyAiKSAiOwogICAgIGlm IChzdGF0dXNfWzVdICE9ICJMRSIpCi0gICAgICAgIGZhaWx1cmVzICs9ICI1ICI7CisgICAgICAg IGZhaWx1cmVzICs9ICI1IChhY3R1YWwgcmVzdWx0OiAiICsgc3RhdHVzX1s1XSArICIpICI7CiAg ICAgaWYgKHN0YXR1c19bNl0gIT0gIkUiKQotICAgICAgICBmYWlsdXJlcyArPSAiNiAiOworICAg ICAgICBmYWlsdXJlcyArPSAiNiAoYWN0dWFsIHJlc3VsdDogIiArIHN0YXR1c19bNl0gKyAiKSI7 CiAKICAgICB2YXIgcmVzdWx0cyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHRzIik7 CiAgICAgaWYgKGZhaWx1cmVzKQpAQCAtNjMsNyArNjQsNyBAQCBmdW5jdGlvbiBlbmRUZXN0KCkg ewogfQogCiBmdW5jdGlvbiBsYXN0VGVzdEJlZm9yZVJvb3RFbGVtZW50TG9hZGVkKCkgewotICAg IC8vIEFzc3VyZSB0aGUgU1ZHU1ZHRWxlbWVudCBvbmxvYWQgaGFuZGxlciBkb2Vzbid0IGZpcmUs IGJlY2F1c2Ugb25lIHNjcmlwdCBlbGVtZW50IHBvaW50cyB0byBhIG5vdC1leGlzdGFudAorICAg IC8vIEVuc3VyZSB0aGUgU1ZHU1ZHRWxlbWVudCBvbmxvYWQgaGFuZGxlciBkb2Vzbid0IGZpcmUs IGJlY2F1c2Ugb25lIHNjcmlwdCBlbGVtZW50IHBvaW50cyB0byBhIG5vdC1leGlzdGVudAogICAg IC8vIHJlc291cmNlLCBhbmQgc3BlY2lmaWVzIGV4dGVybmFsUmVzb3VyY2VzUmVxdWlyZWQ9dHJ1 ZS4gVGhpcyBwcmV2ZW50cyBTVkdMb2FkIGZyb20gYmVpbmcgZGlzcGF0Y2hlZC4KICAgICB3aW5k b3cuc2V0VGltZW91dCgnc3RhcnREeW5hbWljVGVzdHMoKScsIDApOwogfQpAQCAtOTQsNyArOTUs NyBAQCBmdW5jdGlvbiBjb250aW51ZUR5bmFtaWNUZXN0MSgpIHsKICAgICB2YXIgc2NyaXB0RWxl bWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnROUygiaHR0cDovL3d3dy53My5vcmcvMjAwMC9z dmciLCAic3ZnOnNjcmlwdCIpOwogICAgIHNjcmlwdEVsZW1lbnQuaWQgPSA1OwogICAgIHNjcmlw dEVsZW1lbnQudHlwZS5iYXNlVmFsID0gInRleHQvamF2YXNjcmlwdCI7Ci0gICAgc2NyaXB0RWxl bWVudC5ocmVmLmJhc2VWYWwgPSAicmVzb3VyY2VzL25vdC1leGlzdGFudC5qcyI7CisgICAgc2Ny aXB0RWxlbWVudC5ocmVmLmJhc2VWYWwgPSAicmVzb3VyY2VzL25vdC1leGlzdGVudC5qcyI7CiAK ICAgICBzY3JpcHRFbGVtZW50Lm9ubG9hZCA9IGZ1bmN0aW9uKGxvYWRFdmVudCkgewogICAgICAg ICBsb2FkRXZlbnRIYW5kbGVyKGxvYWRFdmVudCk7CkBAIC0xMDksMTMgKzExMCwxNCBAQCBmdW5j dGlvbiBjb250aW51ZUR5bmFtaWNUZXN0MigpIHsKICAgICB2YXIgc2NyaXB0RWxlbWVudCA9IGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnROUygiaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLCAic3Zn OnNjcmlwdCIpOwogICAgIHNjcmlwdEVsZW1lbnQuaWQgPSA2OwogICAgIHNjcmlwdEVsZW1lbnQu dHlwZS5iYXNlVmFsID0gInRleHQvamF2YXNjcmlwdCI7Ci0gICAgc2NyaXB0RWxlbWVudC5ocmVm LmJhc2VWYWwgPSAicmVzb3VyY2VzL25vdC1leGlzdGFudC5qcyI7CisgICAgc2NyaXB0RWxlbWVu dC5ocmVmLmJhc2VWYWwgPSAicmVzb3VyY2VzL25vdC1leGlzdGVudC5qcyI7CiAgICAgc2NyaXB0 RWxlbWVudC5leHRlcm5hbFJlc291cmNlc1JlcXVpcmVkLmJhc2VWYWwgPSB0cnVlOwogICAgIHNj cmlwdEVsZW1lbnQub25lcnJvciA9IGVycm9yRXZlbnRIYW5kbGVyOwogCiAgICAgbGFzdFRlc3Qg PSAxOwogICAgIGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJkZWZzIilbMF0uYXBwZW5k Q2hpbGQoc2NyaXB0RWxlbWVudCk7ICAKIH0KKy8vXV0+CiA8L3NjcmlwdD4KIDxzY3JpcHQgaWQ9 IjAiIHR5cGU9InRleHQvamF2YXNjcmlwdCIgb25lcnJvcj0iZXJyb3JFdmVudEhhbmRsZXIoZXZ0 KSIgb25sb2FkPSJsb2FkRXZlbnRIYW5kbGVyKGV2dCkiIHhsaW5rOmhyZWY9InJlc291cmNlcy9j ZXJ0YWlubHlkb2Vzbm90ZXhpc3QuanMiPjwvc2NyaXB0PgogPHNjcmlwdCBpZD0iMSIgdHlwZT0i dGV4dC9qYXZhc2NyaXB0IiBvbmVycm9yPSJlcnJvckV2ZW50SGFuZGxlcihldnQpIiBleHRlcm5h bFJlc291cmNlc1JlcXVpcmVkPSJ0cnVlIiBvbmxvYWQ9ImxvYWRFdmVudEhhbmRsZXIoZXZ0KSIg eGxpbms6aHJlZj0icmVzb3VyY2VzL2NlcnRhaW5seWRvZXNub3RleGlzdHRvby5qcyIvPgo= 211603 2013-09-13 16:50:59 -0700 2013-09-13 16:53:37 -0700 proposed fix SVGErrors.txt text/plain 1609 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1NTczMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA5LTEzICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIHN2Zy9kb20vU1ZHU2NyaXB0RWxlbWVudC9z Y3JpcHQtbG9hZC1hbmQtZXJyb3ItZXZlbnRzLnN2ZyBpcyBmbGFrZXkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1ODE3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdmcvZG9tL1NWR1NjcmlwdEVsZW1l bnQvc2NyaXB0LWxvYWQtYW5kLWVycm9yLWV2ZW50cy5zdmc6IExldCB0ZXN0IDUgZmluaXNoCisg ICAgICAgIGJlZm9yZSBzdGFydGluZyB0ZXN0IDYuCisKIDIwMTMtMDktMTMgIEFsZXhleSBQcm9z a3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgaHR0cC90ZXN0cy9taXNjL3N1Ym1p dC1wb3N0LWtleWdlbi5odG1sIGlzIGV4dHJlbWVseSBzbG93IG9uIGJvdHMsIG9mdGVuIHRpbWlu ZyBvdXQKSW5kZXg6IExheW91dFRlc3RzL3N2Zy9kb20vU1ZHU2NyaXB0RWxlbWVudC9zY3JpcHQt bG9hZC1hbmQtZXJyb3ItZXZlbnRzLnN2Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdmcv ZG9tL1NWR1NjcmlwdEVsZW1lbnQvc2NyaXB0LWxvYWQtYW5kLWVycm9yLWV2ZW50cy5zdmcJKHJl dmlzaW9uIDE1NTcyNykKKysrIExheW91dFRlc3RzL3N2Zy9kb20vU1ZHU2NyaXB0RWxlbWVudC9z Y3JpcHQtbG9hZC1hbmQtZXJyb3ItZXZlbnRzLnN2Zwkod29ya2luZyBjb3B5KQpAQCAtOTcsMTEg Kzk3LDEyIEBAIGZ1bmN0aW9uIGNvbnRpbnVlRHluYW1pY1Rlc3QxKCkgewogICAgIHNjcmlwdEVs ZW1lbnQudHlwZS5iYXNlVmFsID0gInRleHQvamF2YXNjcmlwdCI7CiAgICAgc2NyaXB0RWxlbWVu dC5ocmVmLmJhc2VWYWwgPSAicmVzb3VyY2VzL25vbmV4aXN0ZW50LmpzIjsKIAotICAgIHNjcmlw dEVsZW1lbnQub25sb2FkID0gZnVuY3Rpb24obG9hZEV2ZW50KSB7Ci0gICAgICAgIGxvYWRFdmVu dEhhbmRsZXIobG9hZEV2ZW50KTsKKyAgICBzY3JpcHRFbGVtZW50Lm9ubG9hZCA9IGxvYWRFdmVu dEhhbmRsZXI7CisKKyAgICBzY3JpcHRFbGVtZW50Lm9uZXJyb3IgPSBmdW5jdGlvbihlcnJvckV2 ZW50KSB7CisgICAgICAgIGVycm9yRXZlbnRIYW5kbGVyKGVycm9yRXZlbnQpOwogICAgICAgICB3 aW5kb3cuc2V0VGltZW91dCgnY29udGludWVEeW5hbWljVGVzdDIoKScsIDApOwogICAgIH07Ci0g ICAgc2NyaXB0RWxlbWVudC5vbmVycm9yID0gZXJyb3JFdmVudEhhbmRsZXI7CiAKICAgICBkb2N1 bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgiZGVmcyIpWzBdLmFwcGVuZENoaWxkKHNjcmlwdEVs ZW1lbnQpOyAgCiB9Cg==