<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>258167</bug_id>
          
          <creation_ts>2023-06-15 15:37:52 -0700</creation_ts>
          <short_desc>Check CachedResourceLoader&apos;s document WeakPtr in more places</short_desc>
          <delta_ts>2023-06-16 16:22:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1961919</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2023-06-15 15:37:52 -0700</bug_when>
    <thetext>The CachedResourceLoader class holds a WeakPtr to a Document, which may be nullptr at different moments in loading. We inconsistently check for nullptr, which telemetry shows is triggering some crashes.

This patch provides more rigorous checks for nullptr to avoid these crashes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1961920</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2023-06-15 15:38:01 -0700</bug_when>
    <thetext>&lt;rdar://106964279&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1961930</commentid>
    <comment_count>2</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2023-06-15 15:50:21 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/15025</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1962178</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-06-16 16:22:18 -0700</bug_when>
    <thetext>Committed 265259@main (9632def06c0f): &lt;https://commits.webkit.org/265259@main&gt;

Reviewed commits have been landed. Closing PR #15025 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>