25814 2009-05-14 17:17:34 -0700 m_spreadMethod accessed without initialization 2009-05-14 22:39:45 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) PC Windows XP RESOLVED FIXED LayoutTests/fast/canvas/canvas-radial-gradient-spreadMethod.html P2 Normal --- 0 kuchhal webkit-unassigned oldest_to_newest 121413 0 kuchhal 2009-05-14 17:17:34 -0700 m_spreadMethod is not getting initialized in one of the constructors. Will append the patch in a minute. 121414 1 30364 kuchhal 2009-05-14 17:19:47 -0700 Created attachment 30364 Patch 121417 2 30364 darin 2009-05-14 19:31:12 -0700 Comment on attachment 30364 Patch > + Initialize m_spreadMethod in the second constructor too. Not sure if > + a test case can be written, so no test case. > + https://bugs.webkit.org/show_bug.cgi?id=25814 The tabs in this ChangeLog will cause extra work for whoever commits the patch. 121427 3 30365 kuchhal 2009-05-14 21:03:37 -0700 Created attachment 30365 new patch without the tabs this time 121443 4 eric 2009-05-14 22:39:45 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/Gradient.cpp Committed r43755 Thanks for the patch! 30364 2009-05-14 17:19:47 -0700 2009-05-14 21:03:37 -0700 Patch patch.diff text/plain 1024 kuchhal ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Mzc1MTg3YS4uMTRmMGUxMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wNS0xNCAgUmFodWwgS3VjaGhh bCAgPGt1Y2hoYWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluaXRpYWxpemUgbV9zcHJlYWRNZXRob2QgaW4gdGhlIHNlY29u ZCBjb25zdHJ1Y3RvciB0b28uIE5vdCBzdXJlIGlmCisJYSB0ZXN0IGNhc2UgY2FuIGJlIHdyaXR0 ZW4sIHNvIG5vIHRlc3QgY2FzZS4KKwlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjU4MTQKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkdyYWRpZW50OjpHcmFkaWVudCk6CisKIDIwMDktMDUtMTMgIERh dmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVu dC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmNwcAppbmRleCAyNGU4 YmJmLi41MWM3MTYyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRp ZW50LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmNwcApAQCAt NTIsNiArNTIsNyBAQCBHcmFkaWVudDo6R3JhZGllbnQoY29uc3QgRmxvYXRQb2ludCYgcDAsIGZs b2F0IHIwLCBjb25zdCBGbG9hdFBvaW50JiBwMSwgZmxvYXQgcgogICAgICwgbV9yMShyMSkKICAg ICAsIG1fc3RvcHNTb3J0ZWQoZmFsc2UpCiAgICAgLCBtX2xhc3RTdG9wKDApCisgICAgLCBtX3Nw cmVhZE1ldGhvZChTcHJlYWRNZXRob2RQYWQpCiB7CiAgICAgcGxhdGZvcm1Jbml0KCk7CiB9Cg== 30365 2009-05-14 21:03:37 -0700 2009-05-14 21:03:37 -0700 new patch without the tabs this time patch.diff text/plain 1038 kuchhal ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Mzc1MTg3YS4uMTRmMGUxMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wNS0xNCAgUmFodWwgS3VjaGhh bCAgPGt1Y2hoYWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluaXRpYWxpemUgbV9zcHJlYWRNZXRob2QgaW4gdGhlIHNlY29u ZCBjb25zdHJ1Y3RvciB0b28uIE5vdCBzdXJlIGlmCisgICAgICAgIGEgdGVzdCBjYXNlIGNhbiBi ZSB3cml0dGVuLCBzbyBubyB0ZXN0IGNhc2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yNTgxNAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhZGllbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhZGllbnQ6OkdyYWRpZW50KToKKwog MjAwOS0wNS0xMyAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0dyYWRpZW50LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQu Y3BwCmluZGV4IDI0ZThiYmYuLjUxYzcxNjIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhZGllbnQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3Jh ZGllbnQuY3BwCkBAIC01Miw2ICs1Miw3IEBAIEdyYWRpZW50OjpHcmFkaWVudChjb25zdCBGbG9h dFBvaW50JiBwMCwgZmxvYXQgcjAsIGNvbnN0IEZsb2F0UG9pbnQmIHAxLCBmbG9hdCByCiAgICAg LCBtX3IxKHIxKQogICAgICwgbV9zdG9wc1NvcnRlZChmYWxzZSkKICAgICAsIG1fbGFzdFN0b3Ao MCkKKyAgICAsIG1fc3ByZWFkTWV0aG9kKFNwcmVhZE1ldGhvZFBhZCkKIHsKICAgICBwbGF0Zm9y bUluaXQoKTsKIH0K