258129 2023-06-15 07:02:02 -0700 REGRESSION(264515@main): [GStreamer] Use of WeakPtr for m_player in MediaPlayerPrivateGStreamer looks unsafe 2023-06-16 03:03:22 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=254954 https://bugs.webkit.org/show_bug.cgi?id=258022 InRadar P2 Normal --- 1 mcatanzaro philn bugs-noreply mcatanzaro webkit-bug-importer oldest_to_newest 1961792 0 mcatanzaro 2023-06-15 07:02:02 -0700 Moving this from bug #254954. I'm not sure that changing m_player to be a WeakPtr is actually safe to do without auditing its usage further. For example, in MediaPlayerPrivateGStreamer::handleNeedContextMessage, we have: gst_structure_set(contextStructure, "player", G_TYPE_POINTER, m_player.get(), nullptr); gst_element_set_context(GST_ELEMENT(GST_MESSAGE_SRC(message)), context.get()); So now it's stored dereferenced for what I assume is the lifetime of this GstMessage, and the WeakPtr provides no protection against invalidation. So probably it's not safe to use WeakPtr. This should be looked at more closely. 1961798 1 pnormand 2023-06-15 07:49:56 -0700 Pull request: https://github.com/WebKit/WebKit/pull/15003 1962050 2 ews-feeder 2023-06-16 03:02:14 -0700 Committed 265236@main (1ddda51c8059): <https://commits.webkit.org/265236@main> Reviewed commits have been landed. Closing PR #15003 and removing active labels. 1962051 3 webkit-bug-importer 2023-06-16 03:03:22 -0700 <rdar://problem/110891059>