258057 2023-06-13 19:02:33 -0700 Fix WasmBBQJIT failing to preserve locations in ScratchScope 2023-06-14 09:42:59 -0700 1 1 1 Unclassified WebKit WebAssembly WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 258044 InRadar P2 Normal --- 1 d_degazio d_degazio webkit-bug-importer oldest_to_newest 1961459 0 d_degazio 2023-06-13 19:02:33 -0700 rdar://110747242 The ScratchScope abstraction used by the new WebAssembly BBQ JIT implementation is supposed to allow for the preservation of certain registers throughout its scope, preventing them from being chosen as scratches or used for newly allocated values. However, we don't actually do this when locations that are already in use are passed to ScratchScope, which largely defeats the purpose of being able to preserve live registers. It's not clear if this can be reproduced by actual WebAssembly sources, but it's definitely not how this class is supposed to work. 1961563 1 d_degazio 2023-06-14 09:26:26 -0700 Pull request: https://github.com/WebKit/WebKit/pull/14958 1961567 2 d_degazio 2023-06-14 09:42:59 -0700 https://bugs.webkit.org/show_bug.cgi?id=258044 tracks the same issue, and was created earlier; resolving this as a dupe and closing my PR. *** This bug has been marked as a duplicate of bug 258044 ***