25805 2009-05-14 14:10:48 -0700 In debug build, mingw win32 build has problems with powf 2010-03-04 05:50:58 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Windows XP RESOLVED WORKSFORME P2 Normal --- 0 fridrich.strba webkit-unassigned xan.lopez oldest_to_newest 121378 0 fridrich.strba 2009-05-14 14:10:48 -0700 In mingw32 w32api and runtime, the powf function is _CRT_INLINE, but in debug build -O0, compiler fails to inline it and then there is problem of linking. The following patch makes the use of the proper overloade C++ pow (which is actually using compiler builtins with mingw). It makes the code even a bit more C++ like and does not break anything. 121379 1 30355 fridrich.strba 2009-05-14 14:11:36 -0700 Created attachment 30355 use a proper C++ overloaded pow instead of C-style powf 121380 2 30355 darin 2009-05-14 14:14:33 -0700 Comment on attachment 30355 use a proper C++ overloaded pow instead of C-style powf Needs ChangeLog. Needs testing on all the major platforms that WebKit supports. Generally seems strange to do this here when the rest of the project takes the other approach. 121452 3 30368 fridrich.strba 2009-05-15 00:32:37 -0700 Created attachment 30368 Clean proper standard-compliant patch with a proper clean ChangeLog entry 121457 4 fridrich.strba 2009-05-15 00:50:56 -0700 I also submitted also a bug report against the mingw toolchain https://sourceforge.net/tracker/?func=detail&aid=2792082&group_id=2435&atid=102435 121474 5 30375 fridrich.strba 2009-05-15 01:42:15 -0700 Created attachment 30375 This patch even has the proper e-mail address and spaces instead of tabs 122551 6 30375 mjs 2009-05-21 22:59:58 -0700 Comment on attachment 30375 This patch even has the proper e-mail address and spaces instead of tabs Looks good. 122580 7 xan.lopez 2009-05-22 00:29:58 -0700 (In reply to comment #6) > (From update of attachment 30375 [review]) > Looks good. > Committed as r44035. 122611 8 xan.lopez 2009-05-22 01:39:00 -0700 After various attempts to make this compile and work in Mac, Windows (MSVC) and Linux we ended up reverting the patch in r44039. Reopening the bug. 122671 9 30375 eric 2009-05-22 08:26:11 -0700 Comment on attachment 30375 This patch even has the proper e-mail address and spaces instead of tabs Marking r- since this was rolled out. (Thus removing it from the commit queue) 196018 10 fridrich.strba 2010-03-04 05:50:58 -0800 I did not see this problem anymore since I changed the runtime implementation I build against 30355 2009-05-14 14:11:36 -0700 2009-05-15 00:32:37 -0700 use a proper C++ overloaded pow instead of C-style powf mingw_temp.diff text/plain 1413 fridrich.strba LS0tIHdlYmtpdC0xLjEuNy9XZWJDb3JlL3JlbmRlcmluZy9TVkdJbmxpbmVUZXh0Qm94LmNwcAky MDA5LTAyLTI2IDIyOjU0OjQ3LjAwMDAwMDAwMCArMDEwMAorKysgd2Via2l0LTEuMS43L1dlYkNv cmUvcmVuZGVyaW5nL1NWR0lubGluZVRleHRCb3guY3BwCTIwMDktMDUtMTQgMjA6NDk6NDEuMDAw MDAwMDAwICswMjAwCkBAIC0zNiw3ICszNiw3IEBACiAjaW5jbHVkZSAiU1ZHUm9vdElubGluZUJv eC5oIgogI2luY2x1ZGUgIlRleHQuaCIKIAotI2luY2x1ZGUgPGZsb2F0Lmg+CisjaW5jbHVkZSA8 Y21hdGg+CiAKIHVzaW5nIHN0ZDo6bWF4OwogCkBAIC00ODksNyArNDg5LDcgQEAKICAgICBmbG9h dCB0aGlja25lc3MgPSBTVkdSZW5kZXJTdHlsZTo6Y3NzUHJpbWl0aXZlVG9MZW5ndGgob2JqZWN0 LCBvYmplY3QtPnN0eWxlKCktPnN2Z1N0eWxlKCktPnN0cm9rZVdpZHRoKCksIDEuMGYpOwogCiAg ICAgY29uc3QgRm9udCYgZm9udCA9IG9iamVjdC0+c3R5bGUoKS0+Zm9udCgpOwotICAgIHRoaWNr bmVzcyA9IG1heCh0aGlja25lc3MgKiBwb3dmKGZvbnQuc2l6ZSgpLCAyLjBmKSAvIGZvbnQudW5p dHNQZXJFbSgpLCAxLjBmKTsKKyAgICB0aGlja25lc3MgPSBtYXgodGhpY2tuZXNzICogcG93KGZv bnQuc2l6ZSgpLCAyLjBmKSAvIGZvbnQudW5pdHNQZXJFbSgpLCAxLjApOwogCiAgICAgaWYgKGRl Y29yYXRpb24gPT0gVU5ERVJMSU5FKQogICAgICAgICB5ICs9IHRoaWNrbmVzcyAqIDEuNWY7IC8v IEZvciBjb21wYXRpYmlsaXR5IHdpdGggQmF0aWsvT3BlcmEKLS0tIHdlYmtpdC0xLjEuNy9XZWJD b3JlL3N2Zy9TVkdMZW5ndGguY3BwCTIwMDktMDEtMzEgMTY6MTA6NDQuMDAwMDAwMDAwICswMTAw CisrKyB3ZWJraXQtMS4xLjcvV2ViQ29yZS9zdmcvU1ZHTGVuZ3RoLmNwcAkyMDA5LTA1LTE0IDIw OjQ5OjQxLjAwMDAwMDAwMCArMDIwMApAQCAtMzQsNyArMzQsNyBAQAogI2luY2x1ZGUgIlNWR1Bh cnNlclV0aWxpdGllcy5oIgogI2luY2x1ZGUgIlNWR1NWR0VsZW1lbnQuaCIKIAotI2luY2x1ZGUg PG1hdGguaD4KKyNpbmNsdWRlIDxjbWF0aD4KICNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgog CiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0zMTQsNyArMzE0LDcgQEAKICAgICBlbHNlIGlmICht b2RlID09IExlbmd0aE1vZGVIZWlnaHQpCiAgICAgICAgIHJldHVybiB2YWx1ZSAqIGhlaWdodDsK ICAgICBlbHNlIGlmIChtb2RlID09IExlbmd0aE1vZGVPdGhlcikKLSAgICAgICAgcmV0dXJuIHZh bHVlICogc3FydGYocG93Zih3aWR0aCwgMikgKyBwb3dmKGhlaWdodCwgMikpIC8gc3FydGYoMi4w Zik7CisgICAgICAgIHJldHVybiB2YWx1ZSAqIHNxcnQocG93KHdpZHRoLCAyKSArIHBvdyhoZWln aHQsIDIpKSAvIHNxcnQoMi4wZik7CiAKICAgICByZXR1cm4gMC4wZjsKIH0K 30368 2009-05-15 00:32:37 -0700 2009-05-15 01:42:49 -0700 Clean proper standard-compliant patch with a proper clean ChangeLog entry patch3.diff text/plain 2226 fridrich.strba SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Mzc1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDUtMTUgIEZyaWRyaWNoIFN0cmJhICA8c2V0IEVNQUlMX0FE RFJFU1MgZW52aXJvbm1lbnQgdmFyaWFibGU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisJCQorCQlDaGFuZ2UgQy1zdHlsZSBjYWxscyB0byBwb3dmIGFuZCBzcXJ0ZiB0 byBDKystc3R5bGUgY2FsbHMgdG8KKwkJb3ZlcmxvYWRlZCBwb3cgYW5kIHNxcnQuIFRoaXMgc29s dmVzIGFsc28gYSBwcm9ibGVtIHdpdGggbWluZ3cKKwkJY29tcGlsZXIgZHVyaW5nIHRoZSBkZWJ1 ZyBidWlsZC4KKworICAgICAgICAqIHJlbmRlcmluZy9TVkdJbmxpbmVUZXh0Qm94LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OnBhdGhGb3JEZWNvcmF0aW9uKToKKyAgICAgICAgKiBzdmcvU1ZHTGVu Z3RoLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR0xlbmd0aDo6UGVyY2VudGFnZU9mVmlld3Bv cnQpOgorCiAyMDA5LTA1LTE1ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBIb2xnZXIgRnJleXRoZXIuCkluZGV4OiBXZWJD b3JlL3N2Zy9TVkdMZW5ndGguY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3ZnL1NWR0xlbmd0 aC5jcHAJKHJldmlzaW9uIDQzNzU4KQorKysgV2ViQ29yZS9zdmcvU1ZHTGVuZ3RoLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzQsNyArMzQsNyBAQAogI2luY2x1ZGUgIlNWR1BhcnNlclV0aWxpdGll cy5oIgogI2luY2x1ZGUgIlNWR1NWR0VsZW1lbnQuaCIKIAotI2luY2x1ZGUgPG1hdGguaD4KKyNp bmNsdWRlIDxjbWF0aD4KICNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgogCiBuYW1lc3BhY2Ug V2ViQ29yZSB7CkBAIC0zMTQsNyArMzE0LDcgQEAKICAgICBlbHNlIGlmIChtb2RlID09IExlbmd0 aE1vZGVIZWlnaHQpCiAgICAgICAgIHJldHVybiB2YWx1ZSAqIGhlaWdodDsKICAgICBlbHNlIGlm IChtb2RlID09IExlbmd0aE1vZGVPdGhlcikKLSAgICAgICAgcmV0dXJuIHZhbHVlICogc3FydGYo cG93Zih3aWR0aCwgMikgKyBwb3dmKGhlaWdodCwgMikpIC8gc3FydGYoMi4wZik7CisgICAgICAg IHJldHVybiB2YWx1ZSAqIHNxcnQocG93KHdpZHRoLCAyKSArIHBvdyhoZWlnaHQsIDIpKSAvIHNx cnQoMi4wZik7CiAKICAgICByZXR1cm4gMC4wZjsKIH0KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5n L1NWR0lubGluZVRleHRCb3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1NW R0lubGluZVRleHRCb3guY3BwCShyZXZpc2lvbiA0Mzc1OCkKKysrIFdlYkNvcmUvcmVuZGVyaW5n L1NWR0lubGluZVRleHRCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw3ICszNiw3IEBACiAj aW5jbHVkZSAiU1ZHUm9vdElubGluZUJveC5oIgogI2luY2x1ZGUgIlRleHQuaCIKIAotI2luY2x1 ZGUgPGZsb2F0Lmg+CisjaW5jbHVkZSA8Y21hdGg+CiAKIHVzaW5nIHN0ZDo6bWF4OwogCkBAIC00 ODksNyArNDg5LDcgQEAKICAgICBmbG9hdCB0aGlja25lc3MgPSBTVkdSZW5kZXJTdHlsZTo6Y3Nz UHJpbWl0aXZlVG9MZW5ndGgob2JqZWN0LCBvYmplY3QtPnN0eWxlKCktPnN2Z1N0eWxlKCktPnN0 cm9rZVdpZHRoKCksIDEuMGYpOwogCiAgICAgY29uc3QgRm9udCYgZm9udCA9IG9iamVjdC0+c3R5 bGUoKS0+Zm9udCgpOwotICAgIHRoaWNrbmVzcyA9IG1heCh0aGlja25lc3MgKiBwb3dmKGZvbnQu c2l6ZSgpLCAyLjBmKSAvIGZvbnQudW5pdHNQZXJFbSgpLCAxLjBmKTsKKyAgICB0aGlja25lc3Mg PSBtYXgodGhpY2tuZXNzICogcG93KGZvbnQuc2l6ZSgpLCAyLjBmKSAvIGZvbnQudW5pdHNQZXJF bSgpLCAxLjApOwogCiAgICAgaWYgKGRlY29yYXRpb24gPT0gVU5ERVJMSU5FKQogICAgICAgICB5 ICs9IHRoaWNrbmVzcyAqIDEuNWY7IC8vIEZvciBjb21wYXRpYmlsaXR5IHdpdGggQmF0aWsvT3Bl cmEK 30375 2009-05-15 01:42:15 -0700 2009-05-22 08:26:11 -0700 This patch even has the proper e-mail address and spaces instead of tabs patch3.diff text/plain 2237 fridrich.strba SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Mzc1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDUtMTUgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3Ry YmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAg ICAgICAgCisgICAgICAgIENoYW5nZSBDLXN0eWxlIGNhbGxzIHRvIHBvd2YgYW5kIHNxcnRmIHRv IEMrKy1zdHlsZSBjYWxscyB0bworICAgICAgICBvdmVybG9hZGVkIHBvdyBhbmQgc3FydC4gVGhp cyBzb2x2ZXMgYWxzbyBhIHByb2JsZW0gd2l0aCBtaW5ndworICAgICAgICBjb21waWxlciBkdXJp bmcgdGhlIGRlYnVnIGJ1aWxkLgorCisgICAgICAgICogcmVuZGVyaW5nL1NWR0lubGluZVRleHRC b3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGF0aEZvckRlY29yYXRpb24pOgorICAgICAgICAq IHN2Zy9TVkdMZW5ndGguY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHTGVuZ3RoOjpQZXJjZW50 YWdlT2ZWaWV3cG9ydCk6CisKIDIwMDktMDUtMTUgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5n b21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEhvbGdlciBGcmV5dGhlci4K SW5kZXg6IFdlYkNvcmUvc3ZnL1NWR0xlbmd0aC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9z dmcvU1ZHTGVuZ3RoLmNwcAkocmV2aXNpb24gNDM3NTgpCisrKyBXZWJDb3JlL3N2Zy9TVkdMZW5n dGguY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw3ICszNCw3IEBACiAjaW5jbHVkZSAiU1ZHUGFy c2VyVXRpbGl0aWVzLmgiCiAjaW5jbHVkZSAiU1ZHU1ZHRWxlbWVudC5oIgogCi0jaW5jbHVkZSA8 bWF0aC5oPgorI2luY2x1ZGUgPGNtYXRoPgogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CiAK IG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTMxNCw3ICszMTQsNyBAQAogICAgIGVsc2UgaWYgKG1v ZGUgPT0gTGVuZ3RoTW9kZUhlaWdodCkKICAgICAgICAgcmV0dXJuIHZhbHVlICogaGVpZ2h0Owog ICAgIGVsc2UgaWYgKG1vZGUgPT0gTGVuZ3RoTW9kZU90aGVyKQotICAgICAgICByZXR1cm4gdmFs dWUgKiBzcXJ0Zihwb3dmKHdpZHRoLCAyKSArIHBvd2YoaGVpZ2h0LCAyKSkgLyBzcXJ0ZigyLjBm KTsKKyAgICAgICAgcmV0dXJuIHZhbHVlICogc3FydChwb3cod2lkdGgsIDIpICsgcG93KGhlaWdo dCwgMikpIC8gc3FydCgyLjBmKTsKIAogICAgIHJldHVybiAwLjBmOwogfQpJbmRleDogV2ViQ29y ZS9yZW5kZXJpbmcvU1ZHSW5saW5lVGV4dEJveC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9y ZW5kZXJpbmcvU1ZHSW5saW5lVGV4dEJveC5jcHAJKHJldmlzaW9uIDQzNzU4KQorKysgV2ViQ29y ZS9yZW5kZXJpbmcvU1ZHSW5saW5lVGV4dEJveC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2LDcg KzM2LDcgQEAKICNpbmNsdWRlICJTVkdSb290SW5saW5lQm94LmgiCiAjaW5jbHVkZSAiVGV4dC5o IgogCi0jaW5jbHVkZSA8ZmxvYXQuaD4KKyNpbmNsdWRlIDxjbWF0aD4KIAogdXNpbmcgc3RkOjpt YXg7CiAKQEAgLTQ4OSw3ICs0ODksNyBAQAogICAgIGZsb2F0IHRoaWNrbmVzcyA9IFNWR1JlbmRl clN0eWxlOjpjc3NQcmltaXRpdmVUb0xlbmd0aChvYmplY3QsIG9iamVjdC0+c3R5bGUoKS0+c3Zn U3R5bGUoKS0+c3Ryb2tlV2lkdGgoKSwgMS4wZik7CiAKICAgICBjb25zdCBGb250JiBmb250ID0g b2JqZWN0LT5zdHlsZSgpLT5mb250KCk7Ci0gICAgdGhpY2tuZXNzID0gbWF4KHRoaWNrbmVzcyAq IHBvd2YoZm9udC5zaXplKCksIDIuMGYpIC8gZm9udC51bml0c1BlckVtKCksIDEuMGYpOworICAg IHRoaWNrbmVzcyA9IG1heCh0aGlja25lc3MgKiBwb3coZm9udC5zaXplKCksIDIuMGYpIC8gZm9u dC51bml0c1BlckVtKCksIDEuMCk7CiAKICAgICBpZiAoZGVjb3JhdGlvbiA9PSBVTkRFUkxJTkUp CiAgICAgICAgIHkgKz0gdGhpY2tuZXNzICogMS41ZjsgLy8gRm9yIGNvbXBhdGliaWxpdHkgd2l0 aCBCYXRpay9PcGVyYQo=