258038 2023-06-13 11:54:39 -0700 REGRESSION(264798@main): Archive-minified-built-product is failing due to extra argument "archive" 2023-06-13 12:55:40 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=256283 InRadar P2 Normal --- 1 jenner aakash_jain aakash_jain clopez gsnedders webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1961379 0 jenner 2023-06-13 11:54:39 -0700 We are failing open source builds because archive-minified-built-product is being invoked incorrectly. On the first failure it is running the script as: 'python3 Tools/CISupport/built-product-archive --platform=mac-ventura --release archive --minify archive' https://build.webkit.org/#/builders/706/builds/7107 Whereas on the last time it was passing it was running as: 'python3 Tools/CISupport/built-product-archive --platform=mac-ventura --release archive --minify' So it basically looks like "archive" got added after minify, and it's causing it to fail as: Traceback (most recent call last): File "/Volumes/Data/worker/Apple-Ventura-Release-Build/build/Tools/CISupport/built-product-archive", line 368, in <module> sys.exit(main()) File "/Volumes/Data/worker/Apple-Ventura-Release-Build/build/Tools/CISupport/built-product-archive", line 54, in main options, (action, ) = parser.parse_args() ValueError: too many values to unpack (expected 1) 1961380 1 webkit-bug-importer 2023-06-13 11:56:43 -0700 <rdar://problem/110724385> 1961381 2 aakash_jain 2023-06-13 12:02:36 -0700 Command from old successful run: https://build.webkit.org/#/builders/706/builds/7007/steps/13/logs/stdio python3 Tools/CISupport/built-product-archive --platform=mac-ventura --release archive --minify Command from recent failing run: https://build.webkit.org/#/builders/706/builds/7107/steps/13/logs/stdio python3 Tools/CISupport/built-product-archive --platform=mac-ventura --release archive --minify archive There is extra argument 'archive'. This seems to be regression from https://commits.webkit.org/264798@main 1961383 3 gsnedders 2023-06-13 12:06:57 -0700 This change (264798@main) changed ArchiveBuiltProduct but not its subclass ArchiveMinifiedBuiltProduct, leaving the subclass both with its existing "archive" and the one added in ArchiveBuiltProduct.run (https://github.com/WebKit/WebKit/blob/964948660ae097f883e12408b84dea3efd98a7ae/Tools/CISupport/build-webkit-org/steps.py#L434). It's not clear to me why it needs to be added in ArchiveBuiltProduct.run at all? Python's optparse doesn't care if arguments and options are intermixed, so there's no need for the run method to add it explicitly to the end as far as I can see? 1961384 4 aakash_jain 2023-06-13 12:07:36 -0700 Pull request: https://github.com/WebKit/WebKit/pull/14931 1961390 5 ews-feeder 2023-06-13 12:55:38 -0700 Committed 265131@main (328332879f73): <https://commits.webkit.org/265131@main> Reviewed commits have been landed. Closing PR #14931 and removing active labels.