257931 2023-06-09 20:57:06 -0700 Add parsing support for word-boundary-detection 2023-06-13 00:33:18 -0700 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield dpino dpino mmaxfield webkit-bug-importer oldest_to_newest 1960909 0 mmaxfield 2023-06-09 20:57:06 -0700 Add parsing support for word-boundary-detection 1960910 1 webkit-bug-importer 2023-06-09 20:57:23 -0700 <rdar://problem/110562385> 1960912 2 mmaxfield 2023-06-09 21:07:01 -0700 Pull request: https://github.com/WebKit/WebKit/pull/14843 1960952 3 ews-feeder 2023-06-10 19:17:39 -0700 Committed 265057@main (9e639f149ac0): <https://commits.webkit.org/265057@main> Reviewed commits have been landed. Closing PR #14843 and removing active labels. 1960979 4 dpino 2023-06-11 22:39:33 -0700 WebKitGTK Debian Stable bot build is failing with the following error after this change: https://build.webkit.org/#/builders/46/builds/30880 FAILED: In file included from WTF/Headers/wtf/StdLibExtras.h:33, from WTF/Headers/wtf/FastMalloc.h:26, from ../../Source/WebCore/config.h:47, from WebCore/DerivedSources/JSDOMPoint.cpp:21, from WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-34.cpp:1: /usr/include/c++/10/variant: In instantiation of ‘constexpr const size_t std::variant_size_v<WebCore::WordBoundaryDetection>’: /usr/include/c++/10/variant:1039:10: required from ‘struct std::__detail::__variant::__gen_vtable<std::__detail::__variant::__deduce_visit_result<void>, WTF::Visitor<WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionNormal)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionManual)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(const WebCore::WordBoundaryDetectionAuto&)> >&&, WebCore::WordBoundaryDetection&>’ /usr/include/c++/10/variant:1699:45: required from ‘constexpr decltype(auto) std::__do_visit(_Visitor&&, _Variants&& ...) [with _Result_type = std::__detail::__variant::__deduce_visit_result<void>; _Visitor = WTF::Visitor<WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionNormal)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionManual)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(const WebCore::WordBoundaryDetectionAuto&)> >; _Variants = {WebCore::WordBoundaryDetection&}]’ /usr/include/c++/10/variant:1718:35: required from ‘constexpr decltype(auto) std::visit(_Visitor&&, _Variants&& ...) [with _Visitor = WTF::Visitor<WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionNormal)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionManual)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(const WebCore::WordBoundaryDetectionAuto&)> >; _Variants = {WebCore::WordBoundaryDetection&}]’ WTF/Headers/wtf/StdLibExtras.h:445:54: required by substitution of ‘template<class V, class ... F> decltype (std::visit(WTF::makeVisitor((forward<F>)(WTF::switchOn::f)...), forward<V>(v))) WTF::switchOn(V&&, F&& ...) [with V = WebCore::WordBoundaryDetection&; F = {WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionNormal)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionManual)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(const WebCore::WordBoundaryDetectionAuto&)>}]’ ../../Source/WebCore/rendering/style/WordBoundaryDetection.h:59:6: required from here /usr/include/c++/10/variant:97:70: error: incomplete type ‘std::variant_size<WebCore::WordBoundaryDetection>’ used in nested name specifier 97 | inline constexpr size_t variant_size_v = variant_size<_Variant>::value; | ^~~~~ /usr/include/c++/10/variant: In instantiation of ‘constexpr decltype(auto) std::__do_visit(_Visitor&&, _Variants&& ...) [with _Result_type = std::__detail::__variant::__deduce_visit_result<void>; _Visitor = WTF::Visitor<WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionNormal)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionManual)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(const WebCore::WordBoundaryDetectionAuto&)> >; _Variants = {WebCore::WordBoundaryDetection&}]’: /usr/include/c++/10/variant:1718:35: required from ‘constexpr decltype(auto) std::visit(_Visitor&&, _Variants&& ...) [with _Visitor = WTF::Visitor<WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionNormal)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(WebCore::WordBoundaryDetectionManual)>, WebCore::operator<<(WTF::TextStream&, WebCore::WordBoundaryDetection)::<lambda(const WebCore::WordBoundaryDetectionAuto&)> >; _Variants = {WebCore::WordBoundaryDetection&}]’ 1960986 5 dpino 2023-06-12 00:00:45 -0700 Re-opening for pull request https://github.com/webkit/webkit/pull/14855 1961261 6 ews-feeder 2023-06-13 00:33:15 -0700 Committed 265109@main (6ff8c5f88a55): <https://commits.webkit.org/265109@main> Reviewed commits have been landed. Closing PR #14855 and removing active labels.