257861 2023-06-08 11:57:35 -0700 REGRESSION (262875@main / iOS 17): fill: 'both' not respected with animation 2023-07-10 11:01:23 -0700 1 1 1 Unclassified WebKit Animations Safari 17 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=255338 https://github.com/web-platform-tests/wpt/pull/40736 https://github.com/web-platform-tests/wpt/pull/40947 InRadar P2 Normal --- 1 ldebeasi graouts dino graouts graouts webkit-bug-importer zalan oldest_to_newest 1960592 0 466639 ldebeasi 2023-06-08 11:57:35 -0700 Created attachment 466639 Code reproduction Using fill: 'both' causes elements to disappear after their animation ends when using iOS 17 beta 1. Steps to reproduce: 1. Open code reproduction on an iOS 17 device. 2. Tap "Open Overlay". Observe that the overlay opens. 3. Tap "Close Overlay". Observe that the overlay closes. 4. Tap "Open Overlay" again. Observe that the overlay opens and then disappears. Expected Behavior: I expect the overlay to remain visible every time I present it. Actual Behavior: The overlay disappears after subsequent presentations. Other Information: - This does not reproduce on Chrome 113 or Firefox 113. - This does not reproduce on iOS 16. This appears to be a regression on iOS 17. 1960904 1 webkit-bug-importer 2023-06-09 19:03:40 -0700 <rdar://problem/110559121> 1960960 2 graouts 2023-06-11 12:05:27 -0700 I'll look into this. In the meantime, do you know whether this only apply to opacity or transform, which are accelerated properties, or also other properties such as width/height/top/left which are not accelerated? 1961000 3 graouts 2023-06-12 03:29:56 -0700 This regressed with 262875@main, the fix for bug 255338. 1961011 4 466664 ldebeasi 2023-06-12 05:43:10 -0700 Created attachment 466664 Non-accelerated demo (working as expected) This behavior does not reproduce with non-accelerated properties. I attached a reproduction that shows the expected behavior when animating height. 1961586 5 466694 zalan 2023-06-14 11:23:57 -0700 Created attachment 466694 Test reduction 1961589 6 466695 zalan 2023-06-14 11:26:18 -0700 Created attachment 466695 Test reduction 1961791 7 graouts 2023-06-15 06:56:34 -0700 Not clear to me what is going wrong just yet, as far as I can tell at the GraphicsLayerCA level we are left with a single animation which is the last added animation in the test reduction – which is correct since its composite order is higher and the first animation is "replaced" per https://drafts.csswg.org/web-animations-1/#removing-replaced-animations. So I don't yet understand what the presentation value is the final value of the first animation. 1961794 8 graouts 2023-06-15 07:14:33 -0700 Actually, we end up calling GraphicsLayerCA::removeAnimation() with the last animation and not the former, so the final stack for GraphicsLayerCA is incorrect. So the presentation value makes sense, it's the content of the GraphicsLayerCA animation stack which is incorrect. 1961890 9 zalan 2023-06-15 14:12:30 -0700 <rdar://109221339> 1962033 10 graouts 2023-06-16 01:33:00 -0700 The accelerated actions we issue are correct, the first animation is played and stopped when it stops producing an interpolating value, at which points the second animation is played and stopped when itself stops producing an interpolating value. Somehow, we fail to remove the first animation, or add it back, it's unclear yet. 1962034 11 graouts 2023-06-16 01:38:37 -0700 Oh, I think I see what's wrong, in KeyframeEffect::applyPendingAcceleratedActionsOrUpdateTimingProperties() we append AcceleratedAction::UpdateProperties but fail to record it as the last recorded action. This might just be it, there's a state disconnect here. 1963352 12 zalan 2023-06-23 10:34:48 -0700 *** Bug 258134 has been marked as a duplicate of this bug. *** 1963469 13 graouts 2023-06-24 06:08:23 -0700 Pull request: https://github.com/WebKit/WebKit/pull/15275 1963470 14 graouts 2023-06-24 06:18:40 -0700 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/40736 1963487 15 ews-feeder 2023-06-24 11:05:40 -0700 Committed 265498@main (c35a74273103): <https://commits.webkit.org/265498@main> Reviewed commits have been landed. Closing PR #15275 and removing active labels. 1963833 16 zalan 2023-06-27 09:12:50 -0700 While the fix addresses https://bug-257861-attachments.webkit.org/attachment.cgi?id=466695 it does not fix the original test case (and the duped bugzilla fails too) 1963875 17 zalan 2023-06-27 12:51:59 -0700 Let's use <rdar://111407099> to track this issue. 1963999 18 graouts 2023-06-28 03:45:22 -0700 Sorry for not being as thorough as I should have been. I'll take a look at the Code reproduction listed here. Should we also de-dupe bug 258134 until we know for a fact that the complete fix for this bug actually addresses that bug as well? 1964608 19 graouts 2023-07-01 01:29:22 -0700 I have a good understand of the issue here, we'll need to send down the relative sorting order of accelerated effects to GraphicsLayerCA which should be easy enough. I'm hoping to get this done in the coming week (starting July 3). 1965937 20 graouts 2023-07-10 07:21:17 -0700 Pull request: https://github.com/WebKit/WebKit/pull/15693 1965938 21 graouts 2023-07-10 07:22:25 -0700 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/40947 1965976 22 ews-feeder 2023-07-10 10:33:01 -0700 Committed 265909@main (6f928cc543c3): <https://commits.webkit.org/265909@main> Reviewed commits have been landed. Closing PR #15693 and removing active labels. 1965979 23 graouts 2023-07-10 10:41:31 -0700 @Liam: does that regression break a website or application? 1965983 24 ldebeasi 2023-07-10 11:01:23 -0700 This breaks Ionic Framework's sheet modal component: https://docs-demo.ionic.io/component/modal Open on an iOS 17 device and tap "Open Sheet Modal". The animation should break after you try to swipe. Thanks for the fix! I'll give this a try when it lands in an upcoming beta. 466639 2023-06-08 11:57:35 -0700 2023-06-08 11:57:35 -0700 Code reproduction index.html text/html 1706 ldebeasi PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPG1ldGEgY2hhcnNldD0iVVRGLTgi IC8+CiAgICA8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0id2lkdGg9ZGV2aWNlLXdpZHRo LCBpbml0aWFsLXNjYWxlPTEiIC8+CiAgICA8c3R5bGU+CiAgICAgIC5vdmVybGF5LWhpZGRlbiB7 CiAgICAgICAgZGlzcGxheTogbm9uZTsKICAgICAgfQogICAgPC9zdHlsZT4KICA8L2hlYWQ+CiAg PGJvZHk+ICAgCiAgICAgPGJ1dHRvbiBvbmNsaWNrPSJzaG93T3ZlcmxheSgpIj5PcGVuIE92ZXJs YXk8L2J1dHRvbj4KICAgICAgPGN1c3RvbS1vdmVybGF5IGNsYXNzPSJvdmVybGF5LWhpZGRlbiI+ CiAgICAgICAgQ29udGVudAogICAgICAgIDxidXR0b24gb25jbGljaz0iY2xvc2VPdmVybGF5KCki PkNsb3NlIE92ZXJsYXk8L2J1dHRvbj4KICAgICAgPC9jdXN0b20tb3ZlcmxheT4KICAgIAogICAg CiAgICA8c2NyaXB0PgogICAgICBjbGFzcyBDdXN0b21PdmVybGF5IGV4dGVuZHMgSFRNTEVsZW1l bnQgewogICAgICAgIGNvbnN0cnVjdG9yKCkgewogICAgICAgICAgc3VwZXIoKTsKICAgICAgICAg IGNvbnN0IHJvb3QgPSB0aGlzLmF0dGFjaFNoYWRvdyh7IG1vZGU6ICdvcGVuJyB9KTsKICAgIAog ICAgICAgICAgcm9vdC5pbm5lckhUTUwgPSBgCiAgICAgICAgICAgIDxkaXYgY2xhc3M9Im92ZXJs YXktd3JhcHBlciI+CiAgICAgICAgICAgICAgPHNsb3Q+PC9zbG90PgogICAgICAgICAgICA8L2Rp dj4KICAgICAgICAgIGAKICAgICAgICB9CiAgICAgIH0KICAgIAogICAgICBjdXN0b21FbGVtZW50 cy5kZWZpbmUoJ2N1c3RvbS1vdmVybGF5JywgQ3VzdG9tT3ZlcmxheSk7CiAgICAKICAgIAogICAg ICBjb25zdCBjdXN0b21PdmVybGF5RWwgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdjdXN0b20t b3ZlcmxheScpOwogICAgICAKICAgICAgY29uc3Qgc2hvd092ZXJsYXkgPSAoKSA9PiB7CiAgICAg ICAgY3VzdG9tT3ZlcmxheUVsLmNsYXNzTGlzdC5yZW1vdmUoJ292ZXJsYXktaGlkZGVuJykKICAg IAogICAgICAgIGNvbnN0IHdyYXBwZXIgPSBjdXN0b21PdmVybGF5RWwuc2hhZG93Um9vdC5xdWVy eVNlbGVjdG9yKCcub3ZlcmxheS13cmFwcGVyJykKICAgICAgICBjb25zdCBhbmkgPSB3cmFwcGVy LmFuaW1hdGUoWwogICAgICAgICAgeyBvZmZzZXQ6IDAsIG9wYWNpdHk6IDAgfSwKICAgICAgICAg IHsgb2Zmc2V0OiAxLCBvcGFjaXR5OiAxIH0KICAgICAgICBdLCB7IGR1cmF0aW9uOiAxNTAsIGZp bGw6ICdib3RoJyB9KTsKICAgICAgfQogICAgCiAgICAgIGNvbnN0IGNsb3NlT3ZlcmxheSA9ICgp ID0+IHsKICAgICAgICBjb25zdCB3cmFwcGVyID0gY3VzdG9tT3ZlcmxheUVsLnNoYWRvd1Jvb3Qu cXVlcnlTZWxlY3RvcignLm92ZXJsYXktd3JhcHBlcicpCiAgICAgICAgY29uc3QgYW5pID0gd3Jh cHBlci5hbmltYXRlKFsKICAgICAgICAgIHsgb2Zmc2V0OiAwLCBvcGFjaXR5OiAxIH0sCiAgICAg ICAgICB7IG9mZnNldDogMSwgb3BhY2l0eTogMCB9CiAgICAgICAgXSwgeyBkdXJhdGlvbjogMTUw LCBmaWxsOiAnYm90aCcgfSk7CiAgICAgICAgCiAgICAgICAgYW5pLm9uZmluaXNoID0gKCkgPT4g ewogICAgICAgICAgY3VzdG9tT3ZlcmxheUVsLmNsYXNzTGlzdC5hZGQoJ292ZXJsYXktaGlkZGVu JykKICAgICAgICB9CiAgICAgIH0KICAgIDwvc2NyaXB0PgogIDwvYm9keT4KPC9odG1sPgo= 466664 2023-06-12 05:43:10 -0700 2023-06-12 05:43:10 -0700 Non-accelerated demo (working as expected) index.html text/html 1491 ldebeasi PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPG1ldGEgY2hhcnNldD0iVVRGLTgi IC8+CiAgICA8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0id2lkdGg9ZGV2aWNlLXdpZHRo LCBpbml0aWFsLXNjYWxlPTEiIC8+CiAgPC9oZWFkPgogIDxib2R5PiAgIAogICAgIDxidXR0b24g b25jbGljaz0ic2hvd092ZXJsYXkoKSI+T3BlbiBPdmVybGF5PC9idXR0b24+CiAgICAgIDxjdXN0 b20tb3ZlcmxheT4KICAgICAgICBDb250ZW50CiAgICAgICAgPGJ1dHRvbiBvbmNsaWNrPSJjbG9z ZU92ZXJsYXkoKSI+Q2xvc2UgT3ZlcmxheTwvYnV0dG9uPgogICAgICA8L2N1c3RvbS1vdmVybGF5 PgogICAgCiAgICAKICAgIDxzY3JpcHQ+CiAgICAgIGNsYXNzIEN1c3RvbU92ZXJsYXkgZXh0ZW5k cyBIVE1MRWxlbWVudCB7CiAgICAgICAgY29uc3RydWN0b3IoKSB7CiAgICAgICAgICBzdXBlcigp OwogICAgICAgICAgY29uc3Qgcm9vdCA9IHRoaXMuYXR0YWNoU2hhZG93KHsgbW9kZTogJ29wZW4n IH0pOwogICAgCiAgICAgICAgICByb290LmlubmVySFRNTCA9IGAKICAgICAgICAgICAgPGRpdiBj bGFzcz0ib3ZlcmxheS13cmFwcGVyIiBzdHlsZT0iYmFja2dyb3VuZDogZ3JlZW47IGhlaWdodDog MTAwcHgiPgogICAgICAgICAgICAgIDxzbG90Pjwvc2xvdD4KICAgICAgICAgICAgPC9kaXY+CiAg ICAgICAgICBgCiAgICAgICAgfQogICAgICB9CiAgICAKICAgICAgY3VzdG9tRWxlbWVudHMuZGVm aW5lKCdjdXN0b20tb3ZlcmxheScsIEN1c3RvbU92ZXJsYXkpOwogICAgCiAgICAgIGNvbnN0IGN1 c3RvbU92ZXJsYXlFbCA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2N1c3RvbS1vdmVybGF5Jyk7 CiAgICAgIAogICAgICBjb25zdCBzaG93T3ZlcmxheSA9ICgpID0+IHsgICAgCiAgICAgICAgY29u c3Qgd3JhcHBlciA9IGN1c3RvbU92ZXJsYXlFbC5zaGFkb3dSb290LnF1ZXJ5U2VsZWN0b3IoJy5v dmVybGF5LXdyYXBwZXInKQogICAgICAgIGNvbnN0IGFuaSA9IHdyYXBwZXIuYW5pbWF0ZShbCiAg ICAgICAgICB7IG9mZnNldDogMCwgaGVpZ2h0OiAnMTAwcHgnIH0sCiAgICAgICAgICB7IG9mZnNl dDogMSwgaGVpZ2h0OiAnMzAwcHgnIH0KICAgICAgICBdLCB7IGR1cmF0aW9uOiAxNTAsIGZpbGw6 ICdib3RoJyB9KTsKICAgICAgfQogICAgCiAgICAgIGNvbnN0IGNsb3NlT3ZlcmxheSA9ICgpID0+ IHsKICAgICAgICBjb25zdCB3cmFwcGVyID0gY3VzdG9tT3ZlcmxheUVsLnNoYWRvd1Jvb3QucXVl cnlTZWxlY3RvcignLm92ZXJsYXktd3JhcHBlcicpCiAgICAgICAgY29uc3QgYW5pID0gd3JhcHBl ci5hbmltYXRlKFsKICAgICAgICAgIHsgb2Zmc2V0OiAwLCBoZWlnaHQ6ICczMDBweCcgfSwKICAg ICAgICAgIHsgb2Zmc2V0OiAxLCBoZWlnaHQ6ICcxMDBweCcgfQogICAgICAgIF0sIHsgZHVyYXRp b246IDE1MCwgZmlsbDogJ2JvdGgnIH0pOwogICAgICB9CiAgICA8L3NjcmlwdD4KICA8L2JvZHk+ CjwvaHRtbD4K 466694 2023-06-14 11:23:57 -0700 2023-06-14 11:26:18 -0700 Test reduction 257861.html text/html 418 zalan PHN0eWxlPgojYW5pbWF0ZV90aGlzIHsKICB0cmFuc2Zvcm06IHRyYW5zbGF0ZVooMCk7Cn0KPC9z dHlsZT4KPGRpdiBpZD1hbmltYXRlX3RoaXM+UEFTUyBpZiB0aGlzIHNob3dzLjwvZGl2PjxzY3Jp cHQ+CmRvY3VtZW50LmJvZHkub2Zmc2V0SGVpZ2h0OwoKYW5pbWF0ZV90aGlzLmFuaW1hdGUoWwog IHsgb2Zmc2V0OiAwLCBvcGFjaXR5OiAxIH0sCiAgeyBvZmZzZXQ6IDEsIG9wYWNpdHk6IDAgfQpd LCB7IGR1cmF0aW9uOiAxMCwgZmlsbDogJ2JvdGgnIH0pLm9uZmluaXNoID0gKCkgPT4gewogIGFu aW1hdGVfdGhpcy5hbmltYXRlKFsKICAgIHsgb2Zmc2V0OiAwLCBvcGFjaXR5OiAwIH0sCiAgICB7 IG9mZnNldDogMSwgb3BhY2l0eTogMSB9CiAgXSwgeyBkdXJhdGlvbjogMTAsIGZpbGw6ICdib3Ro JyB9KTsKfTsKPC9zY3JpcHQ+Cg== 466695 2023-06-14 11:26:18 -0700 2023-06-14 11:26:18 -0700 Test reduction 257861.html text/html 495 zalan PHN0eWxlPgojYW5pbWF0ZV90aGlzIHsKICB0cmFuc2Zvcm06IHRyYW5zbGF0ZVooMCk7CiAgd2lk dGg6IDEwMHB4OwogIGhlaWdodDogMTAwcHg7CiAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47Cn0K PC9zdHlsZT4KUEFTUyBpZiBncmVlbiBib3ggaXMgdmlzaWJsZSBiZWxvdy4KPGRpdiBpZD1hbmlt YXRlX3RoaXM+PC9kaXY+PHNjcmlwdD4KZG9jdW1lbnQuYm9keS5vZmZzZXRIZWlnaHQ7Cgphbmlt YXRlX3RoaXMuYW5pbWF0ZShbCiAgeyBvZmZzZXQ6IDAsIG9wYWNpdHk6IDEgfSwKICB7IG9mZnNl dDogMSwgb3BhY2l0eTogMCB9Cl0sIHsgZHVyYXRpb246IDEwLCBmaWxsOiAnYm90aCcgfSkub25m aW5pc2ggPSAoKSA9PiB7CiAgYW5pbWF0ZV90aGlzLmFuaW1hdGUoWwogICAgeyBvZmZzZXQ6IDAs IG9wYWNpdHk6IDAgfSwKICAgIHsgb2Zmc2V0OiAxLCBvcGFjaXR5OiAxIH0KICBdLCB7IGR1cmF0 aW9uOiAxMCwgZmlsbDogJ2JvdGgnIH0pOwp9Owo8L3NjcmlwdD4K