25784 2009-05-14 02:20:20 -0700 Leaks seen on HTTP tests 2009-05-14 09:47:24 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap husam oldest_to_newest 121236 0 ap 2009-05-14 02:20:20 -0700 There are many leaks seen on HTTP tests. Some of them seem to be in system frameworks, so I'm going to fix some, and file Radar bugs for others. For those who can see it, one Radar bug is <rdar://problem/6886937>. 121237 1 30320 ap 2009-05-14 02:23:49 -0700 Created attachment 30320 proposed fix This fixes two bugs I found. 121268 2 ap 2009-05-14 05:09:13 -0700 (In reply to comment #0) > For those who can see it, one Radar bug is <rdar://problem/6886937>. Another one: <rdar://problem/6887278>. 121318 3 30320 darin 2009-05-14 09:24:24 -0700 Comment on attachment 30320 proposed fix > - NSMutableURLRequest *mutableRequest = [request.nsURLRequest() mutableCopy]; > + NSMutableURLRequest *mutableRequest = [[request.nsURLRequest() mutableCopy] autorelease]; Clearly this was just introduced by the bug fix for content sniffing. I'd prefer to find a way to fix this with an additional local variable and a normal release rather than autorelease. r=me as is, but consider making it use release instead of autorelease 121324 4 ap 2009-05-14 09:47:24 -0700 Committed r43709. (In reply to comment #3) > r=me as is, but consider making it use release instead of autorelease I think that it would be much more interesting - but also more difficult - to avoid autorelease in common code path. 30320 2009-05-14 02:23:49 -0700 2009-05-14 09:24:24 -0700 proposed fix LoaderLeaks.txt text/plain 2400 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzY4OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDUtMTQgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTc4NAorICAgICAgICBM ZWFrcyBzZWVuIG9uIEhUVFAgdGVzdHMKKworICAgICAgICBXZSBzaG91bGQgY2hhbmdlIFJlc291 cmNlSGFuZGxlTWFjLm1tIHRvIHVzZSBzbWFydCBwb2ludGVycyBzb21lIGRheSwgYnV0IHRoaXMg aXMgYSBtaW5pbWFsIGZpeC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291 cmNlSGFuZGxlTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmxvYWRS ZXNvdXJjZVN5bmNocm9ub3VzbHkpOiBSZWxlYXNlIG11dGFibGUgcmVxdWVzdCBjb3B5IG1hZGUg Zm9yCisgICAgICAgIGRpc2FibGluZyBjb250ZW50IHNuaWZmaW5nLCBtYXRoaW5nIHRoZSBub3Jt YWwgY29kZSBwYXRoLgorICAgICAgICAoLVtXZWJDb3JlU3luY2hyb25vdXNMb2FkZXIgY29ubmVj dGlvbjp3aWxsU2VuZFJlcXVlc3Q6cmVkaXJlY3RSZXNwb25zZTpdKTogUmVsZWFzZSBtX3VzZXIK KyAgICAgICAgYW5kIG1fcGFzcyBiZWZvcmUgb3ZlcndyaXRpbmcuCisgICAgICAgICgtW1dlYkNv cmVTeW5jaHJvbm91c0xvYWRlciBjb25uZWN0aW9uOmRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNo YWxsZW5nZTpdKTogRGl0dG8uCisKIDIwMDktMDUtMTMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVy c2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggYnVpbGQuCkluZGV4OiBXZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VIYW5kbGVNYWMubW0JKHJldmlzaW9uIDQz NjA4KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRsZU1hYy5t bQkod29ya2luZyBjb3B5KQpAQCAtMzUyLDcgKzM1Miw3IEBAIHZvaWQgUmVzb3VyY2VIYW5kbGU6 OmxvYWRSZXNvdXJjZVN5bmNocm8KICAgICAKICAgICBOU1VSTFJlcXVlc3QgKm5zUmVxdWVzdDsK ICAgICBpZiAoIXNob3VsZENvbnRlbnRTbmlmZlVSTChyZXF1ZXN0LnVybCgpKSkgewotICAgICAg ICBOU011dGFibGVVUkxSZXF1ZXN0ICptdXRhYmxlUmVxdWVzdCA9IFtyZXF1ZXN0Lm5zVVJMUmVx dWVzdCgpIG11dGFibGVDb3B5XTsKKyAgICAgICAgTlNNdXRhYmxlVVJMUmVxdWVzdCAqbXV0YWJs ZVJlcXVlc3QgPSBbW3JlcXVlc3QubnNVUkxSZXF1ZXN0KCkgbXV0YWJsZUNvcHldIGF1dG9yZWxl YXNlXTsKICAgICAgICAgd2tTZXROU1VSTFJlcXVlc3RTaG91bGRDb250ZW50U25pZmYobXV0YWJs ZVJlcXVlc3QsIE5PKTsKICAgICAgICAgbnNSZXF1ZXN0ID0gbXV0YWJsZVJlcXVlc3Q7CiAgICAg fSBlbHNlCkBAIC03OTgsNiArNzk4LDggQEAgdm9pZCBSZXNvdXJjZUhhbmRsZTo6cmVjZWl2ZWRD YW5jZWxsYXRpbwogCiAgICAgaWYgKHJlZGlyZWN0UmVzcG9uc2UpIHsKICAgICAgICAgLy8gVGFr ZSB1c2VyL3Bhc3Mgb3V0IG9mIHRoZSBVUkwuCisgICAgICAgIFttX3VzZXIgcmVsZWFzZV07Cisg ICAgICAgIFttX3Bhc3MgcmVsZWFzZV07CiAgICAgICAgIG1fdXNlciA9IFtbbV91cmwgdXNlcl0g Y29weV07CiAgICAgICAgIG1fcGFzcyA9IFtbbV91cmwgcGFzc3dvcmRdIGNvcHldOwogICAgICAg ICBpZiAobV91c2VyIHx8IG1fcGFzcykgewpAQCAtODI5LDYgKzgzMSw4IEBAIHZvaWQgUmVzb3Vy Y2VIYW5kbGU6OnJlY2VpdmVkQ2FuY2VsbGF0aW8KICAgICAgICAgV2ViQ29yZUNyZWRlbnRpYWxT dG9yYWdlOjpzZXQoY3JlZGVudGlhbCwgW2NoYWxsZW5nZSBwcm90ZWN0aW9uU3BhY2VdKTsKICAg ICAgICAgW1tjaGFsbGVuZ2Ugc2VuZGVyXSB1c2VDcmVkZW50aWFsOmNyZWRlbnRpYWwgZm9yQXV0 aGVudGljYXRpb25DaGFsbGVuZ2U6Y2hhbGxlbmdlXTsKICAgICAgICAgW2NyZWRlbnRpYWwgcmVs ZWFzZV07CisgICAgICAgIFttX3VzZXIgcmVsZWFzZV07CisgICAgICAgIFttX3Bhc3MgcmVsZWFz ZV07CiAgICAgICAgIG1fdXNlciA9IDA7CiAgICAgICAgIG1fcGFzcyA9IDA7CiAgICAgICAgIHJl dHVybjsK