257832 2023-06-07 14:20:24 -0700 [ iOS, macOS ] imported/w3c/web-platform-tests/html/rendering/the-details-element/summary-text-decoration.html is a constant ImageOnly failure 2024-11-23 18:26:40 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED DUPLICATE 157323 https://bugs.webkit.org/show_bug.cgi?id=227282 https://bugs.webkit.org/show_bug.cgi?id=258005 InRadar P2 Normal --- 252223 1 bharris9 bharris9 ahmad.saleem792 cdumez karlcow koivisto webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1960425 0 466629 bharris9 2023-06-07 14:20:24 -0700 Created attachment 466629 Image Diffs imported/w3c/web-platform-tests/html/rendering/the-details-element/summary-text-decoration.html is a constant ImageOnly Failure on iOS 16 and macOS. HISTORY: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Frendering%2Fthe-details-element%2Fsummary-text-decoration.html LINK to Image DIFFS: https://build.webkit.org/results/Apple-Ventura-Release-AppleSilicon-WK2-Tests/264943@main%20(3442)/imported/w3c/web-platform-tests/html/rendering/the-details-element/summary-text-decoration-diffs.html 1960426 1 webkit-bug-importer 2023-06-07 14:20:42 -0700 <rdar://problem/110421013> 1960428 2 bharris9 2023-06-07 14:29:43 -0700 I was able to replicate this failure on Ventura ToT as follows: run-webkit-tests --root imported/w3c/web-platform-tests/html/rendering/the-details-element/summary-text-decoration.html 1960429 3 bharris9 2023-06-07 14:35:32 -0700 Pull request: https://github.com/WebKit/WebKit/pull/14762 1960430 4 ews-feeder 2023-06-07 14:37:32 -0700 Test gardening commit 264957@main (2dd4f2cd5de8): <https://commits.webkit.org/264957@main> Reviewed commits have been landed. Closing PR #14762 and removing active labels. 1961240 5 ap 2023-06-12 22:22:51 -0700 This test was marked as failing since it was imported in 2020, but it was supposed to have been fixed in https://commits.webkit.org/264901@main, so the expectation was removed. EWS didn't tell us about this because bug 258005. 1961271 6 ahmad.saleem792 2023-06-13 01:41:14 -0700 (In reply to Alexey Proskuryakov from comment #5) > This test was marked as failing since it was imported in 2020, but it was > supposed to have been fixed in https://commits.webkit.org/264901@main, so > the expectation was removed. > > EWS didn't tell us about this because bug 258005. My commit was to introduce 'underline' (text decoration propogation), which was not done before and it seems to load fine when locally I did patch and since WPT had test coverage, I just enable the same tests but it seems 'underline' we get but it might cause 'bullet' or 'triangle' to get squashed. Should we revert our patch or consider it is just one test with 'ImageOnly failure'? and undo expectation? 2077343 7 ahmad.saleem792 2024-11-23 18:26:15 -0800 Fixed by bug 157323 ^ It removed expectation and there is no issue at all. 2077344 8 ahmad.saleem792 2024-11-23 18:26:40 -0800 *** This bug has been marked as a duplicate of bug 157323 *** 466629 2023-06-07 14:20:24 -0700 2023-06-07 14:20:24 -0700 Image Diffs summary-text-decoration-diffs.html text/html 6451 bharris9 PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPHRpdGxlPmltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvaHRtbC9yZW5kZXJpbmcvdGhlLWRldGFpbHMtZWxlbWVudC9zdW1tYXJ5LXRl eHQtZGVjb3JhdGlvbi5odG1sPC90aXRsZT4KPHN0eWxlPgogICAgOnJvb3QgewogICAgICAgIGNv bG9yLXNjaGVtZTogZGFyayBsaWdodDsKICAgIH0KCiAgICBib2R5IHsKICAgICAgICBmb250LWZh bWlseTogSGVsdmV0aWNhLCBzYW5zLXNlcmlmOwogICAgICAgIGZvbnQtc2l6ZTogMTFwdDsKICAg IH0KCiAgICAuaW1hZ2VDb250YWluZXIgewogICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAg ICAgICBtYXJnaW46IDEwcHg7CiAgICAgICAgb3V0bGluZTogMTBweCBzb2xpZCBzaWx2ZXI7CiAg ICAgICAgbWluLXdpZHRoOiAzMDBweDsKICAgICAgICBtaW4taGVpZ2h0OiAxNTBweDsKICAgIH0K ICAgIAogICAgLmltYWdlQ29udGFpbmVyID4gaW1nIHsKICAgICAgICBkaXNwbGF5OiBibG9jazsK ICAgIH0KCiAgICAuY29udHJvbHMgewogICAgICAgIG1hcmdpbi1ib3R0b206IDE1cHg7CiAgICAg ICAgcGFkZGluZzogMTBweDsKICAgIH0KICAgIAogICAgLnBpeGVsLWRpZmYgewogICAgICAgIGZv bnQtc2l6ZTogMTBwdDsKICAgICAgICBmb250LWZhbWlseTogLWFwcGxlLXN5c3RlbTsKICAgIH0K ICAgIAogICAgLnBpeGVsLWRpZmYgPiB0ZDpmaXJzdC1jaGlsZCB7CiAgICAgICAgdGV4dC1hbGln bjogcmlnaHQ7CiAgICB9CiAgICAKICAgIC5oaWRkZW4gewogICAgICAgIGRpc3BsYXk6IG5vbmU7 CiAgICB9CiAgICAKICAgIC5jb250cm9scyBidXR0b24gewogICAgICAgIHdpZHRoOiAxMmVtOwog ICAgICAgIHBhZGRpbmc6IDRweDsKICAgIH0KICAgIAogICAgLmNvbnRyb2xzIHRkIHsKICAgICAg ICBwYWRkaW5nOiA1cHggMTBweDsKICAgIH0KICAgIAogICAgLmNvbnRyb2xzIGxhYmVsIHsKICAg ICAgICBmb250LWZhbWlseTogLWFwcGxlLXN5c3RlbTsKICAgICAgICBmb250LXNpemU6IDEycHg7 CiAgICB9CiAgICAKICAgIGJ1dHRvbi5zZWxlY3RlZCB7CiAgICAgICAgdGV4dC1kZWNvcmF0aW9u OiB1bmRlcmxpbmU7CiAgICB9Cjwvc3R5bGU+CjwvaGVhZD4KPGJvZHk+Cjx0YWJsZSBjbGFzcz0i Y29udHJvbHMiPgogICAgPHRyIGNsYXNzPSJwaXhlbC1kaWZmIj4KICAgICAgICA8dGQ+VGVzdCBw YXRoOjwvdGQ+CiAgICAgICAgPHRkPmltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRt bC9yZW5kZXJpbmcvdGhlLWRldGFpbHMtZWxlbWVudC9zdW1tYXJ5LXRleHQtZGVjb3JhdGlvbi5o dG1sPC90ZD4KICAgIDwvdHI+CiAgICA8dHIgY2xhc3M9InBpeGVsLWRpZmYgIj4KICAgICAgICA8 dGQ+UGl4ZWwgZGlmZmVyZW5jZTo8L3RkPgogICAgICAgIDx0ZD4wLjE0JTwvdGQ+CiAgICA8L3Ry PgogICAgPHRyIGNsYXNzPSJwaXhlbC1kaWZmICI+CiAgICAgICAgPHRkPkZ1enp5IG1hdGNoOjwv dGQ+CiAgICAgICAgPHRkPjxzcGFuPkNsaWNrIHRvIHRvZ2dsZSBiZXR3ZWVuIHJhbmdlcyBhbmQg dmFsdWVzPC9zcGFuPjxicj48aW5wdXQgdHlwZT0iYnV0dG9uIiBpZD0iZnV6enktbWF0Y2gtZGF0 YSIgb25jbGljaz0idG9nZ2xlRnV6enlNYXRjaFN0cmluZygpIj48L3RkPgogICAgICAgIDx0ZCBp ZD0iZnV6enktbWF0Y2gtZm9ybSIgY29sc3Bhbj0yPjxpbnB1dCB0eXBlPSJidXR0b24iIHZhbHVl PSJDb3B5IHRvIGNsaXBib2FyZCBhcyA8bWV0YT4gdGFnIiBvbmNsaWNrPSJjb3B5VG9DbGlwYm9h cmRGdXp6eU1ldGFUYWcoKSI+PC90ZD4KICAgIDwvdHI+CiAgICA8dHI+CiAgICAgICAgPHRkPjwv dGQ+CiAgICAgICAgPHRkPjxidXR0b24gaWQ9ImV4cGVjdGVkLWxhYmVsIiBkYXRhLXR5cGU9ImV4 cGVjdGVkIiBvbmNsaWNrPSJzd2l0Y2hUb0ltYWdlKHRoaXMpIj5FeHBlY3RlZCBJbWFnZTwvYnV0 dG9uPjwvdGQ+CiAgICAgICAgPHRkPjxidXR0b24gaWQ9ImFjdHVhbC1sYWJlbCIgZGF0YS10eXBl PSJhY3R1YWwiIG9uY2xpY2s9InN3aXRjaFRvSW1hZ2UodGhpcykiPkFjdHVhbCBJbWFnZTwvYnV0 dG9uPjwvdGQ+CiAgICAgICAgPHRkPjxidXR0b24gaWQ9ImRpZmYtbGFiZWwiIGRhdGEtdHlwZT0i ZGlmZiIgb25jbGljaz0ic3dpdGNoVG9JbWFnZSh0aGlzKSI+RGlmZiBJbWFnZTwvYnV0dG9uPjwv dGQ+CiAgICA8L3RyPgogICAgPHRyPgogICAgICAgIDx0ZD48aW5wdXQgdHlwZT0iY2hlY2tib3gi IGlkPSJhbmltYXRlIiBvbmNoYW5nZT0idG9nZ2xlQW5pbWF0ZSgpIiBjaGVja2VkPjxsYWJlbCBm b3I9ImFuaW1hdGUiPkFuaW1hdGU6PC9sYWJlbD48L3RkPgogICAgICAgIDx0ZD48aW5wdXQgdHlw ZT0iY2hlY2tib3giIGlkPSJjeWNsZS1leHBlY3RlZCIgb25jaGFuZ2U9InVwZGF0ZUltYWdlQ3lj bGUoKSIgY2hlY2tlZD48bGFiZWwgZm9yPSJjeWNsZS1leHBlY3RlZCI+RXhwZWN0ZWQ8L2xhYmVs PjwvdGQ+CiAgICAgICAgPHRkPjxpbnB1dCB0eXBlPSJjaGVja2JveCIgaWQ9ImN5Y2xlLWFjdHVh bCIgb25jaGFuZ2U9InVwZGF0ZUltYWdlQ3ljbGUoKSIgY2hlY2tlZD48bGFiZWwgZm9yPSJjeWNs ZS1hY3R1YWwiPkFjdHVhbDwvbGFiZWw+PC90ZD4KICAgICAgICA8dGQ+PGlucHV0IHR5cGU9ImNo ZWNrYm94IiBpZD0iY3ljbGUtZGlmZiIgb25jaGFuZ2U9InVwZGF0ZUltYWdlQ3ljbGUoKSI+PGxh YmVsIGZvcj0iY3ljbGUtZGlmZiI+RGlmZjwvbGFiZWw+PC90ZD4KICAgIDwvdHI+CjwvdGFibGU+ Cgo8ZGl2IGNsYXNzPSJpbWFnZUNvbnRhaW5lciIgZGF0YS1wcmVmaXg9InN1bW1hcnktdGV4dC1k ZWNvcmF0aW9uIj5Mb2FkaW5nLi4uPC9kaXY+CjxzY3JpcHQ+CmlmICh3aW5kb3cudGVzdFJ1bm5l cikKICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOwoKdmFyIGNvbnRhaW5lciA9IGRvY3VtZW50 LnF1ZXJ5U2VsZWN0b3IoJy5pbWFnZUNvbnRhaW5lcicpOwoKdmFyIGRhdGEgPSB7CiAgICAnZXhw ZWN0ZWQnIDogewogICAgICAgICdpbWFnZScgOiBwcmVsb2FkSW1hZ2UoY29udGFpbmVyLmdldEF0 dHJpYnV0ZSgnZGF0YS1wcmVmaXgnKSArICctZXhwZWN0ZWQucG5nJyksCiAgICAgICAgJ2xhYmVs JyA6IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdleHBlY3RlZC1sYWJlbCcpLAogICAgfSwKICAg ICdhY3R1YWwnIDogewogICAgICAgICdpbWFnZScgOiBwcmVsb2FkSW1hZ2UoY29udGFpbmVyLmdl dEF0dHJpYnV0ZSgnZGF0YS1wcmVmaXgnKSArICctYWN0dWFsLnBuZycpLAogICAgICAgICdsYWJl bCcgOiBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYWN0dWFsLWxhYmVsJyksCiAgICB9LAogICAg J2RpZmYnIDogewogICAgICAgICdpbWFnZScgOiBwcmVsb2FkSW1hZ2UoY29udGFpbmVyLmdldEF0 dHJpYnV0ZSgnZGF0YS1wcmVmaXgnKSArICctZGlmZi5wbmcnKSwKICAgICAgICAnbGFiZWwnIDog ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2RpZmYtbGFiZWwnKSwKICAgIH0sCn07Cgp2YXIgcHJl bG9hZGVkSW1hZ2VDb3VudCA9IDA7CgpmdW5jdGlvbiBwcmVsb2FkQ29tcGxldGUoKQp7CiAgICAr K3ByZWxvYWRlZEltYWdlQ291bnQ7CiAgICBpZiAocHJlbG9hZGVkSW1hZ2VDb3VudCA8IDMpCiAg ICAgICAgcmV0dXJuOwogICAgCiAgICBzaG93SW1hZ2UoZGF0YVsnYWN0dWFsJ10pOwogICAgdXBk YXRlSW1hZ2VDeWNsZSgpOwogICAgc3RhcnRDeWNsaW5nSW1hZ2VzKCk7Cn0KCmZ1bmN0aW9uIHBy ZWxvYWRJbWFnZSh1cmwpCnsKICAgIGltYWdlID0gbmV3IEltYWdlKCk7CiAgICBpbWFnZS5hZGRF dmVudExpc3RlbmVyKCdsb2FkJywgcHJlbG9hZENvbXBsZXRlKTsKICAgIGltYWdlLnNyYyA9IHVy bDsKICAgIHJldHVybiBpbWFnZTsKfQoKZnVuY3Rpb24gc3dpdGNoVG9JbWFnZShlbGVtZW50KQp7 CiAgICB2YXIgaW1hZ2VUeXBlID0gZWxlbWVudC5nZXRBdHRyaWJ1dGUoJ2RhdGEtdHlwZScpOwog ICAgc2hvd0ltYWdlKGRhdGFbaW1hZ2VUeXBlXSk7Cn0KCmZ1bmN0aW9uIHJlc2V0TGFiZWxzKCkK ewogICAgZm9yICh2YXIgaXRlbSBpbiBkYXRhKQogICAgICAgIGRhdGFbaXRlbV0ubGFiZWwuY2xh c3NMaXN0LnJlbW92ZSgnc2VsZWN0ZWQnKTsKfQoKZnVuY3Rpb24gc2hvd0ltYWdlKGNhdGVnb3J5 RGF0YSkKewogICAgY29udGFpbmVyLnJlcGxhY2VDaGlsZChjYXRlZ29yeURhdGEuaW1hZ2UsIGNv bnRhaW5lci5maXJzdENoaWxkKTsKICAgIAogICAgcmVzZXRMYWJlbHMoKTsKICAgIGNhdGVnb3J5 RGF0YS5sYWJlbC5jbGFzc0xpc3QuYWRkKCdzZWxlY3RlZCcpOwp9CgpmdW5jdGlvbiB1cGRhdGVJ bWFnZUN5Y2xlKCkKewogICAgZGF0YS5leHBlY3RlZC5jeWNsZSA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCdjeWNsZS1leHBlY3RlZCcpLmNoZWNrZWQ7CiAgICBkYXRhLmFjdHVhbC5jeWNsZSA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjeWNsZS1hY3R1YWwnKS5jaGVja2VkOwogICAgZGF0 YS5kaWZmLmN5Y2xlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2N5Y2xlLWRpZmYnKS5jaGVj a2VkOwp9CgpmdW5jdGlvbiBnZXRDdXJyZW50bHlTaG93aW5nSW1hZ2VUeXBlKCkKewogICAgZm9y ICh2YXIgaXRlbSBpbiBkYXRhKSB7CiAgICAgICAgaWYgKGRhdGFbaXRlbV0ubGFiZWwuY2xhc3NM aXN0LmNvbnRhaW5zKCdzZWxlY3RlZCcpKQogICAgICAgICAgICByZXR1cm4gaXRlbTsKICAgIH0K fQoKZnVuY3Rpb24gdG9nZ2xlQW5pbWF0ZSgpCnsKICAgIGlmIChkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnYW5pbWF0ZScpLmNoZWNrZWQpCiAgICAgICAgc3RhcnRDeWNsaW5nSW1hZ2VzKCk7CiAg ICBlbHNlCiAgICAgICAgc3RvcEN5Y2xpbmdJbWFnZXMoKTsKfQoKdmFyIGN5Y2xlSW50ZXJ2YWxJ RDsKZnVuY3Rpb24gc3RhcnRDeWNsaW5nSW1hZ2VzKCkKewogICAgc3RvcEN5Y2xpbmdJbWFnZXMo KTsKICAgIGN5Y2xlSW50ZXJ2YWxJRCA9IHdpbmRvdy5zZXRJbnRlcnZhbChjeWNsZUltYWdlcywg MjAwMCk7Cn0KCmZ1bmN0aW9uIHN0b3BDeWNsaW5nSW1hZ2VzKCkKewogICAgaWYgKGN5Y2xlSW50 ZXJ2YWxJRCkgewogICAgICAgIHdpbmRvdy5jbGVhckludGVydmFsKGN5Y2xlSW50ZXJ2YWxJRCk7 CiAgICAgICAgY3ljbGVJbnRlcnZhbElEID0gdW5kZWZpbmVkOwogICAgfQp9CgpmdW5jdGlvbiBj eWNsZUltYWdlcygpCnsKICAgIHZhciBjdXJyZW50SW1hZ2UgPSBnZXRDdXJyZW50bHlTaG93aW5n SW1hZ2VUeXBlKCk7CiAgICB2YXIgb3JkZXIgPSBbJ2V4cGVjdGVkJywgJ2FjdHVhbCcsICdkaWZm J107CiAgICB2YXIgaW5kZXggPSBvcmRlci5pbmRleE9mKGN1cnJlbnRJbWFnZSk7CiAgICAKICAg IHZhciBjdXJySW5kZXggPSAoaW5kZXggKyAxKSAlIG9yZGVyLmxlbmd0aDsKICAgIGRvIHsKICAg ICAgICB2YXIgdHlwZSA9IG9yZGVyW2N1cnJJbmRleF07CiAgICAgICAgaWYgKGRhdGFbdHlwZV0u Y3ljbGUpCiAgICAgICAgICAgIGJyZWFrOwogICAgICAgIAogICAgICAgIGN1cnJJbmRleCA9IChj dXJySW5kZXggKyAxKSAlIG9yZGVyLmxlbmd0aDsKICAgIH0gd2hpbGUgKGN1cnJJbmRleCAhPSBp bmRleCk7CgogICAgc2hvd0ltYWdlKGRhdGFbb3JkZXJbY3VyckluZGV4XV0pOwp9CgpmdW5jdGlv biBjb3B5VG9DbGlwYm9hcmRGdXp6eU1ldGFUYWcoKSB7CiAgICB2YXIgbWV0YVRhZyA9IGA8bWV0 YSBuYW1lPSJmdXp6eSIgY29udGVudD0iJHtkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZnV6enkt bWF0Y2gtZGF0YSIpLnZhbHVlfSIgLz5gOwogICAgbmF2aWdhdG9yLmNsaXBib2FyZC53cml0ZVRl eHQobWV0YVRhZyk7CgogICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImZ1enp5LW1hdGNoLWZv cm0iKS5hcHBlbmQoIkNvcGllZCEgIik7Cn0KCm1heERpZmZlcmVuY2U9MjU1OyB0b3RhbFBpeGVs cz0xNjU4OwpiaXRNYXNrRm9yV2hldGhlclRvVXNlUmFuZ2VzID0gLTE7CmZ1bmN0aW9uIHRvZ2ds ZUZ1enp5TWF0Y2hTdHJpbmcoKSB7CiAgICBiaXRNYXNrRm9yV2hldGhlclRvVXNlUmFuZ2VzID0g KGJpdE1hc2tGb3JXaGV0aGVyVG9Vc2VSYW5nZXMgKyAxKSAlIDQ7CiAgICB2YXIgZnV6enlNYXRj aFN0cmluZyA9ICJtYXhEaWZmZXJlbmNlPSI7CiAgICBpZiAoYml0TWFza0ZvcldoZXRoZXJUb1Vz ZVJhbmdlcyAmIDB4MikKICAgICAgICBmdXp6eU1hdGNoU3RyaW5nICs9ICIwLSI7CiAgICBmdXp6 eU1hdGNoU3RyaW5nICs9IGAke21heERpZmZlcmVuY2V9OyB0b3RhbFBpeGVscz1gOwogICAgaWYg KGJpdE1hc2tGb3JXaGV0aGVyVG9Vc2VSYW5nZXMgJiAweDEpCiAgICAgICAgZnV6enlNYXRjaFN0 cmluZyArPSAiMC0iOwogICAgZnV6enlNYXRjaFN0cmluZyArPSB0b3RhbFBpeGVsczsKCiAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZnV6enktbWF0Y2gtZGF0YSIpLnZhbHVlID0gZnV6enlN YXRjaFN0cmluZzsKfQp0b2dnbGVGdXp6eU1hdGNoU3RyaW5nKCk7Cgo8L3NjcmlwdD4KPC9ib2R5 Pgo8L2h0bWw+Cg==