25782 2009-05-14 02:01:21 -0700 Allow custom memory allocation control in JavaScriptCore 2009-06-04 11:35:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 zoltan webkit-unassigned oldest_to_newest 121232 0 zoltan 2009-05-14 02:01:21 -0700 FastAllocBase class landed in the trunk (bug #20422) at r42344. Now we have to continue the work with inherite some classes from it. TODOs: - We have to inherit every classes from FastAllocBase which has been instantiated by 'new'. - We have to put FastAllocBase into inheritance tree as far up as possible. First I file a patch for one class called HashTable. After it'll be in the trunk I'll file a list which classes instantiated by 'new'. 121233 1 30319 zoltan 2009-05-14 02:02:18 -0700 Created attachment 30319 proposed patch for HashTable 122604 2 30319 mjs 2009-05-22 01:18:47 -0700 Comment on attachment 30319 proposed patch for HashTable r=me 123202 3 bfulgham 2009-05-26 15:28:04 -0700 Landed in @r44161. 123978 4 zoltan 2009-06-02 06:15:17 -0700 I've analysed the source and noticed that I inherited the wrong HashTable class. Sorry, I've filed a new patch which contains the correction of the mistake and the allocation support for the 'real' HashTable. Details in the patch. 123979 5 30868 zoltan 2009-06-02 06:16:12 -0700 Created attachment 30868 proposed patch for HashTable struct 123995 6 zoltan 2009-06-02 09:20:40 -0700 Simplier method is to change 'new' call to fastNew, and 'delete' to fastDelete. (In this case I need to modify only where HashTable instantiated by 'new' and destructed with delete. JSGlobalData.cpp:106-112) If you wish I could attach a patch with this solution. 124005 7 30871 zoltan 2009-06-02 10:23:56 -0700 Created attachment 30871 proposed patch for HashTable struct Based on Darin's https://bugs.webkit.org/show_bug.cgi?id=20422#c36 comment, I filed the fastNew/fastDelete solution. 124033 8 30871 darin 2009-06-02 12:25:02 -0700 Comment on attachment 30871 proposed patch for HashTable struct r=me 124233 9 bfulgham 2009-06-03 15:50:50 -0700 Assign for landing. 124330 10 bfulgham 2009-06-04 10:30:57 -0700 Landed in @r44417. 30319 2009-05-14 02:02:18 -0700 2009-05-22 01:18:47 -0700 proposed patch for HashTable HashTable.patch text/plain 1411 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQzNjg4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDUtMTQgIFpvbHRhbiBI b3J2YXRoICA8aG9ydmF0aC56b2x0YW4uNkBzdHVkLnUtc3plZ2VkLmh1PgorCisJUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKwlJbmhlcml0ZSBIYXNoVGFibGUgZnJvbSBGYXN0QWxsb2NC YXNlLCBiZWNhdXNlIGl0IGhhcyBiZWVuIGluc3RhbnRpYXRlZCBieQorCSduZXcnIGluIEphdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxEYXRhLmNwcC4KKworICAgICAgICAqIHd0Zi9IYXNo VGFibGUuaDoKKwogMjAwOS0wNS0xMyAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBKYXZh U2NyaXB0Q29yZS93dGYvSGFzaFRhYmxlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUv d3RmL0hhc2hUYWJsZS5oCShyZXZpc2lvbiA0MzY4NykKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9I YXNoVGFibGUuaAkod29ya2luZyBjb3B5KQpAQCAtMjUsNiArMjUsNyBAQAogI2luY2x1ZGUgIkZh c3RNYWxsb2MuaCIKICNpbmNsdWRlICJIYXNoVHJhaXRzLmgiCiAjaW5jbHVkZSA8d3RmL0Fzc2Vy dGlvbnMuaD4KKyNpbmNsdWRlIDx3dGYvRmFzdEFsbG9jQmFzZS5oPgogI2luY2x1ZGUgPHd0Zi9U aHJlYWRpbmcuaD4KIAogbmFtZXNwYWNlIFdURiB7CkBAIC0yODAsNyArMjgxLDcgQEAgbmFtZXNw YWNlIFdURiB7CiAgICAgfTsKIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIEtleSwgdHlwZW5hbWUg VmFsdWUsIHR5cGVuYW1lIEV4dHJhY3RvciwgdHlwZW5hbWUgSGFzaEZ1bmN0aW9ucywgdHlwZW5h bWUgVHJhaXRzLCB0eXBlbmFtZSBLZXlUcmFpdHM+Ci0gICAgY2xhc3MgSGFzaFRhYmxlIHsKKyAg ICBjbGFzcyBIYXNoVGFibGUgOiBwdWJsaWMgRmFzdEFsbG9jQmFzZSB7CiAgICAgcHVibGljOgog ICAgICAgICB0eXBlZGVmIEhhc2hUYWJsZUl0ZXJhdG9yPEtleSwgVmFsdWUsIEV4dHJhY3Rvciwg SGFzaEZ1bmN0aW9ucywgVHJhaXRzLCBLZXlUcmFpdHM+IGl0ZXJhdG9yOwogICAgICAgICB0eXBl ZGVmIEhhc2hUYWJsZUNvbnN0SXRlcmF0b3I8S2V5LCBWYWx1ZSwgRXh0cmFjdG9yLCBIYXNoRnVu Y3Rpb25zLCBUcmFpdHMsIEtleVRyYWl0cz4gY29uc3RfaXRlcmF0b3I7Cg== 30868 2009-06-02 06:16:12 -0700 2009-06-02 10:23:56 -0700 proposed patch for HashTable struct hashtable.patch text/plain 4078 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ0MzU2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMDktMDYtMDIgIFpvbHRhbiBI b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSGFzaFRhYmxlIGNsYXNzIChKYXZhU2NyaXB0Q29y ZS93dGYvSGFzaFRhYmxlLmgpIGRvZXNuJ3QgaW5zdGFudGlhdGVkIGJ5ICduZXcnLCBzbyAKKyAg ICAgICAgaW5oZXJpdGFuY2Ugd2FzIHJlbW92ZWQuIEhhc2hUYWJsZSBzdHJ1Y3QgaGFzIGJlZW4g aW5zdGFudGlhdGVkIGJ5IG9wZXJhdG9yIG5ldyBpbgorICAgICAgICBKU0dsb2JhbERhdGEuY3Bw OjEwNiwgdGhlIHN0cnVjdCBkZWZpbml0aW9uIGlzIGluIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUv TG9va3VwLmg6MTAwLgorCisgICAgICAgIFN0cnVjdCB3aXRoIGluaGVyaXRhbmNlIGlzIG5vIGxv bmdlciBQT0QsIHNvIGNhbm5vdCBiZSBpbml0aWFsaXplZCB3aXRoIEMtc3R5bGUKKyAgICAgICAg aW5pdGlhbGl6ZXIgbGlzdC4gSXQgY2F1c2VzIGNvbXBpbGUgZXJyb3IsIHNvIG5ldy9kZWxldGUg b3BlcmF0b3JzIGhhcyBiZWVuIGFkZGVkIAorICAgICAgICBtYW51YWxseSB0byB0aGUgSGFzaFRh YmxlIHN0cnVjdCBpbXBsZW1lbnRhdGlvbi4KKworICAgICAgICAqIGludGVycHJldGVyL0ludGVy cHJldGVyLmg6CisgICAgICAgICogcnVudGltZS9Mb29rdXAuaDoKKyAgICAgICAgKEpTQzo6SGFz aFRhYmxlOjpvcGVyYXRvciBuZXcpOgorICAgICAgICAoSlNDOjpIYXNoVGFibGU6Om9wZXJhdG9y IGRlbGV0ZSk6CisgICAgICAgIChKU0M6Okhhc2hUYWJsZTo6b3BlcmF0b3IgbmV3W10pOgorICAg ICAgICAoSlNDOjpIYXNoVGFibGU6Om9wZXJhdG9yIGRlbGV0ZVtdKToKKyAgICAgICAgKiB3dGYv SGFzaFRhYmxlLmg6CisKIDIwMDktMDYtMDIgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91 Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciAiPj4iIEh1bnQuCklu ZGV4OiBKYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIEphdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmgJKHJldmlzaW9uIDQ0 MzU2KQorKysgSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuaAkod29ya2lu ZyBjb3B5KQpAQCAtMzUsNiArMzUsNyBAQAogI2luY2x1ZGUgIkpTT2JqZWN0LmgiCiAjaW5jbHVk ZSAiT3Bjb2RlLmgiCiAjaW5jbHVkZSAiUmVnaXN0ZXJGaWxlLmgiCisjaW5jbHVkZSA8d3RmL0Zh c3RBbGxvY0Jhc2UuaD4KICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogCiBuYW1lc3BhY2UgSlND IHsKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvTG9va3VwLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g SmF2YVNjcmlwdENvcmUvcnVudGltZS9Mb29rdXAuaAkocmV2aXNpb24gNDQzNTYpCisrKyBKYXZh U2NyaXB0Q29yZS9ydW50aW1lL0xvb2t1cC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw2ICsyOCw3 IEBACiAjaW5jbHVkZSAiUHJvcGVydHlTbG90LmgiCiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNs dWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgorI2luY2x1ZGUgPHd0Zi9GYXN0QWxsb2NCYXNlLmg+CiAK IG5hbWVzcGFjZSBKU0MgewogCkBAIC0xMzIsNiArMTMzLDM1IEBAIG5hbWVzcGFjZSBKU0Mgewog ICAgICAgICAgICAgcmV0dXJuIGVudHJ5KGlkZW50aWZpZXIpOwogICAgICAgICB9CiAKKyAgICAg ICAgLy8gQmVjYXVzZSBvZiBjdXN0b20gYWxsb2NhdG9yIHN1cHBvcnQsIHdlIG5lZWQgdG8gYWRk IG9wZXJhdG9ycyBtYW51YWxseS4gV2UgY2FuJ3QKKyAgICAgICAgLy8gdXNlIGluaGVyaXRhbmNl IGZyb20gRmFzdEFsbG9jQmFzZSBiZWNhdXNlIGNsYXNzIHdpdGggaW5oZXJpdGFuY2UgaXMgbm8g bG9uZ2VyIFBPRAorICAgICAgICAvLyBhbmQgY2Fubm90IGJlIGluaXRhbGl6ZWQgd2l0aCB3aXRo IGEgQy1zdHlsZSBpbml0aWFsaXplciBsaXN0LiAoQ29tcGlsZSBlcnJvcikKKyAgICAgICAgdm9p ZCogb3BlcmF0b3IgbmV3KHNpemVfdCBzaXplKQorICAgICAgICB7CisgICAgICAgICAgICB2b2lk KiBwID0gZmFzdE1hbGxvYyhzaXplKTsKKyAgICAgICAgICAgIFdURjo6ZmFzdE1hbGxvY01hdGNo VmFsaWRhdGVNYWxsb2MocCwgV1RGOjpJbnRlcm5hbDo6QWxsb2NUeXBlQ2xhc3NOZXcpOworICAg ICAgICAgICAgcmV0dXJuIHA7CisgICAgICAgIH0KKworICAgICAgICB2b2lkIG9wZXJhdG9yIGRl bGV0ZSh2b2lkKiBwKQorICAgICAgICB7CisgICAgICAgICAgICBXVEY6OmZhc3RNYWxsb2NNYXRj aFZhbGlkYXRlRnJlZShwLCBXVEY6OkludGVybmFsOjpBbGxvY1R5cGVDbGFzc05ldyk7CisgICAg ICAgICAgICBmYXN0RnJlZShwKTsKKyAgICAgICAgfQorCisgICAgICAgIHZvaWQqIG9wZXJhdG9y IG5ld1tdKHNpemVfdCBzaXplKQorICAgICAgICB7CisgICAgICAgICAgICB2b2lkKiBwID0gZmFz dE1hbGxvYyhzaXplKTsKKyAgICAgICAgICAgIFdURjo6ZmFzdE1hbGxvY01hdGNoVmFsaWRhdGVN YWxsb2MocCwgV1RGOjpJbnRlcm5hbDo6QWxsb2NUeXBlQ2xhc3NOZXdBcnJheSk7CisgICAgICAg ICAgICByZXR1cm4gcDsKKyAgICAgICAgfQorCisgICAgICAgIHZvaWQgb3BlcmF0b3IgZGVsZXRl W10odm9pZCogcCkKKyAgICAgICAgeworICAgICAgICAgICAgV1RGOjpmYXN0TWFsbG9jTWF0Y2hW YWxpZGF0ZUZyZWUocCwgV1RGOjpJbnRlcm5hbDo6QWxsb2NUeXBlQ2xhc3NOZXdBcnJheSk7Cisg ICAgICAgICAgICBmYXN0RnJlZShwKTsKKyAgICAgICAgfQorCiAgICAgcHJpdmF0ZToKICAgICAg ICAgQUxXQVlTX0lOTElORSBjb25zdCBIYXNoRW50cnkqIGVudHJ5KGNvbnN0IElkZW50aWZpZXIm IGlkZW50aWZpZXIpIGNvbnN0CiAgICAgICAgIHsKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9I YXNoVGFibGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvSGFzaFRhYmxlLmgJ KHJldmlzaW9uIDQ0MzU2KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL0hhc2hUYWJsZS5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0yMyw3ICsyMyw2IEBACiAjZGVmaW5lIFdURl9IYXNoVGFibGVfaAogCiAj aW5jbHVkZSAiRmFzdE1hbGxvYy5oIgotI2luY2x1ZGUgIkZhc3RBbGxvY0Jhc2UuaCIKICNpbmNs dWRlICJIYXNoVHJhaXRzLmgiCiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRl IDx3dGYvVGhyZWFkaW5nLmg+CkBAIC0yODEsNyArMjgwLDcgQEAgbmFtZXNwYWNlIFdURiB7CiAg ICAgfTsKIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIEtleSwgdHlwZW5hbWUgVmFsdWUsIHR5cGVu YW1lIEV4dHJhY3RvciwgdHlwZW5hbWUgSGFzaEZ1bmN0aW9ucywgdHlwZW5hbWUgVHJhaXRzLCB0 eXBlbmFtZSBLZXlUcmFpdHM+Ci0gICAgY2xhc3MgSGFzaFRhYmxlIDogcHVibGljIEZhc3RBbGxv Y0Jhc2UgeworICAgIGNsYXNzIEhhc2hUYWJsZSB7CiAgICAgcHVibGljOgogICAgICAgICB0eXBl ZGVmIEhhc2hUYWJsZUl0ZXJhdG9yPEtleSwgVmFsdWUsIEV4dHJhY3RvciwgSGFzaEZ1bmN0aW9u cywgVHJhaXRzLCBLZXlUcmFpdHM+IGl0ZXJhdG9yOwogICAgICAgICB0eXBlZGVmIEhhc2hUYWJs ZUNvbnN0SXRlcmF0b3I8S2V5LCBWYWx1ZSwgRXh0cmFjdG9yLCBIYXNoRnVuY3Rpb25zLCBUcmFp dHMsIEtleVRyYWl0cz4gY29uc3RfaXRlcmF0b3I7Cg== 30871 2009-06-02 10:23:56 -0700 2009-06-02 12:25:02 -0700 proposed patch for HashTable struct hashtable.patch text/plain 0 zoltan