25769 2009-05-13 17:04:44 -0700 Fix accessibility warnings on GTK 2009-07-22 15:47:21 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach webkit-unassigned laszlo.gombos oldest_to_newest 121165 0 cfleizach 2009-05-13 17:04:44 -0700 here are the warnings this patch will try to fix ../../WebCore/page/AccessibilityTable.h:66: warning: type qualifiers ignored on function return type ../../WebCore/page/AccessibilityTable.h:67: warning: type qualifiers ignored on function return type ../../WebCore/page/AccessibilityRenderObject.cpp:2118: warning: ‘WebCore::createARIARoleMap()::RoleEntry’ declared with greater visibility than the type of its field ‘WebCore::createARIARoleMap()::RoleEntry::ariaRole’ ../../WebCore/page/AccessibilityTable.h:66: warning: type qualifiers ignored on function return type ../../WebCore/page/AccessibilityTable.h:67: warning: type qualifiers ignored on function return type ../../WebCore/page/AccessibilityTable.cpp:353: warning: type qualifiers ignored on function return type ../../WebCore/page/AccessibilityTable.cpp:361: warning: type qualifiers ignored on function return type ../../WebCore/page/AccessibilityTable.h:66: warning: type qualifiers ignored on function return type ../../WebCore/page/AccessibilityTable.h:67: warning: type qualifiers ignored on function return type ../../WebCore/page/AccessibilityTable.h:66: warning: type qualifiers ignored on function return type ../../WebCore/page/AccessibilityTable.h:67: warning: type qualifiers ignored on function return type 121170 1 30301 cfleizach 2009-05-13 17:13:36 -0700 Created attachment 30301 patch 121203 2 30301 mrowe 2009-05-13 19:47:31 -0700 Comment on attachment 30301 patch This isn't correct. The warnings are saying that it doesn't make sense for the return type of a function to be "const unsigned", such as in "const unsigned columnCount();". Should that perhaps be "unsigned columnCount() const;"? 121209 3 cfleizach 2009-05-13 20:47:13 -0700 yes that sounds correct 121356 4 30350 cfleizach 2009-05-14 12:34:29 -0700 Created attachment 30350 patch updated patch based on review can't make columnCount into unsigned columnCount() const because it needs to call addChildren(), which is not const 121423 5 30350 zecke 2009-05-14 20:43:09 -0700 Comment on attachment 30350 patch > Index: WebCore/page/AccessibilityRenderObject.cpp > =================================================================== > --- WebCore/page/AccessibilityRenderObject.cpp (revision 43716) > +++ WebCore/page/AccessibilityRenderObject.cpp (working copy) > @@ -2116,6 +2116,7 @@ typedef HashMap<String, AccessibilityRol > static const ARIARoleMap& createARIARoleMap() > { > struct RoleEntry { > + public: Isn't a struct public by default? 121426 6 cfleizach 2009-05-14 20:47:53 -0700 you'd think, but what does this warning mean then ‘WebCore::createARIARoleMap()::RoleEntry’ declared with greater visibility than the type of its field 121665 7 mrowe 2009-05-16 20:17:15 -0700 *** Bug 25838 has been marked as a duplicate of this bug. *** 121666 8 30350 darin 2009-05-16 20:35:59 -0700 Comment on attachment 30350 patch > { > struct RoleEntry { > + public: > String ariaRole; > AccessibilityRole webcoreRole; > }; This change does not make sense. In a struct, everything is public by default and this should have no effect. I have no idea why gcc is warning about this, but I do not think this is the fix. > Index: WebCore/page/AccessibilityTable.cpp > =================================================================== > --- WebCore/page/AccessibilityTable.cpp (revision 43716) > +++ WebCore/page/AccessibilityTable.cpp (working copy) > @@ -350,7 +350,7 @@ void AccessibilityTable::cells(Accessibi > } > } > > -const unsigned AccessibilityTable::columnCount() > +unsigned AccessibilityTable::columnCount() > { > if (!hasChildren()) > addChildren(); > @@ -358,7 +358,7 @@ const unsigned AccessibilityTable::colum > return m_columns.size(); > } > > -const unsigned AccessibilityTable::rowCount() > +unsigned AccessibilityTable::rowCount() > { > if (!hasChildren()) > addChildren(); > Index: WebCore/page/AccessibilityTable.h > =================================================================== > --- WebCore/page/AccessibilityTable.h (revision 43716) > +++ WebCore/page/AccessibilityTable.h (working copy) > @@ -63,8 +63,8 @@ public: > AccessibilityChildrenVector& columns(); > AccessibilityChildrenVector& rows(); > > - const unsigned columnCount(); > - const unsigned rowCount(); > + unsigned columnCount(); > + unsigned rowCount(); > > virtual String title() const; These changes are good. I'm saying r=me, but don't land that "public:" change -- it should have no effect. 121676 9 cfleizach 2009-05-16 23:17:24 -0700 alright, i won't make the struct change, which makes no sense (as does the warning). someone who compiles gtk can fix that 121687 10 darin 2009-05-17 09:49:45 -0700 (In reply to comment #9) > alright, i won't make the struct change, which makes no sense (as does the > warning). I think that warning indicates a bug in the new gcc. Someone should investigate more and report the bug to the gcc maintainers. 121688 11 darin 2009-05-17 09:50:35 -0700 http://trac.webkit.org/changeset/43810 30301 2009-05-13 17:13:36 -0700 2009-05-14 12:34:45 -0700 patch patch.txt text/plain 1956 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzY3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDUtMTMgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWcgMjU3Njk6IEZpeCBhY2Nlc3NpYmlsaXR5IHdhcm5pbmdzIG9uIEdUSworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU3NjkKKworICAgICAgICAq IHBhZ2UvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpj cmVhdGVBUklBUm9sZU1hcCk6CisgICAgICAgICogcGFnZS9BY2Nlc3NpYmlsaXR5VGFibGUuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVRhYmxlOjpjb2x1bW5Db3VudCk6Cisg ICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5VGFibGU6OnJvd0NvdW50KToKKwogMjAwOS0w NS0xMyAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1 ZyAyNTc1NTogSW1wbGVtZW50IEFSSUEgZ3JpZCByb2xlCkluZGV4OiBXZWJDb3JlL3BhZ2UvQWNj ZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0Fj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiA0MzY2OSkKKysrIFdlYkNvcmUv cGFnZS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjEx Niw2ICsyMTE2LDcgQEAgdHlwZWRlZiBIYXNoTWFwPFN0cmluZywgQWNjZXNzaWJpbGl0eVJvbAog c3RhdGljIGNvbnN0IEFSSUFSb2xlTWFwJiBjcmVhdGVBUklBUm9sZU1hcCgpCiB7CiAgICAgc3Ry dWN0IFJvbGVFbnRyeSB7CisgICAgcHVibGljOgogICAgICAgICBTdHJpbmcgYXJpYVJvbGU7CiAg ICAgICAgIEFjY2Vzc2liaWxpdHlSb2xlIHdlYmNvcmVSb2xlOwogICAgIH07CkluZGV4OiBXZWJD b3JlL3BhZ2UvQWNjZXNzaWJpbGl0eVRhYmxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bh Z2UvQWNjZXNzaWJpbGl0eVRhYmxlLmNwcAkocmV2aXNpb24gNDM2NjkpCisrKyBXZWJDb3JlL3Bh Z2UvQWNjZXNzaWJpbGl0eVRhYmxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzU1LDcgKzM1NSw3 IEBAIGNvbnN0IHVuc2lnbmVkIEFjY2Vzc2liaWxpdHlUYWJsZTo6Y29sdW0KICAgICBpZiAoIWhh c0NoaWxkcmVuKCkpCiAgICAgICAgIGFkZENoaWxkcmVuKCk7CiAgICAgCi0gICAgcmV0dXJuIG1f Y29sdW1ucy5zaXplKCk7ICAgIAorICAgIHJldHVybiAoY29uc3QgdW5zaWduZWQpbV9jb2x1bW5z LnNpemUoKTsgICAgCiB9CiAgICAgCiBjb25zdCB1bnNpZ25lZCBBY2Nlc3NpYmlsaXR5VGFibGU6 OnJvd0NvdW50KCkKQEAgLTM2Myw3ICszNjMsNyBAQCBjb25zdCB1bnNpZ25lZCBBY2Nlc3NpYmls aXR5VGFibGU6OnJvd0NvCiAgICAgaWYgKCFoYXNDaGlsZHJlbigpKQogICAgICAgICBhZGRDaGls ZHJlbigpOwogICAgIAotICAgIHJldHVybiBtX3Jvd3Muc2l6ZSgpOworICAgIHJldHVybiAoY29u c3QgdW5zaWduZWQpbV9yb3dzLnNpemUoKTsKIH0KICAgICAKIEFjY2Vzc2liaWxpdHlUYWJsZUNl bGwqIEFjY2Vzc2liaWxpdHlUYWJsZTo6Y2VsbEZvckNvbHVtbkFuZFJvdyh1bnNpZ25lZCBjb2x1 bW4sIHVuc2lnbmVkIHJvdykK 30350 2009-05-14 12:34:29 -0700 2009-05-16 20:35:59 -0700 patch patch.txt text/plain 2407 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzcxOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDUtMTQgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWcgMjU3Njk6IEZpeCBhY2Nlc3NpYmlsaXR5IHdhcm5pbmdzIG9uIEdUSworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU3NjkKKworICAgICAgICAq IHBhZ2UvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpj cmVhdGVBUklBUm9sZU1hcCk6CisgICAgICAgICogcGFnZS9BY2Nlc3NpYmlsaXR5VGFibGUuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVRhYmxlOjpjb2x1bW5Db3VudCk6Cisg ICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5VGFibGU6OnJvd0NvdW50KToKKyAgICAgICAg KiBwYWdlL0FjY2Vzc2liaWxpdHlUYWJsZS5oOgorCiAyMDA5LTA1LTE0ICBBbGV4ZXkgUHJvc2t1 cnlha292ICA8YXBAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxl ci4KSW5kZXg6IFdlYkNvcmUvcGFnZS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAJKHJl dmlzaW9uIDQzNzE2KQorKysgV2ViQ29yZS9wYWdlL0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Qu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTE2LDYgKzIxMTYsNyBAQCB0eXBlZGVmIEhhc2hNYXA8 U3RyaW5nLCBBY2Nlc3NpYmlsaXR5Um9sCiBzdGF0aWMgY29uc3QgQVJJQVJvbGVNYXAmIGNyZWF0 ZUFSSUFSb2xlTWFwKCkKIHsKICAgICBzdHJ1Y3QgUm9sZUVudHJ5IHsKKyAgICBwdWJsaWM6CiAg ICAgICAgIFN0cmluZyBhcmlhUm9sZTsKICAgICAgICAgQWNjZXNzaWJpbGl0eVJvbGUgd2ViY29y ZVJvbGU7CiAgICAgfTsKSW5kZXg6IFdlYkNvcmUvcGFnZS9BY2Nlc3NpYmlsaXR5VGFibGUuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9BY2Nlc3NpYmlsaXR5VGFibGUuY3BwCShyZXZp c2lvbiA0MzcxNikKKysrIFdlYkNvcmUvcGFnZS9BY2Nlc3NpYmlsaXR5VGFibGUuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0zNTAsNyArMzUwLDcgQEAgdm9pZCBBY2Nlc3NpYmlsaXR5VGFibGU6OmNl bGxzKEFjY2Vzc2liaQogICAgIH0KIH0KICAgICAKLWNvbnN0IHVuc2lnbmVkIEFjY2Vzc2liaWxp dHlUYWJsZTo6Y29sdW1uQ291bnQoKQordW5zaWduZWQgQWNjZXNzaWJpbGl0eVRhYmxlOjpjb2x1 bW5Db3VudCgpCiB7CiAgICAgaWYgKCFoYXNDaGlsZHJlbigpKQogICAgICAgICBhZGRDaGlsZHJl bigpOwpAQCAtMzU4LDcgKzM1OCw3IEBAIGNvbnN0IHVuc2lnbmVkIEFjY2Vzc2liaWxpdHlUYWJs ZTo6Y29sdW0KICAgICByZXR1cm4gbV9jb2x1bW5zLnNpemUoKTsgICAgCiB9CiAgICAgCi1jb25z dCB1bnNpZ25lZCBBY2Nlc3NpYmlsaXR5VGFibGU6OnJvd0NvdW50KCkKK3Vuc2lnbmVkIEFjY2Vz c2liaWxpdHlUYWJsZTo6cm93Q291bnQoKQogewogICAgIGlmICghaGFzQ2hpbGRyZW4oKSkKICAg ICAgICAgYWRkQ2hpbGRyZW4oKTsKSW5kZXg6IFdlYkNvcmUvcGFnZS9BY2Nlc3NpYmlsaXR5VGFi bGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvQWNjZXNzaWJpbGl0eVRhYmxlLmgJKHJl dmlzaW9uIDQzNzE2KQorKysgV2ViQ29yZS9wYWdlL0FjY2Vzc2liaWxpdHlUYWJsZS5oCSh3b3Jr aW5nIGNvcHkpCkBAIC02Myw4ICs2Myw4IEBAIHB1YmxpYzoKICAgICBBY2Nlc3NpYmlsaXR5Q2hp bGRyZW5WZWN0b3ImIGNvbHVtbnMoKTsKICAgICBBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3Im IHJvd3MoKTsKICAgICAKLSAgICBjb25zdCB1bnNpZ25lZCBjb2x1bW5Db3VudCgpOwotICAgIGNv bnN0IHVuc2lnbmVkIHJvd0NvdW50KCk7CisgICAgdW5zaWduZWQgY29sdW1uQ291bnQoKTsKKyAg ICB1bnNpZ25lZCByb3dDb3VudCgpOwogICAgIAogICAgIHZpcnR1YWwgU3RyaW5nIHRpdGxlKCkg Y29uc3Q7CiAgICAgCg==