257650 2023-06-02 09:12:16 -0700 Move WebCore::RunLoopObserver from WebCore/platform/cf to WebCore/platform 2023-06-13 07:33:21 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 257622 1 wenson_hsieh dpino dpino webkit-bug-importer oldest_to_newest 1959551 0 wenson_hsieh 2023-06-02 09:12:16 -0700 ...so that we can use it in (otherwise) platform-agnostic code. For now, this will only have a concrete implementation when `USE(CF)` is defined, but we could make it work with other ports (e.g. `GLIB_EVENT_LOOP` / `WINDOWS_EVENT_LOOP`) as well, in a followup. 1959556 1 wenson_hsieh 2023-06-02 09:27:53 -0700 Pull request: https://github.com/WebKit/WebKit/pull/14630 1960754 2 webkit-bug-importer 2023-06-09 09:13:17 -0700 <rdar://problem/110531974> 1961142 3 ews-feeder 2023-06-12 14:19:08 -0700 Committed 265089@main (a1236fc76789): <https://commits.webkit.org/265089@main> Reviewed commits have been landed. Closing PR #14630 and removing active labels. 1961246 4 dpino 2023-06-12 23:08:19 -0700 WebKitGTK Release post-commit build bot is failing after this patch landed: https://build.webkit.org/#/builders/41/builds/19615/steps/10/logs/stdio from /app/webkit/Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp:21, from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-51.cpp:1: /app/webkit/Source/WebCore/platform/VideoEncoderActiveConfiguration.h:35:12: error: field ‘codec’ has incomplete type ‘WTF::String’ 35 | String codec; | ^~~~~ It's a non-unified sources build error, `#include <WTFString.h>` is missing. 1961248 5 dpino 2023-06-12 23:08:59 -0700 Re-opening for pull request https://github.com/webkit/webkit/pull/14907 1961249 6 ews-feeder 2023-06-12 23:17:34 -0700 Committed 265105@main (90873fe270bf): <https://commits.webkit.org/265105@main> Reviewed commits have been landed. Closing PR #14907 and removing active labels.