257599 2023-06-01 02:47:59 -0700 [GStreamer] Do not activate and fill the gst GL context 2023-06-16 06:01:48 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=258199 Gtk, InRadar P2 Normal --- 1 cgarcia cgarcia bugs-noreply magomez webkit-bug-importer oldest_to_newest 1959309 0 cgarcia 2023-06-01 02:47:59 -0700 We currently create the GstGLContext wrapping the sharing context and it's activated in the main thread. That means, among other things, that gst sends all gl operations on the context to the main thread. Another side effect is that the sharing context is made current in the main thread and remains forever. 1959312 1 magomez 2023-06-01 02:54:52 -0700 Isn't gstreamer creating a new glcontext in its own thread (one of the many that it uses) and sending its gl operations there? I would expect so. 1959317 2 cgarcia 2023-06-01 02:59:23 -0700 Pull request: https://github.com/WebKit/WebKit/pull/14583 1959318 3 cgarcia 2023-06-01 03:00:49 -0700 (In reply to Miguel Gomez from comment #1) > Isn't gstreamer creating a new glcontext in its own thread (one of the many > that it uses) and sending its gl operations there? I would expect so. I don't think so, it does that when not creating a wrapping context. 1959329 4 cgarcia 2023-06-01 04:14:48 -0700 (In reply to Carlos Garcia Campos from comment #3) > (In reply to Miguel Gomez from comment #1) > > Isn't gstreamer creating a new glcontext in its own thread (one of the many > > that it uses) and sending its gl operations there? I would expect so. > > I don't think so, it does that when not creating a wrapping context. hmm, it's not created for the wrapped context, but another one is created apparently, so I was indeed wrong. I'll continue checking, the patch would still be needed, though to avoid using the sharing context. 1959330 5 cgarcia 2023-06-01 04:46:42 -0700 Ok, I see how it works now, our wrapped context is indeed only used as the sharing context of a gl context created by gst and used in a dedicated thread. I'm sorry for the noise, but this patch doesn't make sense as is. I'll close the PR for now. 1959332 6 cgarcia 2023-06-01 05:44:31 -0700 It's only used as a sharing context, so it doesn't need to be activated and filled. This ways we avoid making the sharing context the current one in the main thread forever. 1959333 7 cgarcia 2023-06-01 05:46:05 -0700 Pull request: https://github.com/WebKit/WebKit/pull/14586 1959511 8 ews-feeder 2023-06-02 01:50:42 -0700 Committed 264826@main (d4b48c265736): <https://commits.webkit.org/264826@main> Reviewed commits have been landed. Closing PR #14586 and removing active labels. 1959512 9 webkit-bug-importer 2023-06-02 01:51:17 -0700 <rdar://problem/110158904>