257580 2023-05-31 19:13:34 -0700 Make MachSendRight move-only 2023-07-26 13:52:37 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 257581 258608 1 mattwoodrow mattwoodrow kkinnunen webkit-bug-importer oldest_to_newest 1959222 0 mattwoodrow 2023-05-31 19:13:34 -0700 MachSendRight are expensive to copy, since it calls into the kernel. We generally don't want to do that by accident. We should make MachSendRight move-only, and switch callers to use the existing 'copySendRight' function where they do want a duplicate. 1959273 1 kkinnunen 2023-05-31 23:21:30 -0700 This extends to all the handle types that should unify their interface: UnixFileDescriptor Win32Handle MachSendRight If the copy constructor should be removed, the interface should be the same for all so that generic code can be written. E.g. ...::copy() or ...::duplicate() 1960473 2 webkit-bug-importer 2023-06-07 17:29:28 -0700 <rdar://problem/110431180> 1960474 3 mattwoodrow 2023-06-07 17:32:39 -0700 Pull request: https://github.com/WebKit/WebKit/pull/14771 1963961 4 kkinnunen 2023-06-27 23:45:09 -0700 maybe bug 258608 needs to be addressed before landing the patch 1968303 5 ews-feeder 2023-07-26 13:52:35 -0700 Committed 266327@main (aeb697fb2c06): <https://commits.webkit.org/266327@main> Reviewed commits have been landed. Closing PR #14771 and removing active labels.