<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>257519</bug_id>
          
          <creation_ts>2023-05-30 19:07:01 -0700</creation_ts>
          <short_desc>RemoteGraphicsContextGLProxy::initializeIPC makes a copy of the StreamServerConnection::Handle</short_desc>
          <delta_ts>2023-06-20 10:24:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=257528</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Matt Woodrow">mattwoodrow</reporter>
          <assigned_to name="Matt Woodrow">mattwoodrow</assigned_to>
          <cc>dino</cc>
    
    <cc>kbr</cc>
    
    <cc>kevin.chetty</cc>
    
    <cc>kkinnunen</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1958926</commentid>
    <comment_count>0</comment_count>
    <who name="Matt Woodrow">mattwoodrow</who>
    <bug_when>2023-05-30 19:07:01 -0700</bug_when>
    <thetext>The GPUConnectionToWebProcess::CreateGraphicsContextGL object&apos;s constructor doesn&apos;t actually move, so we end up making a copy for the IPC message.

The &apos;serverConnectionHandle&apos; instance is then still alive, and holding on to a MachSendRight.

waitUntilInitialized can then block (for the 30 second timeout) if the GPUP crashes, since notification of the crash doesn&apos;t happen until all send rights are destroyed (including the one on the stack).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1958927</commentid>
    <comment_count>1</comment_count>
    <who name="Matt Woodrow">mattwoodrow</who>
    <bug_when>2023-05-30 19:07:18 -0700</bug_when>
    <thetext>&lt;rdar://109720377&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1958928</commentid>
    <comment_count>2</comment_count>
    <who name="Matt Woodrow">mattwoodrow</who>
    <bug_when>2023-05-30 19:16:36 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/14519</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1959197</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-05-31 16:44:13 -0700</bug_when>
    <thetext>Committed 264766@main (50f865ffbe32): &lt;https://commits.webkit.org/264766@main&gt;

Reviewed commits have been landed. Closing PR #14519 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1962581</commentid>
    <comment_count>4</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2023-06-20 10:24:17 -0700</bug_when>
    <thetext>*** Bug 257890 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>