<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>257474</bug_id>
          
          <creation_ts>2023-05-30 02:52:55 -0700</creation_ts>
          <short_desc>[JSC] Implement isNaN / Number.isNaN in C++</short_desc>
          <delta_ts>2023-06-27 18:26:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=258592</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>257541</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1958702</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2023-05-30 02:52:55 -0700</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1958703</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-05-30 02:53:08 -0700</bug_when>
    <thetext>&lt;rdar://problem/109996676&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1958704</commentid>
    <comment_count>2</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2023-05-30 02:54:08 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/14473</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1958877</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-05-30 13:54:27 -0700</bug_when>
    <thetext>Committed 264697@main (5d3b2384ab2b): &lt;https://commits.webkit.org/264697@main&gt;

Reviewed commits have been landed. Closing PR #14473 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1959043</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2023-05-31 08:38:09 -0700</bug_when>
    <thetext>Re-opened since this is blocked by bug 257541</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1959046</commentid>
    <comment_count>5</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2023-05-31 08:41:17 -0700</bug_when>
    <thetext>This caused many assertion failures, reverting. E.g. https://build.webkit.org/results/Apple-Ventura-Debug-AppleSilicon-WK1-Tests/264701@main%20(2423)/results.html

DFG ASSERTION FAILED: AI-clobberize disagreement; AI says ClobberedStructures while clobberize says (Direct:[], Super:[])
./dfg/DFGCFAPhase.cpp(240) : void JSC::DFG::CFAPhase::performBlockCFA(JSC::DFG::BasicBlock *)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1959050</commentid>
    <comment_count>6</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2023-05-31 09:09:27 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/14538</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1959210</commentid>
    <comment_count>7</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-05-31 17:45:32 -0700</bug_when>
    <thetext>Committed 264768@main (c602f3ac3760): &lt;https://commits.webkit.org/264768@main&gt;

Reviewed commits have been landed. Closing PR #14538 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>