257414 2023-05-27 01:34:53 -0700 Remove stripLeadingAndTrailingHTMLSpaces() 2023-05-30 22:57:07 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 257438 255467 1 annevk annevk achristensen webkit-bug-importer oldest_to_newest 1958375 0 annevk 2023-05-27 01:34:53 -0700 Now that we have trim() this abstraction isn't really needed anymore. 1958376 1 webkit-bug-importer 2023-05-27 01:35:16 -0700 <rdar://problem/109923008> 1958379 2 annevk 2023-05-27 02:11:39 -0700 Unfortunately this is not a straightforward fix due to the existence of NSString. Is there a way to convert those to String or StringView so trim() can then be used? Search for HTMLSpace in https://github.com/WebKit/WebKit/blob/main/Source/WebCore/editing/cocoa/HTMLConverter.mm to see some instances of the problem. The other thing I noticed is that we're invoking this a lot before passing the string to the URL parser (often via completeURL()). However, the URL parser will trim all C0 control or space code points as per https://url.spec.whatwg.org/#concept-basic-url-parser (and as far as I can tell our implementation matches that). This means that we're doing the work twice. Perhaps someone can confirm I'm correct here and then I could create an initial PR that just removes these callers as they are redundant with the URL parser. 1958413 3 achristensen 2023-05-27 08:37:11 -0700 I'm pretty sure the calls to stripLeadingAndTrailingHTMLSpaces in HTMLConverter.mm are implicitly calling the WTF::String constructor from an NSString *. I'm pretty sure trimming space before passing to the URL parser is redundant work. 1958682 4 annevk 2023-05-30 00:46:37 -0700 Pull request: https://github.com/WebKit/WebKit/pull/14467 1958956 5 ews-feeder 2023-05-30 22:57:05 -0700 Committed 264713@main (ea527fa9c22d): <https://commits.webkit.org/264713@main> Reviewed commits have been landed. Closing PR #14467 and removing active labels.