25738 2009-05-12 15:37:42 -0700 Skia: CSS border style not cleared for SVG object 2009-05-12 21:47:12 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 rolandsteiner webkit-unassigned oldest_to_newest 120942 0 rolandsteiner 2009-05-12 15:37:42 -0700 [First reported here: http://code.google.com/p/chromium/issues/detail?id=9580] On Chrome (Skia), the SVG triangle rendered with the following HTML has a dotted outline. EXPECTED: The triangle should have a solid outline. <html xmlns="http://www.w3.org/1999/xhtml"> <head></head> <body> <div style="border: 4px dotted black; height:100px; width: 100px"></div> <svg width="300" height="300" version="1.1" xmlns="http://www.w3.org/2000/svg"> <polyline points="100,100 100,200 200,200 100,100" style="stroke:red;stroke-width:5;stroke-dasharray:none"/> </svg> </body> </html> 120957 1 30256 rolandsteiner 2009-05-12 17:43:06 -0700 Created attachment 30256 Patch: override with SolidStroke if no dash set I haven't (yet) added a new layout test for this patch due to the additional complications with different rendering styles for dotted lines on all platforms (cf. https://bugs.webkit.org/show_bug.cgi?id=25737) 120960 2 30256 eric 2009-05-12 18:26:24 -0700 Comment on attachment 30256 Patch: override with SolidStroke if no dash set I'm a good choice to review this. But you don't actually need to specify a reviewer for WebKit reviews. In fact, they'll often happen quicker if you don't. This change needs a test case as part of the patch. Otherwise, this looks fine. I'll add the test you provided when I land this (even though the test already passes for WebKit Mac). 120976 3 eric 2009-05-12 21:47:12 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/platform/mac/svg/custom/no-inherited-dashed-stroke-expected.checksum A LayoutTests/platform/mac/svg/custom/no-inherited-dashed-stroke-expected.png A LayoutTests/platform/mac/svg/custom/no-inherited-dashed-stroke-expected.txt A LayoutTests/svg/custom/no-inherited-dashed-stroke.xhtml M WebCore/ChangeLog M WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Committed r43608 30256 2009-05-12 17:43:06 -0700 2009-05-12 18:26:24 -0700 Patch: override with SolidStroke if no dash set svg.txt text/plain 1881 rolandsteiner SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzU5NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDUtMTIgIHJvbGFuZHN0ZWluZXIgIDxyb2xhbmRzdGVpbmVy QGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQnVnIDI1NzM4OiBTa2lhOiBDU1MgYm9yZGVyIHN0eWxlIG5vdCBjbGVhcmVkIGZvciBT Vkcgb2JqZWN0CisgICAgICAgIChodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjU3MzgpCisgCisgICAgICAgIElmIG5vIGRhc2hpbmcgaXMgc2V0LCB0aGlzIGNoYW5nZSBy ZXZlcnRzIHRvIHNvbGlkIHN0cm9rZSAKKyAgICAgICAgKHByZXZpb3VzbHkgdGhlIGNvZGUgYmFp bGVkIGFuZCBsZWZ0IHRoZSBvbGQgc2V0dGluZywgd2hhdGV2ZXIgaXQgd2FzKQorCisgICAgICAg IFRlc3QgY2FzZSBsaXN0ZWQgaW4gYWJvdmUgYnVnIGVudHJ5LgorICAgICAgICAoQWRkaXRpb25h bCBjb21wbGljYXRpb25zIGR1ZSB0byBlYWNoIHBsYXRmb3JtIHJlbmRlcmluZyBkb3R0ZWQgbGlu ZXMgZGlmZmVyZW50bHkgLSAKKyAgICAgICAgYy5mLiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjU3MzcpICAgICAgICAKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFw aGljc0NvbnRleHQ6OnNldExpbmVEYXNoKToKKwogMjAwOS0wMy0xOSAgT2xpdmVyIEh1bnQgIDxv bGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRl eDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0Nv bnRleHRTa2lhLmNwcAkocmV2aXNpb24gNDM1MzApCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkwNyw4 ICs5MDcsMTMgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OnNldExpbmVEYXNoKGNvbnN0IAogICAg IC8vIEZJWE1FOiBUaGlzIGlzIGxpZnRlZCBkaXJlY3RseSBvZmYgU2tpYVN1cHBvcnQsIGxpbmVz IDQ5LTc0CiAgICAgLy8gc28gaXQgaXMgbm90IGd1YXJhbnRlZWQgdG8gd29yayBjb3JyZWN0bHku CiAgICAgc2l6ZV90IGRhc2hMZW5ndGggPSBkYXNoZXMuc2l6ZSgpOwotICAgIGlmICghZGFzaExl bmd0aCkKKyAgICBpZiAoIWRhc2hMZW5ndGgpIHsKKyAgICAgICAgLy8gSWYgbm8gZGFzaCBpcyBz ZXQsIHJldmVydCB0byBzb2xpZCBzdHJva2UKKyAgICAgICAgLy8gRklYTUU6IGRvIHdlIG5lZWQg dG8gc2V0IE5vU3Ryb2tlIGluIHNvbWUgY2FzZXM/CisgICAgICAgIHBsYXRmb3JtQ29udGV4dCgp LT5zZXRTdHJva2VTdHlsZShTb2xpZFN0cm9rZSk7CisgICAgICAgIHBsYXRmb3JtQ29udGV4dCgp LT5zZXREYXNoUGF0aEVmZmVjdCgwKTsKICAgICAgICAgcmV0dXJuOworICAgIH0KIAogICAgIHNp emVfdCBjb3VudCA9IChkYXNoTGVuZ3RoICUgMikgPT0gMCA/IGRhc2hMZW5ndGggOiBkYXNoTGVu Z3RoICogMjsKICAgICBTa1NjYWxhciogaW50ZXJ2YWxzID0gbmV3IFNrU2NhbGFyW2NvdW50XTsK