<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>25731</bug_id>
          
          <creation_ts>2009-05-12 10:42:56 -0700</creation_ts>
          <short_desc>[Qt] Cleanup - move files exclusive to XPATH and XSLT under the appropriate build section</short_desc>
          <delta_ts>2009-05-15 09:10:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Laszlo Gombos">laszlo.gombos</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>120898</commentid>
    <comment_count>0</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-05-12 10:42:56 -0700</bug_when>
    <thetext>Benefits:
 - the feature configuration handling for XPATH and XSLT will be consistent with other guards withing Qt port

 - should make builds faster if the feature is disabled</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120899</commentid>
    <comment_count>1</comment_count>
      <attachid>30241</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-05-12 10:45:42 -0700</bug_when>
    <thetext>Created attachment 30241
Proposed cleanup.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120900</commentid>
    <comment_count>2</comment_count>
      <attachid>30241</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-05-12 10:49:57 -0700</bug_when>
    <thetext>Comment on attachment 30241
Proposed cleanup.

+!contains(DEFINES, ENABLE_XSLT=.): DEFINES += ENABLE_XSLT=0

makes it explicit and more obvious that XSLT is turned off by default for the Qt port (as it was before).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>121420</commentid>
    <comment_count>3</comment_count>
      <attachid>30241</attachid>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2009-05-14 20:33:57 -0700</bug_when>
    <thetext>Comment on attachment 30241
Proposed cleanup.

Nice.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>121449</commentid>
    <comment_count>4</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-05-15 00:06:52 -0700</bug_when>
    <thetext>Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.pro
Committed r43758
</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>30241</attachid>
            <date>2009-05-12 10:45:42 -0700</date>
            <delta_ts>2009-05-14 20:33:57 -0700</delta_ts>
            <desc>Proposed cleanup.</desc>
            <filename>patch_25731.txt</filename>
            <type>text/plain</type>
            <size>4062</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA0MzU2OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMDktMDUtMTIgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i
b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTczMQorICAg
ICAgICBbUXRdIENsZWFudXAgLSBtb3ZlIGZpbGVzIGV4Y2x1c2l2ZSB0byBYUEFUSCBhbmQgWFNM
VCB1bmRlciB0aGUKKyAgICAgICAgYXBwcm9wcmlhdGUgYnVpbGQgc2VjdGlvbgorCisgICAgICAg
ICogV2ViQ29yZS5wcm86CisKIDIwMDktMDUtMTIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3
ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2Vi
Q29yZS9XZWJDb3JlLnBybwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmUucHJvCShyZXZp
c2lvbiA0MzU2MSkKKysrIFdlYkNvcmUvV2ViQ29yZS5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTEw
NCw2ICsxMDQsNyBAQCBDT05GSUcoUVRESVJfYnVpbGQpIHsKIAogIWNvbnRhaW5zKERFRklORVMs
IEVOQUJMRV9EQVNIQk9BUkRfU1VQUE9SVD0uKTogREVGSU5FUyArPSBFTkFCTEVfREFTSEJPQVJE
X1NVUFBPUlQ9MAogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9YUEFUSD0uKTogREVGSU5FUyAr
PSBFTkFCTEVfWFBBVEg9MQorIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9YU0xUPS4pOiBERUZJ
TkVTICs9IEVOQUJMRV9YU0xUPTAKICMhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1hCTD0uKTog
REVGSU5FUyArPSBFTkFCTEVfWEJMPTEKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfV01MPS4p
OiBERUZJTkVTICs9IEVOQUJMRV9XTUw9MAogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9XT1JL
RVJTPS4pOiBERUZJTkVTICs9IEVOQUJMRV9XT1JLRVJTPTEKQEAgLTQwMiw4ICs0MDMsNyBAQCBJ
RExfQklORElOR1MgKz0gXAogICAgIHhtbC9YTUxIdHRwUmVxdWVzdEV4Y2VwdGlvbi5pZGwgXAog
ICAgIHhtbC9YTUxIdHRwUmVxdWVzdFByb2dyZXNzRXZlbnQuaWRsIFwKICAgICB4bWwvWE1MSHR0
cFJlcXVlc3RVcGxvYWQuaWRsIFwKLSAgICB4bWwvWE1MU2VyaWFsaXplci5pZGwgXAotICAgIHht
bC9YU0xUUHJvY2Vzc29yLmlkbAorICAgIHhtbC9YTUxTZXJpYWxpemVyLmlkbAogCiAKIFNPVVJD
RVMgKz0gXApAQCAtNDc0LDggKzQ3NCw2IEBAIFNPVVJDRVMgKz0gXAogICAgIGJpbmRpbmdzL2pz
L0pTWE1MSHR0cFJlcXVlc3RDb25zdHJ1Y3Rvci5jcHAgXAogICAgIGJpbmRpbmdzL2pzL0pTWE1M
SHR0cFJlcXVlc3RDdXN0b20uY3BwIFwKICAgICBiaW5kaW5ncy9qcy9KU1hNTEh0dHBSZXF1ZXN0
VXBsb2FkQ3VzdG9tLmNwcCBcCi0gICAgYmluZGluZ3MvanMvSlNYU0xUUHJvY2Vzc29yQ29uc3Ry
dWN0b3IuY3BwIFwKLSAgICBiaW5kaW5ncy9qcy9KU1hTTFRQcm9jZXNzb3JDdXN0b20uY3BwIFwK
ICAgICBiaW5kaW5ncy9qcy9KU1BsdWdpbkN1c3RvbS5jcHAgXAogICAgIGJpbmRpbmdzL2pzL0pT
UGx1Z2luQXJyYXlDdXN0b20uY3BwIFwKICAgICBiaW5kaW5ncy9qcy9KU01lc3NhZ2VDaGFubmVs
Q29uc3RydWN0b3IuY3BwIFwKQEAgLTEwNjMsMzAgKzEwNjEsOSBAQCBTT1VSQ0VTICs9IFwKICAg
ICByZW5kZXJpbmcvc3R5bGUvU3R5bGVUcmFuc2Zvcm1EYXRhLmNwcCBcCiAgICAgcmVuZGVyaW5n
L3N0eWxlL1N0eWxlVmlzdWFsRGF0YS5jcHAgXAogICAgIHhtbC9ET01QYXJzZXIuY3BwIFwKLSAg
ICB4bWwvTmF0aXZlWFBhdGhOU1Jlc29sdmVyLmNwcCBcCiAgICAgeG1sL1hNTEh0dHBSZXF1ZXN0
LmNwcCBcCiAgICAgeG1sL1hNTEh0dHBSZXF1ZXN0VXBsb2FkLmNwcCBcCi0gICAgeG1sL1hNTFNl
cmlhbGl6ZXIuY3BwIFwKLSAgICB4bWwvWFBhdGhFdmFsdWF0b3IuY3BwIFwKLSAgICB4bWwvWFBh
dGhFeHByZXNzaW9uLmNwcCBcCi0gICAgeG1sL1hQYXRoRXhwcmVzc2lvbk5vZGUuY3BwIFwKLSAg
ICB4bWwvWFBhdGhGdW5jdGlvbnMuY3BwIFwKLSAgICB4bWwvWFBhdGhOYW1lc3BhY2UuY3BwIFwK
LSAgICB4bWwvWFBhdGhOb2RlU2V0LmNwcCBcCi0gICAgeG1sL1hQYXRoTlNSZXNvbHZlci5jcHAg
XAotICAgIHhtbC9YUGF0aFBhcnNlci5jcHAgXAotICAgIHhtbC9YUGF0aFBhdGguY3BwIFwKLSAg
ICB4bWwvWFBhdGhQcmVkaWNhdGUuY3BwIFwKLSAgICB4bWwvWFBhdGhSZXN1bHQuY3BwIFwKLSAg
ICB4bWwvWFBhdGhTdGVwLmNwcCBcCi0gICAgeG1sL1hQYXRoVXRpbC5jcHAgXAotICAgIHhtbC9Y
UGF0aFZhbHVlLmNwcCBcCi0gICAgeG1sL1hQYXRoVmFyaWFibGVSZWZlcmVuY2UuY3BwIFwKLSAg
ICB4bWwvWFNMSW1wb3J0UnVsZS5jcHAgXAotICAgIHhtbC9YU0xTdHlsZVNoZWV0LmNwcCBcCi0g
ICAgeG1sL1hTTFRFeHRlbnNpb25zLmNwcCBcCi0gICAgeG1sL1hTTFRVbmljb2RlU29ydC5jcHAg
XAotICAgIHhtbC9YU0xUUHJvY2Vzc29yLmNwcAorICAgIHhtbC9YTUxTZXJpYWxpemVyLmNwcCAK
IAogSEVBREVSUyArPSBcCiAgICAgJCRQV0QvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvU3RpbGxJbWFn
ZVF0LmggXApAQCAtMTQ1MSw2ICsxNDI4LDI0IEBAIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9Y
UEFUSD0xKSB7CiAgICAgICAgIHhtbC9YUGF0aEV4cHJlc3Npb24uaWRsIFwKICAgICAgICAgeG1s
L1hQYXRoUmVzdWx0LmlkbCBcCiAgICAgICAgIHhtbC9YUGF0aEV2YWx1YXRvci5pZGwKKworICAg
IFNPVVJDRVMgKz0gXAorICAgICAgICB4bWwvTmF0aXZlWFBhdGhOU1Jlc29sdmVyLmNwcCBcCisg
ICAgICAgIHhtbC9YUGF0aEV2YWx1YXRvci5jcHAgXAorICAgICAgICB4bWwvWFBhdGhFeHByZXNz
aW9uLmNwcCBcCisgICAgICAgIHhtbC9YUGF0aEV4cHJlc3Npb25Ob2RlLmNwcCBcCisgICAgICAg
IHhtbC9YUGF0aEZ1bmN0aW9ucy5jcHAgXAorICAgICAgICB4bWwvWFBhdGhOYW1lc3BhY2UuY3Bw
IFwKKyAgICAgICAgeG1sL1hQYXRoTm9kZVNldC5jcHAgXAorICAgICAgICB4bWwvWFBhdGhOU1Jl
c29sdmVyLmNwcCBcCisgICAgICAgIHhtbC9YUGF0aFBhcnNlci5jcHAgXAorICAgICAgICB4bWwv
WFBhdGhQYXRoLmNwcCBcCisgICAgICAgIHhtbC9YUGF0aFByZWRpY2F0ZS5jcHAgXAorICAgICAg
ICB4bWwvWFBhdGhSZXN1bHQuY3BwIFwKKyAgICAgICAgeG1sL1hQYXRoU3RlcC5jcHAgXAorICAg
ICAgICB4bWwvWFBhdGhVdGlsLmNwcCBcCisgICAgICAgIHhtbC9YUGF0aFZhbHVlLmNwcCBcCisg
ICAgICAgIHhtbC9YUGF0aFZhcmlhYmxlUmVmZXJlbmNlLmNwcAogfQogCiB1bml4OiFtYWM6Q09O
RklHICs9IGxpbmtfcGtnY29uZmlnCkBAIC0xNDY3LDYgKzE0NjIsMTggQEAgY29udGFpbnMoREVG
SU5FUywgRU5BQkxFX1hTTFQ9MSkgewogICAgIHdpbjMyLW1zdmMqIHsKICAgICAgICAgTElCUyAr
PSAtbGxpYnhtbDIgLWxsaWJ4c2x0CiAgICAgfQorCisgICAgSURMX0JJTkRJTkdTICs9IFwKKyAg
ICAgICAgeG1sL1hTTFRQcm9jZXNzb3IuaWRsCisKKyAgICBTT1VSQ0VTICs9IFwKKyAgICAgICAg
YmluZGluZ3MvanMvSlNYU0xUUHJvY2Vzc29yQ29uc3RydWN0b3IuY3BwIFwKKyAgICAgICAgYmlu
ZGluZ3MvanMvSlNYU0xUUHJvY2Vzc29yQ3VzdG9tLmNwcCBcCisgICAgICAgIHhtbC9YU0xJbXBv
cnRSdWxlLmNwcCBcCisgICAgICAgIHhtbC9YU0xTdHlsZVNoZWV0LmNwcCBcCisgICAgICAgIHht
bC9YU0xURXh0ZW5zaW9ucy5jcHAgXAorICAgICAgICB4bWwvWFNMVFByb2Nlc3Nvci5jcHAgXAor
ICAgICAgICB4bWwvWFNMVFVuaWNvZGVTb3J0LmNwcAogfQogCiBjb250YWlucyhERUZJTkVTLCBF
TkFCTEVfWEJMPTEpIHsK
</data>
<flag name="review"
          id="15209"
          type_id="1"
          status="+"
          setter="zecke"
    />
          </attachment>
      

    </bug>

</bugzilla>