257307 2023-05-24 23:15:13 -0700 Update WebRTC abseil to M115 2023-06-01 22:40:40 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf dpino dpino webkit-bug-importer youennf oldest_to_newest 1957818 0 youennf 2023-05-24 23:15:13 -0700 Update WebRTC abseil to M115 1957819 1 webkit-bug-importer 2023-05-24 23:15:29 -0700 <rdar://problem/109815455> 1957820 2 youennf 2023-05-24 23:26:17 -0700 Pull request: https://github.com/WebKit/WebKit/pull/14330 1958959 3 ews-feeder 2023-05-30 23:50:22 -0700 Committed 264715@main (d388e8ee441d): <https://commits.webkit.org/264715@main> Reviewed commits have been landed. Closing PR #14330 and removing active labels. 1959459 4 dpino 2023-06-01 17:51:43 -0700 After abseil update I'm getting the following build error when building WPE using LibWebRTC: ``` CMake Error at Source/ThirdParty/libwebrtc/CMakeLists.txt:2101 (add_library): Cannot find source file: Source/third_party/abseil-cpp/absl/synchronization/internal/waiter.cc Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx ``` File 'waiter.cc' does not longer exists after abseil update, but it's still referenced as part of LibWebRTC sources. The build error was not detected by WebKitGTK/WPE EWS bots becasuse by default GStreamer WebRTC is used instead. I don't know why the Apple bots didn't detect this build error. 1959460 5 dpino 2023-06-01 17:52:33 -0700 Re-opening for pull request https://github.com/webkit/webkit/pull/14611 1959470 6 ews-feeder 2023-06-01 20:16:22 -0700 Committed 264822@main (c20f9a0705fc): <https://commits.webkit.org/264822@main> Reviewed commits have been landed. Closing PR #14611 and removing active labels. 1959494 7 youennf 2023-06-01 22:40:40 -0700 Thanks for spotting it. Mac/iOS bots do not spot it since we are not using cross platform Sources.txt, maybe we should. I expect to update more of libwebrtc third party libraries and libwebrtc itself. Expect some required work on your end to keep making it compile since no EWS bot is checking this config.