257198 2023-05-23 07:12:27 -0700 import-w3c-tests -s doesn't honor skip expectation 2023-08-21 08:26:32 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=259750 https://bugs.webkit.org/show_bug.cgi?id=260349 InRadar P2 Normal --- 1 annevk gsnedders gsnedders webkit-bug-importer youennf oldest_to_newest 1957310 0 annevk 2023-05-23 07:12:27 -0700 In LayoutTests/imported/w3c/resources/import-expectations.json we have: "web-platform-tests/websockets": "import", "web-platform-tests/websockets/stream": "skip", However, when I run import-w3c-tests web-platform-tests/websockets -l -s ../../Documents/GitHub.nosync --clean-dest-dir I get everything from the websockets/stream directory anyway. 1958735 1 webkit-bug-importer 2023-05-30 07:13:15 -0700 <rdar://problem/110004053> 1969293 2 gsnedders 2023-08-02 10:11:22 -0700 I can't reproduce this: ``` ./Tools/Scripts/import-w3c-tests --clear-dest-dir -t web-platform-tests/websockets ``` Results in: ``` % git status | grep stream Refresh index: 100% (391489/391489), done. ``` 1969294 3 gsnedders 2023-08-02 10:11:57 -0700 And removing `"web-platform-tests/websockets/stream": "skip"` does indeed lead it to get imported, so as far as I can tell that is working as expected. 1969347 4 gsnedders 2023-08-02 16:22:51 -0700 This still fails to reproduce with `--clear-dest-dir` corrected to `--clean-dest-dir` (bug 259750). 1971791 5 gsnedders 2023-08-17 04:11:39 -0700 So, uh, like bug 257674 this only reproduces with `-s`. Well, that's cursed. I love when the simpler codepath is broken. 1971817 6 gsnedders 2023-08-17 07:15:03 -0700 Currently, the skip logic in import-expectations.json is implemented in test_downloader.py, and thus is applied during the "download". 1971826 7 gsnedders 2023-08-17 07:53:46 -0700 Pull request: https://github.com/WebKit/WebKit/pull/16789 1972377 8 ews-feeder 2023-08-21 08:26:28 -0700 Committed 267088@main (e21f2280dbbb): <https://commits.webkit.org/267088@main> Reviewed commits have been landed. Closing PR #16789 and removing active labels.