25714 2009-05-11 19:15:54 -0700 Decouple HTML5 Database support from generic SQLite/Database support 2009-05-11 22:04:43 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned oldest_to_newest 120772 0 laszlo.gombos 2009-05-11 19:15:54 -0700 In the Qt port disabling HTML5 DATABASE support will also disable ICONDATABASE OFFLINE_WEB_APPLICATIONS and DOM_STORAGE support. This patch will enable turning HTML 5 DATABASE support on/off independently from the rest of the SQLite/generic database dependent features. 120774 1 30214 laszlo.gombos 2009-05-11 19:24:41 -0700 Created attachment 30214 Proposed Fix Introduce the ENABLE_SQLITE guard for turning the SQLite feature/dependency on/off (instead of using the ENABLE_SQLITE guard). Move LocalStorage*.cpp; StorageArea.cpp and StorageMap.cpp files out from the DATABASE guard into the DOM_STORAGE guard (where they belong). 120796 2 zecke 2009-05-11 22:04:43 -0700 Landed in r43549. 30214 2009-05-11 19:24:41 -0700 2009-05-11 20:47:06 -0700 Proposed Fix patch_25714.txt text/plain 4794 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzUyOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDUtMTEgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEJ1ZyAyNTcxNDogW1F0XSBEZWNvdXBsZSBIVE1MNSBEYXRhYmFzZSBzdXBwb3J0IGZy b20gdGhlCisgICAgICAgIFNRTGl0ZS9nZW5lcmljIGRhdGFiYXNlIHN1cHBvcnQgaW4gdGhlIFF0 IHBvcnQKKworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI1NzE0PgorCisgICAgICAgICogV2ViQ29yZS5wcm86CisKIDIwMDktMDUtMTEgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWcgMjUwODc6IFRlc3QgZm9y IEVOQUJMRV9GT08gbWFjcm9zIGNvbnNpc3RlbnRseSBpbiBJREwgZmlsZXMKSW5kZXg6IFdlYkNv cmUvV2ViQ29yZS5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3JlLnBybwkocmV2aXNp b24gNDM1MjgpCisrKyBXZWJDb3JlL1dlYkNvcmUucHJvCSh3b3JraW5nIGNvcHkpCkBAIC04NCwy NCArODQsMjQgQEAgQ09ORklHKFFURElSX2J1aWxkKSB7CiAKICMgT3B0aW9uYWwgY29tcG9uZW50 cyAobG9vayBmb3IgZGVmcyBpbiBjb25maWcuaCBhbmQgaW5jbHVkZWQgZmlsZXMhKQogCi0jIHR1 cm4gb2ZmIGRhdGFiYXNlIHN1cHBvcnQgaWYgd2UgZG8gbm90IGhhdmUgc3FsaXRlMyBzdXBwb3J0 IAotIUNPTkZJRyhRVERJUl9idWlsZCk6d2luMzItKjohZXhpc3RzKCAkJHtTUUxJVEUzU1JDRElS fS9zcWxpdGUzLmMgKTogREVGSU5FUyArPSBFTkFCTEVfREFUQUJBU0U9MCBFTkFCTEVfSUNPTkRB VEFCQVNFPTAgRU5BQkxFX09GRkxJTkVfV0VCX0FQUExJQ0FUSU9OUz0wIEVOQUJMRV9ET01fU1RP UkFHRT0wCisjIHR1cm4gb2ZmIFNRTElURSBzdXBwb3J0IGlmIHdlIGRvIG5vdCBoYXZlIHNxbGl0 ZTMgYXZhaWxhYmxlCishQ09ORklHKFFURElSX2J1aWxkKTp3aW4zMi0qOiFleGlzdHMoICQke1NR TElURTNTUkNESVJ9L3NxbGl0ZTMuYyApOiBERUZJTkVTICs9IEVOQUJMRV9TUUxJVEU9MCBFTkFC TEVfREFUQUJBU0U9MCBFTkFCTEVfSUNPTkRBVEFCQVNFPTAgRU5BQkxFX09GRkxJTkVfV0VCX0FQ UExJQ0FUSU9OUz0wIEVOQUJMRV9ET01fU1RPUkFHRT0wCiAKICFjb250YWlucyhERUZJTkVTLCBF TkFCTEVfSkFWQVNDUklQVF9ERUJVR0dFUj0uKTogREVGSU5FUyArPSBFTkFCTEVfSkFWQVNDUklQ VF9ERUJVR0dFUj0xCishY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0RBVEFCQVNFPS4pOiBERUZJ TkVTICs9IEVOQUJMRV9EQVRBQkFTRT0xCiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX09GRkxJ TkVfV0VCX0FQUExJQ0FUSU9OUz0uKTogREVGSU5FUyArPSBFTkFCTEVfT0ZGTElORV9XRUJfQVBQ TElDQVRJT05TPTEKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfRE9NX1NUT1JBR0U9Lik6IERF RklORVMgKz0gRU5BQkxFX0RPTV9TVE9SQUdFPTEKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVf SUNPTkRBVEFCQVNFPS4pOiBERUZJTkVTICs9IEVOQUJMRV9JQ09OREFUQUJBU0U9MQogCi0jIHR1 cm4gb24gZGF0YWJhc2Ugc3VwcG9ydCBpZiBhbnkgb2YgdGhlIGRlcGVuZGVudCBmZWF0dXJlcyBh cmUgdHVybmVkIG9uCi0hY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0RBVEFCQVNFPTEpIHsKLSAg Y29udGFpbnMoREVGSU5FUywgRU5BQkxFX0lDT05EQVRBQkFTRT0xKXxjb250YWlucyhERUZJTkVT LCBFTkFCTEVfRE9NX1NUT1JBR0U9MSl8Y29udGFpbnMoREVGSU5FUywgRU5BQkxFX09GRkxJTkVf V0VCX0FQUExJQ0FUSU9OUz0xKSB7Ci0gICAgREVGSU5FUyArPSBFTkFCTEVfREFUQUJBU0U9MQor IyB0dXJuIG9uIFNRTElURSBzdXBwb3J0IGlmIGFueSBvZiB0aGUgZGVwZW5kZW50IGZlYXR1cmVz IGFyZSB0dXJuZWQgb24KKyFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfU1FMSVRFPS4pIHsKKyAg Y29udGFpbnMoREVGSU5FUywgRU5BQkxFX0RBVEFCQVNFPTEpfGNvbnRhaW5zKERFRklORVMsIEVO QUJMRV9JQ09OREFUQUJBU0U9MSl8Y29udGFpbnMoREVGSU5FUywgRU5BQkxFX0RPTV9TVE9SQUdF PTEpfGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9PRkZMSU5FX1dFQl9BUFBMSUNBVElPTlM9MSkg eworICAgIERFRklORVMgKz0gRU5BQkxFX1NRTElURT0xCisgIH0gZWxzZSB7CisgICAgREVGSU5F UyArPSBFTkFCTEVfU1FMSVRFPTAKICAgfQogfQogCi0jIGlmIGRhdGFiYXNlIHN1cHBvcnQgaXMg bm90IG9uIGJ5IG5vdywgdHVybiBpdCBvZmYgCi0hY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0RB VEFCQVNFPS4pOiBERUZJTkVTICs9IEVOQUJMRV9EQVRBQkFTRT0wCi0KICFjb250YWlucyhERUZJ TkVTLCBFTkFCTEVfREFTSEJPQVJEX1NVUFBPUlQ9Lik6IERFRklORVMgKz0gRU5BQkxFX0RBU0hC T0FSRF9TVVBQT1JUPTAKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfWFBBVEg9Lik6IERFRklO RVMgKz0gRU5BQkxFX1hQQVRIPTEKICMhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1hCTD0uKTog REVGSU5FUyArPSBFTkFCTEVfWEJMPTEKQEAgLTEyODEsOSArMTI4MSw3IEBAIGNvbnRhaW5zKERF RklORVMsIEVOQUJMRV9EQVNIQk9BUkRfU1VQUE8KICAgICBEQVNIQk9BUkRTVVBQT1JUQ1NTUFJP UEVSVElFUyAtPSAkJFBXRC9jc3MvRGFzaGJvYXJkU3VwcG9ydENTU1Byb3BlcnR5TmFtZXMuaW4K IH0KIAotY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0RBVEFCQVNFPTEpIHsKLSAgICBGRUFUVVJF X0RFRklORVNfSkFWQVNDUklQVCArPSBFTkFCTEVfREFUQUJBU0U9MQotCitjb250YWlucyhERUZJ TkVTLCBFTkFCTEVfU1FMSVRFPTEpIHsKICAgICAjIHNvbWV3aGF0IGNvcGllZCBmcm9tIHNyYy9w bHVnaW5zL3NxbGRyaXZlcnMvc3FsaXRlL3NxbGl0ZS5wcm8KICAgICBDT05GSUcoUVRESVJfYnVp bGQpOnN5c3RlbS1zcWxpdGUgewogICAgICAgICBMSUJTICo9ICQkUVRfTEZMQUdTX1NRTElURQpA QCAtMTMwOCwyMCArMTMwNiwyMSBAQCBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfREFUQUJBU0U9 MSkgewogICAgICAgICBwbGF0Zm9ybS9zcWwvU1FMaXRlU3RhdGVtZW50LmNwcCBcCiAgICAgICAg IHBsYXRmb3JtL3NxbC9TUUxpdGVUcmFuc2FjdGlvbi5jcHAgXAogICAgICAgICBwbGF0Zm9ybS9z cWwvU1FMVmFsdWUuY3BwIFwKLSAgICAgICAgc3RvcmFnZS9DaGFuZ2VWZXJzaW9uV3JhcHBlci5j cHAgXAotICAgICAgICBzdG9yYWdlL0RhdGFiYXNlQXV0aG9yaXplci5jcHAgXAogICAgICAgICBz dG9yYWdlL0RhdGFiYXNlLmNwcCBcCisgICAgICAgIHN0b3JhZ2UvRGF0YWJhc2VBdXRob3JpemVy LmNwcAorfQorCisKK2NvbnRhaW5zKERFRklORVMsIEVOQUJMRV9EQVRBQkFTRT0xKSB7CisgICAg RkVBVFVSRV9ERUZJTkVTX0pBVkFTQ1JJUFQgKz0gRU5BQkxFX0RBVEFCQVNFPTEKKworICAgIFNP VVJDRVMgKz0gXAorICAgICAgICBzdG9yYWdlL0NoYW5nZVZlcnNpb25XcmFwcGVyLmNwcCBcCiAg ICAgICAgIHN0b3JhZ2UvRGF0YWJhc2VUYXNrLmNwcCBcCiAgICAgICAgIHN0b3JhZ2UvRGF0YWJh c2VUaHJlYWQuY3BwIFwKICAgICAgICAgc3RvcmFnZS9EYXRhYmFzZVRyYWNrZXIuY3BwIFwKLSAg ICAgICAgc3RvcmFnZS9Mb2NhbFN0b3JhZ2UuY3BwIFwKLSAgICAgICAgc3RvcmFnZS9Mb2NhbFN0 b3JhZ2VBcmVhLmNwcCBcCi0gICAgICAgIHN0b3JhZ2UvTG9jYWxTdG9yYWdlVGFzay5jcHAgXAot ICAgICAgICBzdG9yYWdlL0xvY2FsU3RvcmFnZVRocmVhZC5jcHAgXAogICAgICAgICBzdG9yYWdl L09yaWdpblF1b3RhTWFuYWdlci5jcHAgXAogICAgICAgICBzdG9yYWdlL09yaWdpblVzYWdlUmVj b3JkLmNwcCBcCi0gICAgICAgIHN0b3JhZ2UvU3RvcmFnZUFyZWEuY3BwIFwKLSAgICAgICAgc3Rv cmFnZS9TdG9yYWdlTWFwLmNwcCBcCiAgICAgICAgIHN0b3JhZ2UvU1FMUmVzdWx0U2V0LmNwcCBc CiAgICAgICAgIHN0b3JhZ2UvU1FMUmVzdWx0U2V0Um93TGlzdC5jcHAgXAogICAgICAgICBzdG9y YWdlL1NRTFN0YXRlbWVudC5jcHAgXApAQCAtMTM1Miw3ICsxMzUxLDEzIEBAIGNvbnRhaW5zKERF RklORVMsIEVOQUJMRV9ET01fU1RPUkFHRT0xKSAKICAgICAgICAgc3RvcmFnZS9TZXNzaW9uU3Rv cmFnZUFyZWEuaAogCiAgICAgU09VUkNFUyArPSBcCisgICAgICAgIHN0b3JhZ2UvTG9jYWxTdG9y YWdlLmNwcCBcCisgICAgICAgIHN0b3JhZ2UvTG9jYWxTdG9yYWdlQXJlYS5jcHAgXAorICAgICAg ICBzdG9yYWdlL0xvY2FsU3RvcmFnZVRhc2suY3BwIFwKKyAgICAgICAgc3RvcmFnZS9Mb2NhbFN0 b3JhZ2VUaHJlYWQuY3BwIFwKICAgICAgICAgc3RvcmFnZS9TdG9yYWdlLmNwcCBcCisgICAgICAg IHN0b3JhZ2UvU3RvcmFnZUFyZWEuY3BwIFwKKyAgICAgICAgc3RvcmFnZS9TdG9yYWdlTWFwLmNw cCBcCiAgICAgICAgIHN0b3JhZ2UvU3RvcmFnZUV2ZW50LmNwcCBcCiAgICAgICAgIHN0b3JhZ2Uv U2Vzc2lvblN0b3JhZ2UuY3BwIFwKICAgICAgICAgc3RvcmFnZS9TZXNzaW9uU3RvcmFnZUFyZWEu Y3BwIFwK