25708 2009-05-11 17:10:40 -0700 Cannot choose menu items in popups with many entries in Chromium 2009-05-12 14:54:44 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 paul paul oldest_to_newest 120746 0 paul 2009-05-11 17:10:40 -0700 Popup menus that contain many entries cannot select menu items beyond the ~20th one in Mac Chromium. Chromium on Mac uses cocoa controls for handling these popups, and converts the index of the selected item to a coordinate corresponding to that item in the popup. On Windows and linux, Chromium's popup menu uses a ScrollView that limits the number of visible items to a maximum of 20. Any mouse click outside of that scroll view is discarded. The hit testing in Mac Chromium needs to account for the fact that native popup controls will display as many items as can fit on the screen, which is much more than the artificial limit of 20 that Chromium imposes. 120749 1 30208 paul 2009-05-11 17:28:07 -0700 Created attachment 30208 Fix Mac popup item selection for menus with many items 120750 2 30209 paul 2009-05-11 17:28:52 -0700 Created attachment 30209 Fix Mac popup item selection for menus with many items 120876 3 30209 dglazkov 2009-05-12 09:27:37 -0700 Comment on attachment 30209 Fix Mac popup item selection for menus with many items > + Bug 25708: Cannont choose menu items in popups with many entries in Chromium Spelling: Cannot. 120932 4 30247 paul 2009-05-12 14:38:00 -0700 Created attachment 30247 Fix Mac popup item selection for menus with many items (corrected spelling in ChangeLog) 120933 5 dglazkov 2009-05-12 14:54:44 -0700 Landed as http://trac.webkit.org/changeset/43587. 30208 2009-05-11 17:28:07 -0700 2009-05-12 09:15:12 -0700 Fix Mac popup item selection for menus with many items mac_hit_test text/plain 2013 paul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzUyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDUtMTEgIFBhdWwgR29kYXZhcmkgIDxwYXVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBC dWcgMjU3MDg6IENhbm5vbnQgY2hvb3NlIG1lbnUgaXRlbXMgaW4gcG9wdXBzIHdpdGggbWFueSBl bnRyaWVzIGluIENocm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNTcwOAorCisgICAgICAgIFRoaXMgY2hhbmdlIHNldHMgdGhlIHdpbmRvdyBz aXplIGZvciBwb3B1cHMgb24gTWFjIHRvIGluY2x1ZGUgYWxsIGl0ZW1zCisgICAgICAgIGluIHRo ZSBtZW51LiBUaGlzIGlzIHJlcXVpcmVkIGZvciBoaXQgdGVzdGluZyBvbiBNYWMsIHdoZXJlIHdl IHVzZSBuYXRpdmUKKyAgICAgICAgY29udHJvbHMgdG8gbWFuYWdlIHRoZSBwb3B1cHMgYW5kIGRv bid0IHdhbnQgdG8gYXJ0aWZpY2lhbGx5IGxpbWl0IHRoZQorICAgICAgICB2YWxpZCBoaXQgdGVz dGluZyByZWdpb24gdG8gYSBsaW1pdGVkIHNjcm9sbCB3aW5kb3cuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQ b3B1cExpc3RCb3g6OmxheW91dCk6CisKIDIwMDktMDUtMTEgIE5vcmJlcnQgTGVzZXIgIDxub3Ji ZXJ0Lmxlc2VyQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0u Y3BwCShyZXZpc2lvbiA0MzUyMCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBN ZW51Q2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDYzLDEzICsxMDYzLDI2IEBAIHZv aWQgUG9wdXBMaXN0Qm94OjpsYXlvdXQoKQogICAgIH0KIAogICAgIGludCB3aW5kb3dIZWlnaHQg PSAwOworCisjaWYgUExBVEZPUk0oREFSV0lOKQorICAgIC8vIFNldCB0aGUgcG9wdXAncyB3aW5k b3cgdG8gY29udGFpbiBhbGwgYXZhaWxhYmxlIGl0ZW1zIG9uIE1hYyBvbmx5LCB3aGljaAorICAg IC8vIHVzZXMgbmF0aXZlIGNvbnRyb2xzIHRoYXQgbWFuYWdlIHRoZWlyIG93biBzY3JvbGxpbmcu IFRoaXMgYWxsb3dzIGhpdAorICAgIC8vIHRlc3RpbmcgdG8gd29yayB3aGVuIHNlbGVjdGluZyBp dGVtcyBpbiBwb3B1cHMgdGhhdCBoYXZlIG1vcmUgbWVudSBlbnRyaWVzCisgICAgLy8gdGhhbiB0 aGUgbWF4aW11bSB3aW5kb3cgc2l6ZS4KKyAgICBtX3Zpc2libGVSb3dzID0gbnVtSXRlbXMoKTsK KyNlbHNlCiAgICAgbV92aXNpYmxlUm93cyA9IG1pbihudW1JdGVtcygpLCBrTWF4VmlzaWJsZVJv d3MpOworI2VuZGlmCisKICAgICBmb3IgKGludCBpID0gMDsgaSA8IG1fdmlzaWJsZVJvd3M7ICsr aSkgewogICAgICAgICBpbnQgcm93SGVpZ2h0ID0gZ2V0Um93SGVpZ2h0KGkpOworI2lmICFQTEFU Rk9STShEQVJXSU4pCisgICAgICAgIC8vIE9ubHkgY2xpcCB0aGUgd2luZG93IGhlaWdodCBmb3Ig bm9uLU1hYyBwbGF0Zm9ybXMuCiAgICAgICAgIGlmICh3aW5kb3dIZWlnaHQgKyByb3dIZWlnaHQg PiBrTWF4SGVpZ2h0KSB7CiAgICAgICAgICAgICBtX3Zpc2libGVSb3dzID0gaTsKICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICB9CisjZW5kaWYKIAogICAgICAgICB3aW5kb3dIZWlnaHQgKz0g cm93SGVpZ2h0OwogICAgIH0K 30209 2009-05-11 17:28:52 -0700 2009-05-12 14:38:00 -0700 Fix Mac popup item selection for menus with many items mac_hit_test text/plain 2013 paul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzUyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDUtMTEgIFBhdWwgR29kYXZhcmkgIDxwYXVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBC dWcgMjU3MDg6IENhbm5vbnQgY2hvb3NlIG1lbnUgaXRlbXMgaW4gcG9wdXBzIHdpdGggbWFueSBl bnRyaWVzIGluIENocm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNTcwOAorCisgICAgICAgIFRoaXMgY2hhbmdlIHNldHMgdGhlIHdpbmRvdyBz aXplIGZvciBwb3B1cHMgb24gTWFjIHRvIGluY2x1ZGUgYWxsIGl0ZW1zCisgICAgICAgIGluIHRo ZSBtZW51LiBUaGlzIGlzIHJlcXVpcmVkIGZvciBoaXQgdGVzdGluZyBvbiBNYWMsIHdoZXJlIHdl IHVzZSBuYXRpdmUKKyAgICAgICAgY29udHJvbHMgdG8gbWFuYWdlIHRoZSBwb3B1cHMgYW5kIGRv bid0IHdhbnQgdG8gYXJ0aWZpY2lhbGx5IGxpbWl0IHRoZQorICAgICAgICB2YWxpZCBoaXQgdGVz dGluZyByZWdpb24gdG8gYSBsaW1pdGVkIHNjcm9sbCB3aW5kb3cuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQ b3B1cExpc3RCb3g6OmxheW91dCk6CisKIDIwMDktMDUtMTEgIE5vcmJlcnQgTGVzZXIgIDxub3Ji ZXJ0Lmxlc2VyQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0u Y3BwCShyZXZpc2lvbiA0MzUyMCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBN ZW51Q2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDYzLDEzICsxMDYzLDI2IEBAIHZv aWQgUG9wdXBMaXN0Qm94OjpsYXlvdXQoKQogICAgIH0KIAogICAgIGludCB3aW5kb3dIZWlnaHQg PSAwOworCisjaWYgUExBVEZPUk0oREFSV0lOKQorICAgIC8vIFNldCB0aGUgcG9wdXAncyB3aW5k b3cgdG8gY29udGFpbiBhbGwgYXZhaWxhYmxlIGl0ZW1zIG9uIE1hYyBvbmx5LCB3aGljaAorICAg IC8vIHVzZXMgbmF0aXZlIGNvbnRyb2xzIHRoYXQgbWFuYWdlIHRoZWlyIG93biBzY3JvbGxpbmcu IFRoaXMgYWxsb3dzIGhpdAorICAgIC8vIHRlc3RpbmcgdG8gd29yayB3aGVuIHNlbGVjdGluZyBp dGVtcyBpbiBwb3B1cHMgdGhhdCBoYXZlIG1vcmUgbWVudSBlbnRyaWVzCisgICAgLy8gdGhhbiB0 aGUgbWF4aW11bSB3aW5kb3cgc2l6ZS4KKyAgICBtX3Zpc2libGVSb3dzID0gbnVtSXRlbXMoKTsK KyNlbHNlCiAgICAgbV92aXNpYmxlUm93cyA9IG1pbihudW1JdGVtcygpLCBrTWF4VmlzaWJsZVJv d3MpOworI2VuZGlmCisKICAgICBmb3IgKGludCBpID0gMDsgaSA8IG1fdmlzaWJsZVJvd3M7ICsr aSkgewogICAgICAgICBpbnQgcm93SGVpZ2h0ID0gZ2V0Um93SGVpZ2h0KGkpOworI2lmICFQTEFU Rk9STShEQVJXSU4pCisgICAgICAgIC8vIE9ubHkgY2xpcCB0aGUgd2luZG93IGhlaWdodCBmb3Ig bm9uLU1hYyBwbGF0Zm9ybXMuCiAgICAgICAgIGlmICh3aW5kb3dIZWlnaHQgKyByb3dIZWlnaHQg PiBrTWF4SGVpZ2h0KSB7CiAgICAgICAgICAgICBtX3Zpc2libGVSb3dzID0gaTsKICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICB9CisjZW5kaWYKIAogICAgICAgICB3aW5kb3dIZWlnaHQgKz0g cm93SGVpZ2h0OwogICAgIH0K 30247 2009-05-12 14:38:00 -0700 2009-05-12 14:51:40 -0700 Fix Mac popup item selection for menus with many items (corrected spelling in ChangeLog) mac_hit_test3 text/plain 2076 paul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzU4NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDUtMTIgIFBhdWwgR29kYXZhcmkgIDxwYXVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX QVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKyAgICAgICAgCisgICAgICAg IEJ1ZyAyNTcwODogQ2Fubm90IGNob29zZSBtZW51IGl0ZW1zIGluIHBvcHVwcyB3aXRoIG1hbnkg ZW50cmllcyBpbiBDaHJvbWl1bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjU3MDgKKworICAgICAgICBUaGlzIGNoYW5nZSBzZXRzIHRoZSB3aW5kb3cg c2l6ZSBmb3IgcG9wdXBzIG9uIE1hYyB0byBpbmNsdWRlIGFsbCBpdGVtcworICAgICAgICBpbiB0 aGUgbWVudS4gVGhpcyBpcyByZXF1aXJlZCBmb3IgaGl0IHRlc3Rpbmcgb24gTWFjLCB3aGVyZSB3 ZSB1c2UgbmF0aXZlCisgICAgICAgIGNvbnRyb2xzIHRvIG1hbmFnZSB0aGUgcG9wdXBzIGFuZCBk b24ndCB3YW50IHRvIGFydGlmaWNpYWxseSBsaW1pdCB0aGUKKyAgICAgICAgdmFsaWQgaGl0IHRl c3RpbmcgcmVnaW9uIHRvIGEgbGltaXRlZCBzY3JvbGwgd2luZG93LgorCisgICAgICAgICogcGxh dGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UG9wdXBMaXN0Qm94OjpsYXlvdXQpOgorCiAyMDA5LTA1LTEyICBTdGVwaGVuIFdoaXRlICA8c2Vu b3JibGFuY29AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xh emtvdi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hy b21pdW0uY3BwCShyZXZpc2lvbiA0MzU4NikKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0v UG9wdXBNZW51Q2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDYzLDEzICsxMDYzLDI2 IEBAIHZvaWQgUG9wdXBMaXN0Qm94OjpsYXlvdXQoKQogICAgIH0KIAogICAgIGludCB3aW5kb3dI ZWlnaHQgPSAwOworCisjaWYgUExBVEZPUk0oREFSV0lOKQorICAgIC8vIFNldCB0aGUgcG9wdXAn cyB3aW5kb3cgdG8gY29udGFpbiBhbGwgYXZhaWxhYmxlIGl0ZW1zIG9uIE1hYyBvbmx5LCB3aGlj aAorICAgIC8vIHVzZXMgbmF0aXZlIGNvbnRyb2xzIHRoYXQgbWFuYWdlIHRoZWlyIG93biBzY3Jv bGxpbmcuIFRoaXMgYWxsb3dzIGhpdAorICAgIC8vIHRlc3RpbmcgdG8gd29yayB3aGVuIHNlbGVj dGluZyBpdGVtcyBpbiBwb3B1cHMgdGhhdCBoYXZlIG1vcmUgbWVudSBlbnRyaWVzCisgICAgLy8g dGhhbiB0aGUgbWF4aW11bSB3aW5kb3cgc2l6ZS4KKyAgICBtX3Zpc2libGVSb3dzID0gbnVtSXRl bXMoKTsKKyNlbHNlCiAgICAgbV92aXNpYmxlUm93cyA9IG1pbihudW1JdGVtcygpLCBrTWF4Vmlz aWJsZVJvd3MpOworI2VuZGlmCisKICAgICBmb3IgKGludCBpID0gMDsgaSA8IG1fdmlzaWJsZVJv d3M7ICsraSkgewogICAgICAgICBpbnQgcm93SGVpZ2h0ID0gZ2V0Um93SGVpZ2h0KGkpOworI2lm ICFQTEFURk9STShEQVJXSU4pCisgICAgICAgIC8vIE9ubHkgY2xpcCB0aGUgd2luZG93IGhlaWdo dCBmb3Igbm9uLU1hYyBwbGF0Zm9ybXMuCiAgICAgICAgIGlmICh3aW5kb3dIZWlnaHQgKyByb3dI ZWlnaHQgPiBrTWF4SGVpZ2h0KSB7CiAgICAgICAgICAgICBtX3Zpc2libGVSb3dzID0gaTsKICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CisjZW5kaWYKIAogICAgICAgICB3aW5kb3dIZWln aHQgKz0gcm93SGVpZ2h0OwogICAgIH0K