<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>25702</bug_id>
          
          <creation_ts>2009-05-11 12:53:06 -0700</creation_ts>
          <short_desc>Unregister plugins when they are stopped, in Qt port</short_desc>
          <delta_ts>2009-05-11 22:08:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yael">yael</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>120708</commentid>
    <comment_count>0</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2009-05-11 12:53:06 -0700</bug_when>
    <thetext>Plugins are registered with PluginMainThreadScheduler when they are started, but in Qt port, they are not unregistered when they are stopped. This can lead to an assertion failure in PluginMainThreadScheduler::registerPlugin if the same address is reused for a new NPP instance.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120709</commentid>
    <comment_count>1</comment_count>
      <attachid>30200</attachid>
    <who name="Yael">yael</who>
    <bug_when>2009-05-11 12:55:01 -0700</bug_when>
    <thetext>Created attachment 30200
Add call to unregister the plugin when it is stopped</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120784</commentid>
    <comment_count>2</comment_count>
      <attachid>30200</attachid>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2009-05-11 20:48:07 -0700</bug_when>
    <thetext>Comment on attachment 30200
Add call to unregister the plugin when it is stopped

Same fix is needed for Gtk+ :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120798</commentid>
    <comment_count>3</comment_count>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2009-05-11 22:08:22 -0700</bug_when>
    <thetext>Windows is doing it below the &quot;Clear Window&quot; but I assume it is okay, landed in r43550.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>30200</attachid>
            <date>2009-05-11 12:55:01 -0700</date>
            <delta_ts>2009-05-11 20:48:07 -0700</delta_ts>
            <desc>Add call to unregister the plugin when it is stopped</desc>
            <filename>plugin.patch</filename>
            <type>text/plain</type>
            <size>1435</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFdlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCShyZXZpc2lvbiA0MzUwMSkKKysr
IFdlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00
OCw2ICs0OCw3IEBACiAjaW5jbHVkZSAiUGx1Z2luQ29udGFpbmVyUXQuaCIKICNpbmNsdWRlICJQ
bHVnaW5EZWJ1Zy5oIgogI2luY2x1ZGUgIlBsdWdpblBhY2thZ2UuaCIKKyNpbmNsdWRlICJQbHVn
aW5NYWluVGhyZWFkU2NoZWR1bGVyLmgiCiAjaW5jbHVkZSAiUmVuZGVyTGF5ZXIuaCIKICNpbmNs
dWRlICJTY3JpcHRDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKQEAgLTIzMiw2
ICsyMzMsOCBAQAogCiAgICAgSlNDOjpKU0xvY2s6OkRyb3BBbGxMb2NrcyBkcm9wQWxsTG9ja3Mo
ZmFsc2UpOwogCisgICAgUGx1Z2luTWFpblRocmVhZFNjaGVkdWxlcjo6c2NoZWR1bGVyKCkudW5y
ZWdpc3RlclBsdWdpbihtX2luc3RhbmNlKTsKKwogICAgIC8vIENsZWFyIHRoZSB3aW5kb3cKICAg
ICBtX25wV2luZG93LndpbmRvdyA9IDA7CiAgICAgaWYgKG1fcGx1Z2luLT5wbHVnaW5GdW5jcygp
LT5zZXR3aW5kb3cgJiYgIW1fcGx1Z2luLT5xdWlya3MoKS5jb250YWlucyhQbHVnaW5RdWlya0Rv
bnRTZXROdWxsV2luZG93SGFuZGxlT25EZXN0cm95KSkgewpJbmRleDogV2ViQ29yZS9DaGFuZ2VM
b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQzNTA2KQorKysg
V2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0w
NS0xMSAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIFF0IHBvcnQgdG8gbWF0
Y2ggdGhlIG1hYyBhbmQgd2luZG93cyBwb3J0cywgYW5kIHVucmVnaXN0ZXIgcGx1Z2lucyB3aGVu
IHBsdWdpbnMgYXJlIHN0b3BwZWQuCisgICAgICAgIE5vdCBkb2luZyB0aGF0IGNhbiBjYXVzZSBh
c3NlcnNpb24gZmFpbHVyZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTI1NzAyCisKKyAgICAgICAgKiBwbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHA6
CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpzdG9wKToKKwogMjAwOS0wNS0xMSAgQnJh
ZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFy
aW4gQWRsZXIuCg==
</data>
<flag name="review"
          id="15182"
          type_id="1"
          status="+"
          setter="zecke"
    />
          </attachment>
      

    </bug>

</bugzilla>