25701 2009-05-11 12:48:47 -0700 REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook 2009-06-23 17:24:57 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC Windows Vista RESOLVED FIXED http://web.me.com/alice.liu/FacebookEvents.html InRadar, PlatformOnly, Regression P2 Normal --- 1 alice.barraclough alice.barraclough aroben hyatt mitz oldest_to_newest 120704 0 alice.barraclough 2009-05-11 12:48:47 -0700 On Windows, now that search fields have -webkit-appearance: textfield and the code path to adjust styling for searchfields has been replaced by rules in a user agent style sheet, styled search fields can look weird in Safari on Windows. originally found at http://www.facebook.com/events.php?ref=sb, the search field now has both the developer-specified style plus the webkit search field decorations, when it should just have the webkit search field decoration. reduction at http://web.me.com/alice.liu/FacebookEvents.html <rdar://problem/6855916> 120705 1 30198 alice.barraclough 2009-05-11 12:49:24 -0700 Created attachment 30198 screenshot 120707 2 30199 alice.barraclough 2009-05-11 12:50:28 -0700 Created attachment 30199 proposed patch without testcase 120710 3 30199 hyatt 2009-05-11 13:00:01 -0700 Comment on attachment 30199 proposed patch without testcase I don't think you intended to prevent the specification of padding on text fields. I'm pretty sure browsers allow the padding of text fields to be customized. It's not clear to me why we can't support customizable padding on search fields, so I don't really understand why we'd prevent that? I believe you can just remove the rule for input[type="search"] to get -webkit-appearance: searchfield, right? I assume that's specified in the base CSS file already. 120712 4 alice.barraclough 2009-05-11 13:21:04 -0700 =\ I forgot to explain the padding thing fully. http://trac.webkit.org/changeset/42020 this change removed the code path that adjusted the appearance of searchfield after all the style was already applied. We used to call RenderThemeWin::adjustSearchFieldStyle, and now we just specify the padding rules in themeWin.css, but the problem was that the padding rules needed to be applied last in order to look exactly the way it used to. Do we no longer care that much to preserve this padding we had in Safari 3? If not, i can take it out. I think as long as we just make the change to not respect background image styling on searchfields, then the facebook searchfield will look okay on Windows. 120714 5 mitz 2009-05-11 13:28:49 -0700 (In reply to comment #3) > It's not clear to me why we can't support customizable padding on search > fields, so I don't really understand why we'd prevent that? In the facebook example, if you allowed them to set padding, the search field's own magnifying glass will be offset to far to the right. I think they specify padding in order for the text to not overlap the magnifying glass that comes from the background-image. If WebKit ignores the background-image and supplies its own magnifying glass, then it had better ignore the padding as well. 120725 6 hyatt 2009-05-11 14:17:44 -0700 Yeah, sounds like we're just stuck being rigidly uncustomizable like Mac just for compatibility. The padding needs to be locked from code rather than in the stylesheet though if we do this, since you should be able to customize padding when -webkit-appearance is turned off for input[type=search]. 120737 7 30206 alice.barraclough 2009-05-11 16:02:21 -0700 Created attachment 30206 patch with test case 120742 8 30206 aroben 2009-05-11 16:25:48 -0700 Comment on attachment 30206 patch with test case Maybe we should add a comment to adjustSearchFieldStyle saying why overriding the padding is important (probably referencing this bug)? 127749 9 eric 2009-06-23 17:22:31 -0700 Did this ever land? 127751 10 mitz 2009-06-23 17:24:57 -0700 Fixed by Alice in <http://trac.webkit.org/changeset/43522>. 30198 2009-05-11 12:49:24 -0700 2009-05-11 12:49:24 -0700 screenshot FBreduction.PNG image/png 6553 alice.barraclough iVBORw0KGgoAAAANSUhEUgAAAK0AAABpCAYAAABI1qPhAAAAAXNSR0IArs4c6QAAAARnQU1BAACx jwv8YQUAAAAgY0hSTQAAeiYAAICEAAD6AAAAgOgAAHUwAADqYAAAOpgAABdwnLpRPAAAGRdJREFU eF7tnYl3E9e9x/P+n573mjZtltcspH1Jmva0rz1pevKapekJCU3SBEIgbAFCWWKMY4MhgDHEYLxv GFt4kS1vkiXvi7zi3QbbGO8bNtv3/X5XGlkajRYLy4Zwdfw9lmbu+pvP/OZ371yN/gNPPEF/8iUt 8AhZgKGVkjZ4lBhgNyugrW1og7myAYZiM7KvFCI59TJ+OB+PsPBIfLllO55d93tMzt1FTe+8UHXv nFBJ0zC+v5gNfnX2jUlJGwSNAYXVZUD7O4L2jju0VgmtPFlXx1m5QVtd34byigYUFJlxmTxtEnna szHxOPJdJDaTp31mnQ1am4edRXXPLGpIJdYh8rRZwtMaq3ulpA2CxoDf0IaGRWLT5q/wzEuvC2ir emaW1D2D4sZBnIi9jNNRZ6SkDYLKgF/QRv8Qh4Mh4fjon5+Rp7VBy961pmeOwgTWLEqdYlrhbuVL WiBYFrCPvxwxrVZ4EHU2Frt278cf//xXh6cVYQEBW9vHmkdZ8zBOxtkGYvIlLRBUC7hBW9cGk6UB egPFtLpCJCRn4sTpH/Dhxxvx6b8+X/K05F0Z1vr+W6gfuAVj6w2citcFta2ycGkBYQFf0MYnZSI8 8jTe+8fH2L17N015UXgwfwd15GEbrt1C47UFNF5fQHnbTUQl5kirSgsE3wK+ob2E0O9OELQbBLRK TCu8LHlYBrZxcFFCG/xDJWtQLOAL2rjEDIQcicQ7f/8IX39t87RT83dRJ4BdRPPQbTSRLFdHcSZJ elpJ1ipYQA1tVW0rjOZ65BvKkZldgIsJGfiWoH2boN25a5c9PLiLBoK2afA2QXsHzcN3UNExiuhk Ce0qHDJZRaDQ1vfPw3rd5mVZZvK0UdLTSqBWwwLLgnan4ml5IDYvBmFWimc5TChvHZGzB6txwGQd 7rMHnsIDjmm379hpG4jR7IEYiPHMAUFbf20RxhZaeyDnaSVSq2EB/z3th9i+fYfj5gLfWODBWAMB Wz+wgDKG1r72wFu7U9KyIPX42WBFWVZDW1nTijIaiOUVluNSFg3E4mkgFsoDsQ+xbRtD+1tMiLUH tpsLdXRzgf/zgpnI85k+28bAytfjZYEVP+bu0LYQtHUErYmg1RO06TZo31uPrdu242k7tBW0SKaa b+EStDUEbTEtTZTQPl4w+tvbNYV2y1fbBLTjs7dR0TmNSl4wQ8BWUahgaBzCsQfwtMPTC0ipuY64 qmvoGZ3z1x4y3SNggTWF9sutBO2LNmjNnVOo6JoV4FZ2z6KwfjBgaE2dY3g10oLnw4x4KdyElyIs SK8bfHgPx7QVOp0V0/60sM+EpKQkIVOfPxl+fGmCDm1FdQtKyyk8KDAh47IesRweHI7E3yg8YGh/ +eJrAtryjkkCdxoWAtZM8BbUX8fRADztzZlFvBpmwo70FlyfmAd/PlrQhecPlqJ9eGZ5R5BhsgPC kOisfmG1vDo4td/Q9sGUpEPAzVD1xwb/A5Sn1VO/+7J8Myk51hTazVu+EtCOzdxGWdskTARuecc0 aQr5dQOIiMnw2TN1B9IrBvDKgRJMzC468t67fx9/jTAjiuDl1+Kde7h7775Dt+/eF9tcX2pA6HOw XJu/B1pAZ0LADtbfenxa3UuCVahjFaBtJk9bS57WSJ42XwzEeO0B38bdtHkLfvECQ7uIktZxlLVP wGhXbnU/ws8tH9ozuR14k7wqQ+n8+vhEJb7LaBWbYvRdeCvUjLdDTaRy/CPcgvruCQ1oPQDi4rGW PNW0Vee4dDs8mP0gWk3s1ZTy+ISwXeLFZb7NFh7Y0ni69LvmSeJwwqUd9rI167N3zRNQbicD1+VU nqOt9r661OHc3mlYdUt94CuTi038DYF8nDSrDy2tPQiLOIl33v8In2/6UkA7Or0IQ/MoiprHUNwy LpRd2Ycj0ek+z3l1B6xd43jpMx1KKCZWXq29E3htSx4MdUNi0/TcbWw8bsGvtxZj3Rd6pBT3aNbT p0Dk4mGdDqgozEM8yrEn57ODtVSE7cC6FKlOw3m1DrBLXTaIlXIEHJr1OXVNKzyw18N9dbRJaTv5 dAe8zn311l7nNqpOhj7TA1wlnLqx6tDyKq/Ik2exfsPnePf99fjF868KaAutN2GwErhNY0JZll6E nlk+tBwKHIypwsufZODIxWocT6rFq5+l48WPLyOrzBYe8GuCZhc+OmTAyXSrzxMDyuDHCQrFI9r+ a3kl2q54Q2cAtSBXb/PmEZWytPJwO7xdnr3tc4AK6q6TR3W6Ijj66q29GifW0hXGt6n9SRF0aC3V zSgx1SJXbwsP4hIv4eTp89i+cx9+/8e/ODxtIQFbSLAarGMEMEFrDgxa7vTC7buIudyAv+24hL9s TcOJ5Bp8+Z0ez70Xgxxju8MuU7MLuHNXHct6Mpvd63i9xDoNapR0/gDpTxq1V19paGnuwqrjk4/6 6enEUEzjN7RKBiW0eUQ8rRa0p8/EYv+hMHzw4ScC2pvkaQsaR0k3UdBwE3r6n1nejZDTqT5PPG9n 3T0ebNmhnJlbwIZ9KXjyjTBkFzeB93l98YFxvoY7DpTrZdlRhupAisu1lqcVcGiEB768sVso4iU8 8BQ7evO0ItLR0WDT5DRL4l9fXUIk55CA3pscUx3c75WZqVgTTxt19iIOHY7AZxu3LnnapnHhaVkF 5Gkvl/cgJCrtgaBVZ56amcfbW87g5XcPg9/7oNZlUOEyNaSODZ3iQiVs0PHB14TWHgdrDMQcE2r+ hAcKxI5yXAdimpNzWjGt85SXKgYV9tHqq48rgzIW0FnbXQacKzVluArQNlF4UEPhQRmFB3kUHmSA oQ0JPYqNX/CU129FTFvUPE6x7ARBy/COU0zbRzFtxopCy4WNjE6ioTXgSSOf7ZEJgm+BhwNamqct bplEUcsEwWtTtqU/KNAG36SyhmBbIOjQllc1odhYgyv5ZUjLzBNftzkdzeHBUXxOnvZpesIM31wo bZtGcdsUiltt0tGagbBzcpVXsAF4FMt/CKD9HUF7h6CdQQmByyom6aqu+w2tXE8r19M+0MmnXpro 09O++DrFtLbwwEBhAauQlFXRj8PRvmPaB2qszCwtwBZYLrRiymtqAXn1I8ipvUEaRk7NEFJK23Hg ZJI0qrRA8C2wbGiffw0jkwsE6g3oqodEWJBNSipqxb+PJwS/wbIGaQE1tKbKJhSV1UCXV4rUS3m0 NDEDp+jmAs/Tfr7pK/z8V6/gxsQtZFUOIJNmDNJNvaQexOZZsSc8VhpUWiD4FlgutD977jcYGp9D Wlk3kos7kGhoQ2JhK85mVWH74XPBb7CsQVogMGjnhYdNoQUtiUUEbXE7fsiuwY5QCa0kahUssFxo n2RPOzaHVGMXksjTxulbEF/YQp62Etu+PbMKLZZVPPYWWDa0z9qgTTN2I6WkE3EEbIKBw4Nqgjb6 sbenNMAqWGC50P7UDm0qQZtM0F7UNyOBQoSzFB5sC5HQrsIhk1UsF9r/euZlXB+dIVCvIq6gFTE5 DTRz0ISozApsOXhaGlRaIPgWUENrrGiCodQ25ZWSkYcLNOV1kqa8DobQ0kSa8vrps7/G4OisCA0S CdwLNNXFIUI0xbRbZUwb/AMma3C/I2assBK01XZocwnadIL2gh3arbB52lkahF1FPE13xeQ0Ija/ GVGXLNhyQHpaydQqWMDd0/oDLYUHBGxcQQvO6epxPteKU+lmbJbQrsIRk1W4rT3w5WmV8CCpuFN4 WgY2Vs8xLXnaQ1HSotICwbeAL097Pi4NJ6OWwgOGlsMDMRCjWJbDgxgC9/v0cvK0p4LfYFmDtIAW tIUlVcjOK6GBmHtMK27j0jxtMk15JZV04GIhhQmkaLqNuy3krDSotEDwLeDL06oHYj+jBTND4/PI MPcjjb79mlRCt3JJHNvuOBIT/AbLGqQF3KC1WFFYUo3sXJ7yysX5OJo9oPDgAE950bdxf/6rVzFM q7wuWa4h3TyAFGMv3dLtFVNfu+QqLwnUaljAI7S8NJHnaZ2hpXnap2g97Q1aT5tVdYOWJw4TvINC cQVt2HtMrqddjWP22NehBW0Bx7TkabWhfVVAe5mgzawiaCsGkUG6qG/F7oi4x96e0gCrYAGfntZx R4y+jUuelr9uMzRB31yoH8WV+pvQ1Y4IpZR24eAp3w/rWIUuySp+7BbwfBu3jL65kC9u4/JXyL8N PUYP6+DH17+OwfEF5DeOIZ+eLKMok77JcCLZ8GM3l+zfw2ABNbSXciqQdKkUF5LyEHX+Eo6ejEfI d9HYsTsU6/+5GT97juZpx28hr2HUoVx6n107JJYoHk800Bcck4X2f09S/vN70r9ZJ5avfZTHVSn0 eTlS5390Pn9Dff/muE17jydhb6QXHUuksYW29tD2PTTu8KXdlGb3UT8VkYCvI+KXrV2UR0s7w+Og yHm/83a3O2Ihh0Nx4OAh7P3mG/Fjd5u/3IJPP/0X/v7++/jfP/0JT/33b3BtbIG+Nj7pIn3jOHIp XMiuooGZuc9FGfQ5o7zXu+ipixnOsqdPp/8/FqXRtz0eRKnGHpqp8awU2pdCX4PyqFLaR2EcK9mH eCoziRZFeRXdFU0Uoq9dOauIPpMSfOqquEnlnC7ewGta7LLvc9lG+9ygHRwcRHd3N1paWlBTU4OS khJcuXIFFy9eRGhoKN566y0k1HTA2DtLTwOnh3WQij2oiLYXtUy5yUDbNNVM251USO+lbDYoYDVN epWe9gtZJxzKp/duIgeT50sN5ISExpZUT+81lEPbXFRH4x2/xGOim25peZs3uUE7NDSE3t5etLa2 ora2FmVlZcjJyUFiYiIiIyPx5ptv4ouIc8gZmKEfvptHWcesSjMovepZJbRPU+203UnF9F5qyQZF 9BQfRQZ671HkKAz0mKpCtchRFDpE8NPDVoToiulJetqnpwex6OlBg6x8P5VnpZPCD+XSuIilTqts 9/TfDdrh4WH09fWhvb0d9fX1KC8vh16vR1paGqKiouinRrfjuXW/RVRVJ/TX5uiXyBdh6bklZPah ctrvom76TDLbxe8fF5morz7VRWkcmoexi9TpS3Mo6yR1eFYpOZrSq95VQvuFc1mu83A6uZxPNK33 fHIpcjkpnbY7p1Heu0E7MjKCgYEBdHZ2wmq1oqKiAkVFRbh8+TJiY2Nx4MABvPfee3hl/SbsqejA dx0TSKdfb6zoWdCUhbZrqpu222WmNMuVx3I91bfK2332h/puXpZsJ7c4qQlkz5on0EkEtycZCWoh ApvlGXC6ivqAewl+urqqrpbOV07N9/bnwPGz4ITs+R2f1fvtn92gHR0dhTquLS0tFSFCamoqjh8/ jj179uCdd94RHvfdYxfwu/w6/MR6X0raYFUYcIN2bGwMHNf29/e7hAgFBQXIzMxETEwMIiIisHfv XmzcuBGvvfYaXnjlD3jquXVCP/3lr/CfTz2Hnzz5tJS0QVAYcIN2YmICN27ccAkRqqqqxCwCe9v0 9HQRJpw6dQphYWHYt2+fiHM3bdqETz75BBs2bMD69evxwQcfSEkbBIUBN2inpqbAIcL169fFLEJb W5sYkJnNZhgMBvpdAp0IExjc6OhoES4cOXJExLrsfXft2oUdO3Zg27ZtUtIGQWHADdqZmRmMj48L b3vt2jUxZ9vc3CzmbPmXVDhMyM7OFuDGxcXh3LlzOH36tIA3PDxcABwSEoJDhw7h4MGDUtIGK86A G7Szs7OYnJwU3laZ/uro6BAzCdXV1Q5w2eNmZGSI+Vv2ugwvT4l9//33AuBjx47h6NGjUtIGK86A G7Tz8/Ngb8ux7c2bNx1hwtWrVwW4J39Iw7GoBISduICQiLPYH3oSew9FYvf+cOz85gi27Q7B1q8P YcvOA1LSBg4Gzp49i5WSG7QLCwuYm5tzgKuECT09PWBwo+OyxJ0yi8UCngorLCxEbm6uCBl4doEH ahw6pKSkIDk5WUraALsPRKwoB27QLi4u4tatWwLc6elpR3yrDMwupOSLdQk8OONwgeHlW718A4IB zsvLExDzegUOIaSkDQ6GRa0oB27Q3r59Gwq4HN/ybAIPzPhOGd90SLhUJAZnPKvQ1NSEhoYGMUir rKwUMwxGo1FAzF5YStqAGQg/eXFFWXCD9s6dO9ACV4lxU3RGMYfL02FdXV0iZODFNQrAdXV1Inxg kKWkDZiBUzFpK8qCG7T37t2DGlwlVGBwM3ItYjqMvS7Dy4tr2OsazXUoM9fST5RW04/nVaG4rAoN jU0ilPBHZVX1iEgtRmhKMfTltX7l8adcmcY/+wfTTj8k6Fb0eLpBe//+ffrF73v0a+B3HfByjMuz ChwuXNZXiZkFvt3L8PYPXEdNQztKzA0oMtXBYKxFYVm1kLmqEe1XO8GDOG9KLa7DC3sz8IudKXjm 61Q8s5t+nERX4TOfr3KDtt+aS1N8ubD66Jeo32Rbr8FKpR9UCVqb/GnLGqWJSy9c0X5rQqsFLs8q MLi6ojoxs8CxLsPb1NoLc20byqtbxPQY35Do67+GUnr6IouB5u2eZO3oxUt7MvHZ2RLUtnaBP+9L MuPp7Rkoa+jwmtetzKsGxNLtZb7FzIqlVe7e6g54H9cTa8BVL/2ylV2JzFOxMFz13H+vbVD1x9av ByhPq71+9yXAPlCdyVmlK3ocPEKrgKuEC0rIkFPS4JhdYHhrmrpR3dgl5nR5wMYeWLkxYaltB4s/ e9L5/Eas25mFrv4hR5oRKutPB3IRnl4jtg0Nj+DGyE2Hhm7cFNtcy6zHlehElPUqddHnK/Ve6/bW Lq/7esvopkoZer30S+TndNFXUO8rnaf9/tYTaPlKG/3pywPUwSFlwLbWqNcrtM7gKuFCXlmTY3aB PW89/ax9fUufuIvGELN4qmx0bEIAzeLPnhSZUY8/78nFxOSUS5r1YcU4FF8ttp3KbMQb+wvx1/16 UgHe+dYAk3VAVWYz9DF6NGvVNWhBKq1O4xVqMTGpsAza2jNoSbVvc9rOaVMtsOh5m1Iel63kj4G+ xjmNbbu+Wd1H1zwxVOagSzvsZWvWZy/Lvm9Q3SdRjnNfnfqu1VeXOpzbOwhL6lK/UumhKy424TZ7 OXbejqvzvqzCGq8M+FuOks4NWuUbwgyss9jjsvSmFhHv8gwDy0qXvsb2a5ianhUemEFWBm71rf0E db/Y5knVzYN44eMM5Fd0O9LUtQ3hfzZlIcfSI7aNjE7h0/ASrPsiDy9+lo24vFbN8toNseKWcqyh 3Wl/Owx0KW9X2jBSTbefqzGiblM7XfI5H++nMgztSptHUJ3h/Jm2q9NwXq0yXeridiyVM1Kd4aE+ J1vZ6xF9UmSvh/vqaKPS9nkPffXWXuc2inRLtmqnBVIOu3k5ht6OL++7UlzvlQFf+dX7PULrCd6C 8lbHQI3h7bs+jubOQTR1DGJ27pZDTQRzz8CokAK41v8Fupnx77NmrPtnCkLOW3A0vhKvfJqMFzak I6Oo3ZF3ZGwG6/fn43hyndfyRB2dJYiPj0c8fZv09lgdMvm9i0rQyenU+zLrKLyh9PzfflKKNM6f lXy+0qjTaZUbT+3QKt9b3co+7iP3jz53lmSibkyjP6LPGnU41+lSfydKlDxKPSvwn6/O3hhY7j6f 0KrhZWidPfDC4h0MDE6gpWvYRf2D4+Iz/5+/tSi8syfN0f5zl+rwf9vT8caWFEQmVmHzkTw8++45 6EpbHfnGp+awsHjba1lLdfSgLKEMPRMNyMpqwIS6ft6ekIWGCXu7lHTq9Fr5/UnD9Tmn08rjrX3q /G72m0BDFvXvLvVT6Z+3vjrbwFu7RD1suwQkcPu8HDdvx9R5n3J19je9r3R+Q6vAW2huc3nGCAMs wB2a1FRrNy0op32cRh1yqD/fvctzxHdFuunZW/jom2Q8+cYRZBVZyZD3vOefakQ2Pb3RUSZ/zm7E 1P1eGGklmrHXNdy579hv2z7VmI1ETq/afv/+FBqzVfnVadzy2Oty2e7aDlEft9dTXg7PvO2zt5nv QGY3Ttn77V9fXcrlOhKN6LXXZ3SUxf3ORuOUym6qsNHXMeX9akfnTx5vaR4YWm9PyVm8fRfXhqfQ 1mMb6S/3NTUzj7e3nMHL7x4Gv/f+moZVl4SkJEU6WKftOaat0Dm2036dFbyrz7SUXkdrhXW8ndPa 9zvqU+U3tanSaOXhzOrtLuWY0KeVxrmT6naLPqj7ZS9HyafVV612OPVRsYPO2g6Tk510DgMu98i5 plc7ugcrjXKrH4vkq0AtT+sPuAxvIK+R0Uk00AyFfD26FnjooH10TSlbvloWkNCulqVlPStmAQnt iplSFrRaFpDQrpalZT0rZoGHAlpuhJS0wXIYWLEzgAta7uzBilYuC5MWCMQCEtpArCbzrKkFJLRr an5ZeSAWkNAGYjWZZ00tIKFdU/PLygOxgIQ2EKvJPGtqAQntmppfVh6IBSS0gVhN5llTC0ho19T8 svJALCChDcRqMs+aWkBCu6bml5UHYgEJbSBWk3nW1AIS2jU1v6w8EAtIaAOxmsyzphaQ0K6p+WXl gVjADVr7BmXNovz/hGP9prTFw2WLJ+QBebgOiDwevo/H/wNhBC/ieW09HQAAAABJRU5ErkJggg== 30199 2009-05-11 12:50:28 -0700 2009-05-11 16:02:21 -0700 proposed patch without testcase patchFBsearch.txt text/plain 1145 alice.barraclough SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzUwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTEgQEAKKzIwMDktMDUtMTEgIEFsaWNlIExpdSAgPGFsaWNlLmxpdUBhcHBsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0FS TklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisKKyAgICAgICAgKiBjc3MvdGhl bWVXaW4uY3NzOiByZXN0b3JlIHNlYXJjaGZpZWxkIGFwcGVhcmFuY2UgYW5kIHBhZGRpbmcgdG8g c2VhcmNoZmllbGRzCisKIDIwMDktMDUtMTEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9j c3MvdGhlbWVXaW4uY3NzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL3RoZW1lV2luLmNzcwko cmV2aXNpb24gNDMzOTcpCisrKyBXZWJDb3JlL2Nzcy90aGVtZVdpbi5jc3MJKHdvcmtpbmcgY29w eSkKQEAgLTM1LDExICszNSwxMSBAQAogaW5wdXQ6bm90KFt0eXBlXSksIAogaW5wdXRbdHlwZT0i dGV4dCJdLAogaW5wdXRbdHlwZT0icGFzc3dvcmQiXSB7Ci0gICAgcGFkZGluZzoxcHggMDsKKyAg ICBwYWRkaW5nOjFweCAwICFpbXBvcnRhbnQ7CiB9CiAKIGlucHV0W3R5cGU9InNlYXJjaCJdIHsK LSAgICBwYWRkaW5nOjFweDsKKyAgICBwYWRkaW5nOjFweCAhaW1wb3J0YW50OwogfQogCiBpbnB1 dFt0eXBlPSJjaGVja2JveCJdIHsKQEAgLTY2LDcgKzY2LDcgQEAgaW5wdXRbdHlwZT0ic2VhcmNo Il06ZGlzYWJsZWQgewogfQogCiBpbnB1dFt0eXBlPSJzZWFyY2giXSB7Ci0gICAgLXdlYmtpdC1h cHBlYXJhbmNlOiB0ZXh0ZmllbGQ7CisgICAgLXdlYmtpdC1hcHBlYXJhbmNlOiBzZWFyY2hmaWVs ZDsKIH0KIAogaW5wdXRbdHlwZT0ic2VhcmNoIl06Oi13ZWJraXQtc2VhcmNoLWNhbmNlbC1idXR0 b24gewo= 30206 2009-05-11 16:02:21 -0700 2009-05-11 16:32:32 -0700 patch with test case patch25071.txt text/plain 6698 alice.barraclough SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzUxOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMDktMDUtMTEgIEFsaWNlIExpdSAgPGFsaWNlLmxpdUBhcHBsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NzAxCisgICAgICAgIFJFR1JF U1NJT04ocjM4Nzg4ICYgcjQyMDIwKTogc3R5bGVkIHNlYXJjaGZpZWxkcyBsb29rIHdyb25nIG9u IFdpbmRvd3MsIGFmZmVjdHMgRmFjZWJvb2sKKworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL3Nl YXJjaC1zdHlsZWQuaHRtbAorCisgICAgICAgICogY3NzL3RoZW1lV2luLmNzczoKKyAgICAgICAg UmVtb3ZlIHRoZSBvdmVycmlkaW5nIG9mIC13ZWJraXQtYXBwZWFyYW5jZSBmb3Igc2VhcmNoZmll bGRzLiBUaGlzIHdpbGwgY2F1c2UgYmFja2dyb3VuZAorICAgICAgICBpbWFnZXMgdG8gbm90IGJl IGhvbm9yZWQgd2hlbiBzdHlsaW5nIHNlYXJjaGZpZWxkcworCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlclRoZW1lV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lV2luOjph ZGp1c3RTZWFyY2hGaWVsZFN0eWxlKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVX aW4uaDoKKyAgICAgICAgUmUtaW5zdGF0ZSBmaW5hbCBhZGp1c3RtZW50cyB0byBzZWFyY2hmaWVs ZCBzdHlsaW5nIHRoYXQgd2VyZSByZW1vdmVkIGluIHI0MjAyMAorCiAyMDA5LTA1LTExICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggV2luZG93cyBidWls ZApJbmRleDogV2ViQ29yZS9jc3MvdGhlbWVXaW4uY3NzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv Y3NzL3RoZW1lV2luLmNzcwkocmV2aXNpb24gNDMzOTcpCisrKyBXZWJDb3JlL2Nzcy90aGVtZVdp bi5jc3MJKHdvcmtpbmcgY29weSkKQEAgLTY1LDEwICs2NSw2IEBAIGlucHV0W3R5cGU9InNlYXJj aCJdOmRpc2FibGVkIHsKICAgICBiYWNrZ3JvdW5kLWNvbG9yOiAjRUJFQkU0OyAKIH0KIAotaW5w dXRbdHlwZT0ic2VhcmNoIl0gewotICAgIC13ZWJraXQtYXBwZWFyYW5jZTogdGV4dGZpZWxkOwot fQotCiBpbnB1dFt0eXBlPSJzZWFyY2giXTo6LXdlYmtpdC1zZWFyY2gtY2FuY2VsLWJ1dHRvbiB7 CiAgICBtYXJnaW4tcmlnaHQ6IDNweDsgCiB9CkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUaGVtZVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhl bWVXaW4uY3BwCShyZXZpc2lvbiA0MzM5NykKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzgwLDYgKzc4MCwxNiBAQCBib29sIFJlbmRl clRoZW1lV2luOjpwYWludFNlYXJjaEZpZWxkKFJlCiAgICAgcmV0dXJuIHBhaW50VGV4dEZpZWxk KG8sIGksIHIpOwogfQogCit2b2lkIFJlbmRlclRoZW1lV2luOjphZGp1c3RTZWFyY2hGaWVsZFN0 eWxlKENTU1N0eWxlU2VsZWN0b3IqIHNlbGVjdG9yLCBSZW5kZXJTdHlsZSogc3R5bGUsIEVsZW1l bnQqIGUpIGNvbnN0Cit7CisgICAgLy8gT3ZlcnJpZGUgcGFkZGluZ1NpemUgdG8gbWF0Y2ggQXBw S2l0IHRleHQgcG9zaXRpb25pbmcuCisgICAgY29uc3QgaW50IHBhZGRpbmcgPSAxOworICAgIHN0 eWxlLT5zZXRQYWRkaW5nTGVmdChMZW5ndGgocGFkZGluZywgRml4ZWQpKTsKKyAgICBzdHlsZS0+ c2V0UGFkZGluZ1JpZ2h0KExlbmd0aChwYWRkaW5nLCBGaXhlZCkpOworICAgIHN0eWxlLT5zZXRQ YWRkaW5nVG9wKExlbmd0aChwYWRkaW5nLCBGaXhlZCkpOworICAgIHN0eWxlLT5zZXRQYWRkaW5n Qm90dG9tKExlbmd0aChwYWRkaW5nLCBGaXhlZCkpOworfQorCiBib29sIFJlbmRlclRoZW1lV2lu OjpwYWludFNlYXJjaEZpZWxkQ2FuY2VsQnV0dG9uKFJlbmRlck9iamVjdCogbywgY29uc3QgUmVu ZGVyT2JqZWN0OjpQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgSW50UmVjdCYgcikKIHsKICAg ICBJbnRSZWN0IGJvdW5kcyA9IHI7CkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt ZVdpbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmgJ KHJldmlzaW9uIDQzMzk3KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uaAko d29ya2luZyBjb3B5KQpAQCAtOTksNiArOTksNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBpbnQg YnV0dG9uSW50ZXJuYWxQYWRkaW5nVG9wKCkgY29uc3Q7CiAgICAgdmlydHVhbCBpbnQgYnV0dG9u SW50ZXJuYWxQYWRkaW5nQm90dG9tKCkgY29uc3Q7CiAKKyAgICB2aXJ0dWFsIHZvaWQgYWRqdXN0 U2VhcmNoRmllbGRTdHlsZShDU1NTdHlsZVNlbGVjdG9yKiwgUmVuZGVyU3R5bGUqLCBFbGVtZW50 KikgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIHBhaW50U2VhcmNoRmllbGQoUmVuZGVyT2JqZWN0 KiwgY29uc3QgUmVuZGVyT2JqZWN0OjpQYWludEluZm8mLCBjb25zdCBJbnRSZWN0Jik7CiAKICAg ICB2aXJ0dWFsIHZvaWQgYWRqdXN0U2VhcmNoRmllbGRDYW5jZWxCdXR0b25TdHlsZShDU1NTdHls ZVNlbGVjdG9yKiwgUmVuZGVyU3R5bGUqLCBFbGVtZW50KikgY29uc3Q7CkluZGV4OiBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZp c2lvbiA0MzUxOSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE0IEBACisyMDA5LTA1LTExICBBbGljZSBMaXUgIDxhbGljZS5saXVAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTcwMQorICAgICAgICBSRUdSRVNT SU9OKHIzODc4OCAmIHI0MjAyMCk6IHN0eWxlZCBzZWFyY2hmaWVsZHMgbG9vayB3cm9uZyBvbiBX aW5kb3dzLCBhZmZlY3RzIEZhY2Vib29rCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3NlYXJjaC1z dHlsZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2Zhc3QvZm9ybXMvc2Vh cmNoLXN0eWxlZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL3dpbi9m YXN0L2Zvcm1zL3NlYXJjaC1zdHlsZWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAwOS0wNS0x MSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlYXJjaC1zdHls ZWQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlYXJjaC1zdHls ZWQuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoLXN0 eWxlZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE1IEBACis8IURPQ1RZUEUgaHRtbCBQ VUJMSUMgIi0vL1czQy8vRFREIFhIVE1MIDEuMCBTdHJpY3QvL0VOIgorICAgImh0dHA6Ly93d3cu dzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXN0cmljdC5kdGQiPgorPGh0bWwgeG1sbnM9Imh0 dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiIHhtbDpsYW5nPSJlbiIgbGFuZz0iZW4iPgorPGhl YWQ+Cis8c3R5bGU+CisuaW5wdXR0ZXh0LAorLmlucHV0cGFzc3dvcmR7Ym9yZGVyOjFweCBzb2xp ZCAjYmRjN2Q4O2ZvbnQtZmFtaWx5OiJsdWNpZGEgZ3JhbmRlIiwgdGFob21hLCB2ZXJkYW5hLCBh cmlhbCwgc2Fucy1zZXJpZjtmb250LXNpemU6MTFweDtwYWRkaW5nOjNweDt9CisuaW5wdXRzZWFy Y2h7YmFja2dyb3VuZDp3aGl0ZSB1cmwoLi9yZXNvdXJjZXMvYXBwbGUuZ2lmKSBuby1yZXBlYXQg M3B4IDRweDtwYWRkaW5nLWxlZnQ6MTdweDt9Cis8L3N0eWxlPgorCis8L2hlYWQ+Cis8Ym9keT4K KzxpbnB1dCB0eXBlPSJzZWFyY2giIGNsYXNzPSJpbnB1dHRleHQgaW5wdXRzZWFyY2giIHRpdGxl PSJTZWFyY2ggZm9yIEV2ZW50cyIgcGxhY2Vob2xkZXI9IlNlYXJjaCBmb3IgRXZlbnRzIiBpZD0i cV9kYXNoYm9hcmQiIG5hbWU9InEiIHZhbHVlPSIiIHJlc3VsdHM9IjEwIiAvPgorPC9ib2R5Pgor PC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvZm9ybXMvc2VhcmNo LXN0eWxlZC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL2Zhc3QvZm9ybXMvc2VhcmNoLXN0eWxlZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9mb3Jtcy9zZWFyY2gtc3R5bGVkLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNiBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6 ZSA4MDB4NjAwCisgIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAo MCwwKSBzaXplIDgwMHgzOQorICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA4MDB4 MzkKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBzaXplIDc4NHgyMworICAgICAgUmVu ZGVyVGV4dENvbnRyb2wge0lOUFVUfSBhdCAoMiwyKSBzaXplIDE0OHgxOSBbYmdjb2xvcj0jRkZG RkZGXSBbYm9yZGVyOiAoMnB4IGluc2V0ICMwMDAwMDApXQorICAgICAgICBSZW5kZXJCbG9jayB7 RElWfSBhdCAoMywzKSBzaXplIDE0MngxMworICAgICAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0 ICgwLDApIHNpemUgMjJ4MTEKKyAgICAgICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMTI5LDAp IHNpemUgMTN4MTEKKyAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDB4MAor ICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMHgwCisgICAgICBSZW5kZXJU ZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKK2xheWVyIGF0ICgzNSwxMykgc2l6ZSAxMDd4 MTMKKyAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDIyLDApIHNpemUgMTA3eDEzIFtjb2xvcj0jQTlB OUE5XQorICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMSwwKSBzaXplIDkzeDEzCisgICAgICB0 ZXh0IHJ1biBhdCAoMSwwKSB3aWR0aCA5MzogIlNlYXJjaCBmb3IgRXZlbnRzIgpJbmRleDogTGF5 b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zhc3QvZm9ybXMvc2VhcmNoLXN0eWxlZC1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zhc3QvZm9ybXMvc2Vh cmNoLXN0eWxlZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS93aW4vZmFzdC9mb3Jtcy9zZWFyY2gtc3R5bGVkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSwxNiBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRl clZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBzaXplIDgwMHgzOQor ICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA4MDB4MzkKKyAgICBSZW5kZXJCb2R5 IHtCT0RZfSBhdCAoOCw4KSBzaXplIDc4NHgyMworICAgICAgUmVuZGVyVGV4dENvbnRyb2wge0lO UFVUfSBhdCAoMiwyKSBzaXplIDE1MngxOSBbYmdjb2xvcj0jRkZGRkZGXSBbYm9yZGVyOiAoMnB4 IGluc2V0ICMwMDAwMDApXQorICAgICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMywzKSBzaXpl IDE0NngxMworICAgICAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDApIHNpemUgMjJ4MTEK KyAgICAgICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMTMzLDApIHNpemUgMTN4MTEKKyAgICAg IFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDB4MAorICAgICAgUmVuZGVyVGV4dCB7 I3RleHR9IGF0ICgwLDApIHNpemUgMHgwCisgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAs MCkgc2l6ZSAweDAKK2xheWVyIGF0ICgzNSwxMykgc2l6ZSAxMTF4MTMKKyAgUmVuZGVyQmxvY2sg e0RJVn0gYXQgKDIyLDApIHNpemUgMTExeDEzIFtjb2xvcj0jQTlBOUE5XQorICAgIFJlbmRlclRl eHQgeyN0ZXh0fSBhdCAoMSwwKSBzaXplIDkzeDEzCisgICAgICB0ZXh0IHJ1biBhdCAoMSwwKSB3 aWR0aCA5MzogIlNlYXJjaCBmb3IgRXZlbnRzIgo=