25700 2009-05-11 12:18:26 -0700 Regression:WebKit:cmd-left and cmd-right use to go to the beginning and end of a line in Mail 2009-05-11 18:10:42 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach webkit-unassigned oldest_to_newest 120701 0 cfleizach 2009-05-11 12:18:26 -0700 • launch VoiceOver, and interact with a mail message, • press (cmd-left arrow), • the cursor should move to the begining of the line, and cmd-right, should move the cursor to the end of the line 120702 1 30197 cfleizach 2009-05-11 12:20:51 -0700 Created attachment 30197 patch 120703 2 cfleizach 2009-05-11 12:21:36 -0700 not sure how to add a regression test for this. original implementation with that handled option and shift did not have a regression test 120758 3 cfleizach 2009-05-11 18:10:42 -0700 http://trac.webkit.org/changeset/43532 30197 2009-05-11 12:20:51 -0700 2009-05-11 17:30:38 -0700 patch patch.txt text/plain 3197 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzUwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDUtMTEgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWcgMjU3MDA6IFJlZ3Jlc3Npb246V2ViS2l0OmNtZC1sZWZ0IGFuZCBjbWQtcmlnaHQgdXNl IHRvIGdvIHRvIHRoZSBiZWdpbm5pbmcgYW5kIGVuZCBvZiBhIGxpbmUgaW4gTWFpbAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU3MDAKKworICAgICAg ICBLZXlib2FyZCBzZWxlY3Rpb24gbW92ZW1lbnQgaGFuZGxlcnMgbmVlZCB0byBhbHNvIHdhdGNo IGZvciB0aGUgQ21kIGtleSB3aGVuIEFjY2Vzc2liaWxpdHkgaXMgZW5hYmxlZC4KKyAgICAgICAg Tm90ZTogVGhpcyBjb2RlIGlzIG9ubHkgdXNlZCB3aGVuIGFjY2Vzc2liaWxpdHkgaXMgZW5hYmxl ZC4KKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkV2ZW50SGFuZGxlcjo6aGFuZGxlS2V5Ym9hcmRTZWxlY3Rpb25Nb3ZlbWVudCk6CisKIDIwMDkt MDUtMTEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAJKHJldmlzaW9uIDQz MzQ2KQorKysgV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE5NjksMjEgKzE5NjksMjIgQEAgdm9pZCBFdmVudEhhbmRsZXI6OmhhbmRsZUtleWJvYXJkU2Vs ZWN0aQogICAgIFN0cmluZyBrZXkgPSBldmVudC0+a2V5SWRlbnRpZmllcigpOyAgICAgICAgICAg CiAgICAgYm9vbCBpc1NoaWZ0ZWQgPSBldmVudC0+Z2V0TW9kaWZpZXJTdGF0ZSgiU2hpZnQiKTsK ICAgICBib29sIGlzT3B0aW9uZWQgPSBldmVudC0+Z2V0TW9kaWZpZXJTdGF0ZSgiQWx0Iik7Cisg ICAgYm9vbCBpc0NvbW1hbmRlZCA9IGV2ZW50LT5nZXRNb2RpZmllclN0YXRlKCJNZXRhIik7CiAg ICAgCiAgICAgaWYgKGtleSA9PSAiVXAiKSB7Ci0gICAgICAgIG1fZnJhbWUtPnNlbGVjdGlvbigp LT5tb2RpZnkoKGlzU2hpZnRlZCkgPyBTZWxlY3Rpb25Db250cm9sbGVyOjpFWFRFTkQgOiBTZWxl Y3Rpb25Db250cm9sbGVyOjpNT1ZFLCBTZWxlY3Rpb25Db250cm9sbGVyOjpCQUNLV0FSRCwgTGlu ZUdyYW51bGFyaXR5LCB0cnVlKTsKKyAgICAgICAgbV9mcmFtZS0+c2VsZWN0aW9uKCktPm1vZGlm eSgoaXNTaGlmdGVkKSA/IFNlbGVjdGlvbkNvbnRyb2xsZXI6OkVYVEVORCA6IFNlbGVjdGlvbkNv bnRyb2xsZXI6Ok1PVkUsIFNlbGVjdGlvbkNvbnRyb2xsZXI6OkJBQ0tXQVJELCAoaXNDb21tYW5k ZWQpID8gRG9jdW1lbnRCb3VuZGFyeSA6IExpbmVHcmFudWxhcml0eSwgdHJ1ZSk7CiAgICAgICAg IGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwogICAgIH0KICAgICBlbHNlIGlmIChrZXkgPT0g IkRvd24iKSB7IAotICAgICAgICBtX2ZyYW1lLT5zZWxlY3Rpb24oKS0+bW9kaWZ5KChpc1NoaWZ0 ZWQpID8gU2VsZWN0aW9uQ29udHJvbGxlcjo6RVhURU5EIDogU2VsZWN0aW9uQ29udHJvbGxlcjo6 TU9WRSwgU2VsZWN0aW9uQ29udHJvbGxlcjo6Rk9SV0FSRCwgTGluZUdyYW51bGFyaXR5LCB0cnVl KTsKKyAgICAgICAgbV9mcmFtZS0+c2VsZWN0aW9uKCktPm1vZGlmeSgoaXNTaGlmdGVkKSA/IFNl bGVjdGlvbkNvbnRyb2xsZXI6OkVYVEVORCA6IFNlbGVjdGlvbkNvbnRyb2xsZXI6Ok1PVkUsIFNl bGVjdGlvbkNvbnRyb2xsZXI6OkZPUldBUkQsIChpc0NvbW1hbmRlZCkgPyBEb2N1bWVudEJvdW5k YXJ5IDogTGluZUdyYW51bGFyaXR5LCB0cnVlKTsKICAgICAgICAgZXZlbnQtPnNldERlZmF1bHRI YW5kbGVkKCk7CiAgICAgfQogICAgIGVsc2UgaWYgKGtleSA9PSAiTGVmdCIpIHsKLSAgICAgICAg bV9mcmFtZS0+c2VsZWN0aW9uKCktPm1vZGlmeSgoaXNTaGlmdGVkKSA/IFNlbGVjdGlvbkNvbnRy b2xsZXI6OkVYVEVORCA6IFNlbGVjdGlvbkNvbnRyb2xsZXI6Ok1PVkUsIFNlbGVjdGlvbkNvbnRy b2xsZXI6OkxFRlQsIChpc09wdGlvbmVkKSA/IFdvcmRHcmFudWxhcml0eSA6IENoYXJhY3Rlckdy YW51bGFyaXR5LCB0cnVlKTsKKyAgICAgICAgbV9mcmFtZS0+c2VsZWN0aW9uKCktPm1vZGlmeSgo aXNTaGlmdGVkKSA/IFNlbGVjdGlvbkNvbnRyb2xsZXI6OkVYVEVORCA6IFNlbGVjdGlvbkNvbnRy b2xsZXI6Ok1PVkUsIFNlbGVjdGlvbkNvbnRyb2xsZXI6OkxFRlQsIChpc0NvbW1hbmRlZCkgPyBM aW5lQm91bmRhcnkgOiAoaXNPcHRpb25lZCkgPyBXb3JkR3JhbnVsYXJpdHkgOiBDaGFyYWN0ZXJH cmFudWxhcml0eSwgdHJ1ZSk7CiAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwog ICAgIH0KICAgICBlbHNlIGlmIChrZXkgPT0gIlJpZ2h0IikgewotICAgICAgICBtX2ZyYW1lLT5z ZWxlY3Rpb24oKS0+bW9kaWZ5KChpc1NoaWZ0ZWQpID8gU2VsZWN0aW9uQ29udHJvbGxlcjo6RVhU RU5EIDogU2VsZWN0aW9uQ29udHJvbGxlcjo6TU9WRSwgU2VsZWN0aW9uQ29udHJvbGxlcjo6UklH SFQsIChpc09wdGlvbmVkKSA/IFdvcmRHcmFudWxhcml0eSA6IENoYXJhY3RlckdyYW51bGFyaXR5 LCB0cnVlKTsKKyAgICAgICAgbV9mcmFtZS0+c2VsZWN0aW9uKCktPm1vZGlmeSgoaXNTaGlmdGVk KSA/IFNlbGVjdGlvbkNvbnRyb2xsZXI6OkVYVEVORCA6IFNlbGVjdGlvbkNvbnRyb2xsZXI6Ok1P VkUsIFNlbGVjdGlvbkNvbnRyb2xsZXI6OlJJR0hULCAoaXNDb21tYW5kZWQpID8gTGluZUJvdW5k YXJ5IDogKGlzT3B0aW9uZWQpID8gV29yZEdyYW51bGFyaXR5IDogQ2hhcmFjdGVyR3JhbnVsYXJp dHksIHRydWUpOwogICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKICAgICB9ICAg IAogfQo=