<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>256998</bug_id>
          
          <creation_ts>2023-05-18 17:45:31 -0700</creation_ts>
          <short_desc>[Website] payment-request demo backend has a syntax error</short_desc>
          <delta_ts>2023-05-22 14:22:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Website</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Mac (Apple Silicon)</rep_platform>
          <op_sys>macOS 13</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alex Zenla">alex</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>jond</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1956343</commentid>
    <comment_count>0</comment_count>
    <who name="Alex Zenla">alex</who>
    <bug_when>2023-05-18 17:45:31 -0700</bug_when>
    <thetext>Upon doing other things in WebKit, I noticed a syntax error in the backend code for the payment-request demo.

if (!$result = curl_exec($curlConnection))
    die(&apos;An error occurred when connecting to the validation URL.&apos;));

Running this code (note, I recognize this is a web PHP file, yet this will check the syntax) provides this error.


alex@sodium WebKit % php Websites/webkit.org/demos/payment-request/merchant-validation.php
PHP Parse error:  Unmatched &apos;)&apos; in /Users/alex/Developer/Web/WebKit/Websites/webkit.org/demos/payment-request/merchant-validation.php on line 94

Parse error: Unmatched &apos;)&apos; in /Users/alex/Developer/Web/WebKit/Websites/webkit.org/demos/payment-request/merchant-validation.php on line 94</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1956346</commentid>
    <comment_count>1</comment_count>
    <who name="Alex Zenla">alex</who>
    <bug_when>2023-05-18 17:52:41 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/14048</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1957096</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-05-22 14:21:06 -0700</bug_when>
    <thetext>Committed 264378@main (365d91ad2c52): &lt;https://commits.webkit.org/264378@main&gt;

Reviewed commits have been landed. Closing PR #14048 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1957097</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-05-22 14:22:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/109677760&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>