256929 2023-05-17 17:07:35 -0700 setSelectionRange will reset the m_latestFocusTrigger variable, causing the subsequently focused element to match the :focus-visible selector 2023-10-31 23:09:23 -0700 1 1 1 Unclassified WebKit DOM Safari 16 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 2471314 webkit-unassigned ews-watchlist mifenton rniwa simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1956056 0 466388 2471314 2023-05-17 17:07:35 -0700 Created attachment 466388 test case element.setSelectionRange() is used to modify the cursor position, if the element.focus() is called again subsequently, the focused element will incorrectly match the :focus-visible selector. 1956074 1 466389 2471314 2023-05-17 17:42:27 -0700 Created attachment 466389 Like Element::focusForBindings, set the trigger to FocusTrigger::Bindings 1957757 2 webkit-bug-importer 2023-05-24 17:08:15 -0700 <rdar://problem/109803748> 1959932 3 466389 rniwa 2023-06-05 13:09:30 -0700 Comment on attachment 466389 Like Element::focusForBindings, set the trigger to FocusTrigger::Bindings Thanks for the patch but this patch lacks appropriate commit message & a test, both of which need to be added in order for this code change to land. 1962524 4 2471314 2023-06-20 02:23:49 -0700 Pull request: https://github.com/WebKit/WebKit/pull/15092 1989083 5 ews-feeder 2023-10-31 23:09:21 -0700 Committed 270043@main (3d85c92f718f): <https://commits.webkit.org/270043@main> Reviewed commits have been landed. Closing PR #15092 and removing active labels. 466388 2023-05-17 17:07:35 -0700 2023-05-17 17:07:35 -0700 test case 44.html text/html 1216 2471314 PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KICA8aGVhZD4KICAgIDxtZXRhIGNoYXJz ZXQ9IlVURi04Ij4KICAgIDxtZXRhIGh0dHAtZXF1aXY9IlgtVUEtQ29tcGF0aWJsZSIgY29udGVu dD0iSUU9ZWRnZSI+CiAgICA8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0id2lkdGg9ZGV2 aWNlLXdpZHRoLCBpbml0aWFsLXNjYWxlPTEuMCwgbWF4aW11bS1zY2FsZT0xLjAiPgogICAgPHRp dGxlPnRvdWNoPC90aXRsZT4KICAgIDxzdHlsZT4KICAgICAgLmJ0biB7CiAgICAgICAgZGlzcGxh eTogaW5saW5lLWJsb2NrOwogICAgICAgIHdpZHRoOiAyNDBweDsKICAgICAgICBwYWRkaW5nOiA1 cHggMjBweDsKICAgICAgICBib3JkZXI6IDFweCBzb2xpZCAjYWFhOwogICAgICAgIHRleHQtYWxp Z246IGNlbnRlcjsKICAgICAgICB1c2VyLXNlbGVjdDogbm9uZTsKICAgICAgICAtd2Via2l0LXVz ZXItc2VsZWN0OiBub25lOwogICAgICAgIGN1cnNvcjogcG9pbnRlcjsKICAgICAgfQogICAgICA6 Zm9jdXMtdmlzaWJsZSB7CiAgICAgICAgb3V0bGluZTogc29saWQgdGhpY2sgZ3JlZW47CiAgICAg IH0KICAgIDwvc3R5bGU+CiAgPC9oZWFkPgogIDxib2R5PgogICAgPHAgaWQ9InRhcmdldCIgdGFi aW5kZXg9IjAiPlRoZSBmb2N1cy12aXNpYmxlIHN0eWxlIHNob3VsZCBub3QgYXBwZWFyIGFyb3Vu ZCB0aGlzIHRleHQ8L3A+CiAgICA8cCBpZD0ic2hvdyIgY2xhc3M9ImJ0biIgdGFiaW5kZXg9IjAi PmNsaWNrIHRvIGNhbGwgc2V0U2VsZWN0aW9uUmFuZ2U8L3A+CiAgICA8cCBpZD0iaGlkZSIgY2xh c3M9ImJ0biIgdGFiaW5kZXg9IjAiPmNsaWNrIHRvIGNhbGwgZm9jdXM8L3A+CiAgICA8aW5wdXQg aWQ9ImlucHV0IiB0eXBlPSJ0ZXh0IiAvPgogIDwvYm9keT4KICA8c2NyaXB0PgogICAgc2hvdy5h ZGRFdmVudExpc3RlbmVyKCdjbGljaycsIChlKSA9PiB7CiAgICAgIHNldFRpbWVvdXQoKCkgPT4g ewogICAgICAgIGlucHV0LnNldFNlbGVjdGlvblJhbmdlKDAsIDApOwogICAgICAgIHRhcmdldC5m b2N1cygpOwogICAgICB9LCAxMDApOwogICAgfSk7CiAgICBoaWRlLmFkZEV2ZW50TGlzdGVuZXIo J2NsaWNrJywgKGUpID0+IHsKICAgICAgc2V0VGltZW91dCgoKSA9PiB7CiAgICAgICAgaW5wdXQu Zm9jdXMoKTsKICAgICAgICB0YXJnZXQuZm9jdXMoKTsKICAgICAgfSwgMTAwKTsKICAgIH0pOwog IDwvc2NyaXB0Pgo8L2h0bWw+Cg== 466389 2023-05-17 17:42:27 -0700 2023-06-05 13:09:30 -0700 Like Element::focusForBindings, set the trigger to FocusTrigger::Bindings file_256929.txt text/plain 950 2471314 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwIGIv U291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHANCmluZGV4IGYzNmVjY2Zh ODk2Yi4uMWM0OGY4MmYxYmYxIDEwMDY0NA0KLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9G cmFtZVNlbGVjdGlvbi5jcHANCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxl Y3Rpb24uY3BwDQpAQCAtMjM0OCw3ICsyMzQ4LDcgQEAgdm9pZCBGcmFtZVNlbGVjdGlvbjo6c2V0 Rm9jdXNlZEVsZW1lbnRJZk5lZWRlZCgpDQogICAgICAgICAgICAgLy8gc28gYWRkIHRoZSAhaXNG cmFtZUVsZW1lbnQgY2hlY2sgaGVyZS4gVGhlcmUncyBwcm9iYWJseSBhIGJldHRlciB3YXkgdG8g bWFrZSB0aGlzDQogICAgICAgICAgICAgLy8gd29yayBpbiB0aGUgbG9uZyB0ZXJtLCBidXQgdGhp cyBpcyB0aGUgc2FmZXN0IGZpeCBhdCB0aGlzIHRpbWUuDQogICAgICAgICAgICAgaWYgKHRhcmdl dC0+aXNNb3VzZUZvY3VzYWJsZSgpICYmICFpc0ZyYW1lRWxlbWVudCh0YXJnZXQpKSB7DQotICAg ICAgICAgICAgICAgIENoZWNrZWRSZWYobV9kb2N1bWVudC0+cGFnZSgpLT5mb2N1c0NvbnRyb2xs ZXIoKSktPnNldEZvY3VzZWRFbGVtZW50KHRhcmdldCwgKm1fZG9jdW1lbnQtPmZyYW1lKCkpOw0K KyAgICAgICAgICAgICAgICBDaGVja2VkUmVmKG1fZG9jdW1lbnQtPnBhZ2UoKS0+Zm9jdXNDb250 cm9sbGVyKCkpLT5zZXRGb2N1c2VkRWxlbWVudCh0YXJnZXQsICptX2RvY3VtZW50LT5mcmFtZSgp LCB7IHsgfSwgeyB9LCB7IH0sIEZvY3VzVHJpZ2dlcjo6QmluZGluZ3MsIHsgfSB9KTsNCiAgICAg ICAgICAgICAgICAgcmV0dXJuOw0KICAgICAgICAgICAgIH0NCiAgICAgICAgICAgICB0YXJnZXQg PSB0YXJnZXQtPnBhcmVudE9yU2hhZG93SG9zdEVsZW1lbnQoKTs=