25687 2009-05-11 05:01:27 -0700 Missing check for valid function in V8 bindings for toString function for event listeners 2009-05-12 08:54:58 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 sgjesse sgjesse dglazkov oldest_to_newest 120624 0 sgjesse 2009-05-11 05:01:27 -0700 If creating the function for the toString property on event listeners fails an empty handle is used for the SetHiddenValue call. See: http://crbug.com/11734. 120656 1 30188 sgjesse 2009-05-11 07:27:20 -0700 Created attachment 30188 Patch to check for empty hadles. 120667 2 30188 dglazkov 2009-05-11 09:13:33 -0700 Comment on attachment 30188 Patch to check for empty hadles. r=me 120867 3 dglazkov 2009-05-12 08:54:58 -0700 Landed as http://trac.webkit.org/changeset/43566. 30188 2009-05-11 07:27:20 -0700 2009-05-11 09:13:33 -0700 Patch to check for empty hadles. 25687patch.txt text/plain 3194 sgjesse SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MzQ4NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDUtMTEgIFNvcmVuIEdqZXNzZSAgPHNnamVzc2VAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEJ1ZyAyNTY4NzogTWlzc2luZyBjaGVjayBmb3IgdmFsaWQgZnVuY3Rpb24gaW4gVjggYmluZGlu Z3MgZm9yIHRvU3RyaW5nIGZ1bmN0aW9uIGZvciBldmVudCBsaXN0ZW5lcnMgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1Njg3LgorCisgICAgICAgICogYmluZGluZ3Mv djgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHA6IEFkZGVkIGVtcHR5IGhhbmRsZSBjaGVja3MuCisg ICAgICAgIChXZWJDb3JlOjpWOExhenlFdmVudExpc3RlbmVyOjpnZXRXcmFwcGVkTGlzdGVuZXJG dW5jdGlvbik6CisKIDIwMDktMDUtMTAgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvYmluZGlu Z3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5k aW5ncy92OC9WOExhenlFdmVudExpc3RlbmVyLmNwcAkocmV2aXNpb24gNDM0ODYpCisrKyBXZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4TGF6eUV2ZW50TGlzdGVuZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xOTcsMTkgKzE5NywyMyBAQCB2ODo6TG9jYWw8djg6OkZ1bmN0aW9uPiBWOExhenlFdmVudExp c3RlCiAgICAgICAgICAgICAgICAgLy8gaXMgdGhhdCBzb21lIHdlYiBzaXRlcyB1c2VzIHRvU3Ry aW5nIG9uIGV2ZW50IGZ1bmN0aW9ucyBhbmQgdGhlIGV2YWxzIHRoZSBzb3VyY2UgcmV0dXJuZWQg KHNvbWUgdGltZXMgYSBSZWdFeHAgaXMgYXBwbGllZCBhcwogICAgICAgICAgICAgICAgIC8vIHdl bGwpIGZvciBzb21lIG90aGVyIHVzZS4gVGhhdCBmYWlscyBtaXNlcmFibHkgaWYgdGhlIGFjdHVh bCB3cmFwcGVyIHNvdXJjZSBpcyByZXR1cm5lZC4KICAgICAgICAgICAgICAgICB2ODo6TG9jYWw8 djg6OkZ1bmN0aW9uVGVtcGxhdGU+IHRvU3RyaW5nVGVtcGxhdGUgPSB2ODo6RnVuY3Rpb25UZW1w bGF0ZTo6TmV3KFY4TGF6eUV2ZW50TGlzdGVuZXJUb1N0cmluZyk7Ci0gICAgICAgICAgICAgICAg djg6OkxvY2FsPHY4OjpGdW5jdGlvbj4gdG9TdHJpbmdGdW5jdGlvbiA9IHRvU3RyaW5nVGVtcGxh dGUtPkdldEZ1bmN0aW9uKCk7Ci0gICAgICAgICAgICAgICAgU3RyaW5nIHRvU3RyaW5nUmVzdWx0 ID0gImZ1bmN0aW9uICI7Ci0gICAgICAgICAgICAgICAgdG9TdHJpbmdSZXN1bHQuYXBwZW5kKG1f ZnVuY3Rpb25OYW1lKTsKLSAgICAgICAgICAgICAgICB0b1N0cmluZ1Jlc3VsdC5hcHBlbmQoIigi KTsKLSAgICAgICAgICAgICAgICBpZiAobV9pc1NWR0V2ZW50KQotICAgICAgICAgICAgICAgICAg ICB0b1N0cmluZ1Jlc3VsdC5hcHBlbmQoImV2dCIpOwotICAgICAgICAgICAgICAgIGVsc2UKLSAg ICAgICAgICAgICAgICAgICAgdG9TdHJpbmdSZXN1bHQuYXBwZW5kKCJldmVudCIpOwotICAgICAg ICAgICAgICAgIHRvU3RyaW5nUmVzdWx0LmFwcGVuZCgiKSB7XG4gICIpOwotICAgICAgICAgICAg ICAgIHRvU3RyaW5nUmVzdWx0LmFwcGVuZChtX2NvZGUpOwotICAgICAgICAgICAgICAgIHRvU3Ry aW5nUmVzdWx0LmFwcGVuZCggICJcbn0iKTsKLSAgICAgICAgICAgICAgICB0b1N0cmluZ0Z1bmN0 aW9uLT5TZXRIaWRkZW5WYWx1ZSh2ODo6U3RyaW5nOjpOZXcoInRvU3RyaW5nU3RyaW5nIiksIHY4 RXh0ZXJuYWxTdHJpbmcodG9TdHJpbmdSZXN1bHQpKTsKLSAgICAgICAgICAgICAgICBtX3dyYXBw ZWRGdW5jdGlvbi0+U2V0KHY4OjpTdHJpbmc6Ok5ldygidG9TdHJpbmciKSwgdG9TdHJpbmdGdW5j dGlvbik7CisgICAgICAgICAgICAgICAgdjg6OkxvY2FsPHY4OjpGdW5jdGlvbj4gdG9TdHJpbmdG dW5jdGlvbjsKKyAgICAgICAgICAgICAgICBpZiAoIXRvU3RyaW5nVGVtcGxhdGUuSXNFbXB0eSgp KQorICAgICAgICAgICAgICAgICAgICB0b1N0cmluZ0Z1bmN0aW9uID0gdG9TdHJpbmdUZW1wbGF0 ZS0+R2V0RnVuY3Rpb24oKTsKKyAgICAgICAgICAgICAgICBpZiAoIXRvU3RyaW5nRnVuY3Rpb24u SXNFbXB0eSgpKSB7CisgICAgICAgICAgICAgICAgICAgIFN0cmluZyB0b1N0cmluZ1Jlc3VsdCA9 ICJmdW5jdGlvbiAiOworICAgICAgICAgICAgICAgICAgICB0b1N0cmluZ1Jlc3VsdC5hcHBlbmQo bV9mdW5jdGlvbk5hbWUpOworICAgICAgICAgICAgICAgICAgICB0b1N0cmluZ1Jlc3VsdC5hcHBl bmQoIigiKTsKKyAgICAgICAgICAgICAgICAgICAgaWYgKG1faXNTVkdFdmVudCkKKyAgICAgICAg ICAgICAgICAgICAgICAgIHRvU3RyaW5nUmVzdWx0LmFwcGVuZCgiZXZ0Iik7CisgICAgICAgICAg ICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgICAgIHRvU3RyaW5nUmVzdWx0LmFw cGVuZCgiZXZlbnQiKTsKKyAgICAgICAgICAgICAgICAgICAgdG9TdHJpbmdSZXN1bHQuYXBwZW5k KCIpIHtcbiAgIik7CisgICAgICAgICAgICAgICAgICAgIHRvU3RyaW5nUmVzdWx0LmFwcGVuZCht X2NvZGUpOworICAgICAgICAgICAgICAgICAgICB0b1N0cmluZ1Jlc3VsdC5hcHBlbmQoIlxufSIp OworICAgICAgICAgICAgICAgICAgICB0b1N0cmluZ0Z1bmN0aW9uLT5TZXRIaWRkZW5WYWx1ZSh2 ODo6U3RyaW5nOjpOZXcoInRvU3RyaW5nU3RyaW5nIiksIHY4RXh0ZXJuYWxTdHJpbmcodG9TdHJp bmdSZXN1bHQpKTsKKyAgICAgICAgICAgICAgICAgICAgbV93cmFwcGVkRnVuY3Rpb24tPlNldCh2 ODo6U3RyaW5nOjpOZXcoInRvU3RyaW5nIiksIHRvU3RyaW5nRnVuY3Rpb24pOworICAgICAgICAg ICAgICAgIH0KIAogI2lmbmRlZiBOREVCVUcKICAgICAgICAgICAgICAgICBWOFByb3h5OjpSZWdp c3Rlckdsb2JhbEhhbmRsZShFVkVOVF9MSVNURU5FUiwgdGhpcywgbV93cmFwcGVkRnVuY3Rpb24p Owo=