25684 2009-05-10 22:48:12 -0700 ScrollView::valueChanged compares the parameter pointer with m_verticalScrollbar/m_horizontalScrollbar 2009-05-22 22:48:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zecke zecke oldest_to_newest 120601 0 zecke 2009-05-10 22:48:12 -0700 While fixing a bug on GTK+ I noticed that ScrollView::valueChanged is using pointers to figure out the direction/axis of the scrolling. I couldn't find any reason for that, hence writing a bug report. 120602 1 30173 zecke 2009-05-10 22:49:03 -0700 Created attachment 30173 Use Scrollbar::orientation to get the orientation Why wasn't Scrollbar::orientation used for this? Is there any reason? 122599 2 30173 mjs 2009-05-22 01:01:31 -0700 Comment on attachment 30173 Use Scrollbar::orientation to get the orientation r=me 122801 3 zecke 2009-05-22 22:48:19 -0700 Landed in r44079. 30173 2009-05-10 22:49:03 -0700 2009-05-22 01:01:31 -0700 Use Scrollbar::orientation to get the orientation 0002-Ask-the-Scrollbar-for-the-orientation.patch text/plain 1792 zecke RnJvbSA4OGMwODE1ZmIwZjAwZmUyM2U3MDUwNGFiNGRkNDVhZTYzNDMzZmZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IE1vbiwgMTEgTWF5IDIwMDkgMDc6MzU6MDYgKzAyMDAKU3ViamVjdDog W1BBVENIXSBBc2sgdGhlIFNjcm9sbGJhciBmb3IgdGhlIG9yaWVudGF0aW9uCgpVc2UgU2Nyb2xs YmFyOjpvcmllbnRhdGlvbiB0byBmaWd1cmUgb3V0IHRoZSBkaXJlY3Rpb24gb2YKc2Nyb2xsaW5n LgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysr KwogV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcCB8ICAgIDQgKystLQogMiBmaWxlcyBj aGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dl YkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjM0NDQ5YS4uN2E2YjI2 MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTIsNiArMiwxOCBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgog CisgICAgICAgIEFzayB0aGUgU2Nyb2xsYmFyIGZvciB0aGUgb3JpZW50YXRpb24KKyAgICAgICAg CisgICAgICAgIFVzZSBTY3JvbGxiYXI6Om9yaWVudGF0aW9uIHRvIGZpZ3VyZSBvdXQgdGhlIGRp cmVjdGlvbiBvZgorICAgICAgICBzY3JvbGxpbmcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3Jv bGxWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OnZhbHVlQ2hhbmdlZCk6 CisKKzIwMDktMDUtMTAgIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8emVja2VAc2VsZmlz aC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NjQ2CiAKICAgICAgICAg W0dUS10gU2VuZCBvbnNjcm9sbCBldmVudHMgZm9yIHRoZSBtYWluIEZyYW1lVmlldwpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0v U2Nyb2xsVmlldy5jcHAKaW5kZXggNWJhN2JkYy4uNzc2NzgwOCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZp ZXcuY3BwCkBAIC0yNDAsOSArMjQwLDkgQEAgdm9pZCBTY3JvbGxWaWV3Ojp2YWx1ZUNoYW5nZWQo U2Nyb2xsYmFyKiBzY3JvbGxiYXIpCiAgICAgLy8gRmlndXJlIG91dCBpZiB3ZSByZWFsbHkgbW92 ZWQuCiAgICAgSW50U2l6ZSBuZXdPZmZzZXQgPSBtX3Njcm9sbE9mZnNldDsKICAgICBpZiAoc2Ny b2xsYmFyKSB7Ci0gICAgICAgIGlmIChzY3JvbGxiYXIgPT0gbV9ob3Jpem9udGFsU2Nyb2xsYmFy KQorICAgICAgICBpZiAoc2Nyb2xsYmFyLT5vcmllbnRhdGlvbigpID09IEhvcml6b250YWxTY3Jv bGxiYXIpCiAgICAgICAgICAgICBuZXdPZmZzZXQuc2V0V2lkdGgoc2Nyb2xsYmFyLT52YWx1ZSgp KTsKLSAgICAgICAgZWxzZSBpZiAoc2Nyb2xsYmFyID09IG1fdmVydGljYWxTY3JvbGxiYXIpCisg ICAgICAgIGVsc2UgaWYgKHNjcm9sbGJhci0+b3JpZW50YXRpb24oKSA9PSBWZXJ0aWNhbFNjcm9s bGJhcikKICAgICAgICAgICAgIG5ld09mZnNldC5zZXRIZWlnaHQoc2Nyb2xsYmFyLT52YWx1ZSgp KTsKICAgICB9CiAKLS0gCjEuNi4wLjQKCg==